Received: by 2002:a05:6500:1b41:b0:1fb:d597:ff75 with SMTP id cz1csp249186lqb; Tue, 4 Jun 2024 10:08:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU3VrqKosqNv+ExjTZK+LiICRIex9uCmAs25ciNknaukTsUIeaOiiLt8rSgtCrjZRKHzKblHQry5iezzJiUYAUuAkWFyB8T2jayUF6iBw== X-Google-Smtp-Source: AGHT+IEd4zlHhtHGuS+84/3gypoDxxW32/6MDF+PriFAwpGNyuWBj6z1AObxj/aiQaAXeSRxR6jg X-Received: by 2002:a17:90a:9ac:b0:2bd:d2fa:275f with SMTP id 98e67ed59e1d1-2c27db68101mr44672a91.41.1717520937714; Tue, 04 Jun 2024 10:08:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717520937; cv=pass; d=google.com; s=arc-20160816; b=xyWRYhpa7u4VDv016yQU53WlUE1WYqQdPbUYe+rswFnBbH6+DscgQpjcTqgEgaqS86 +P/hdJhgFU0ZxDD1OvfGlYhIQ2RymAc8SBIBrulGZ9XqAHiTIWGgtWx3s/C8+i2raCyF Tr/wgFKfJYMaRRoAVTlTCwkd6xu6FkEkBkIZMWtQMnk1zaOt+0bkes/yna01zKbSGvq1 CzIneCuZr6JFJiF5OImGcAXVA5uKyo6XPCHP2SRcVrLzLk7hXyh3uFyKTEcEeb5z03ve 26x8lj73LlqsmPBbSCuW8LWnkrQYibS6UHLvxGptB7/SHZS06xSTZ9Bwhq7N3ciRbZQB /zZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GRSHuLxBA8GqJU6trGZirNz2Yt8gkiylDCGcxUHAu8g=; fh=hXsv+jejq8/3/g1iiIXAgJiaaEraDEG+dJ/UjoCG4Fo=; b=zYuv8m1bYG38peIU0Ip4Elxj0h9HcsOt0kwTiPNDIWLxR9W1XqEugbTm1TGdNKORkl ibthe1OctFjANNXWqgEC61mt78T2YXL8LuCms1N01888adskNQzfX0sUxrUY7I2Lw9qh qa0bpmZs8keKUsixq4zHqMrWX5nJZ7jpEvvXykwA8NpEzUDdwaxTTuehRV/33a/R0mdf ZXHatvMixUBGbb8OOPT0Se/aBsIWMNoqFFNmr7jK+q9FxBB6CCSpAec+5u2K0TybgI1/ 0bIG2bYxvWKviBMkulRzdyfCb2DElBQqsTL7b9tjphbi83P2LNbwgAvXmU4NNhIGq9Jq 2arg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gnbSj/j+"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-201134-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201134-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1a77b6323si1574431a91.117.2024.06.04.10.08.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 10:08:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201134-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gnbSj/j+"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-201134-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201134-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E1668284FCC for ; Tue, 4 Jun 2024 17:08:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52F88149DEF; Tue, 4 Jun 2024 17:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gnbSj/j+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DFC81494DB; Tue, 4 Jun 2024 17:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717520887; cv=none; b=ow0FFW+IoPRR/K79xKfJJqrvrc9laeVIOHv9o9aHh4IV3vlHh10orWBhCCEesQCtEAXOMNFNeB6AB4sX5Ce6QnnQK4C0kYX6ZtgpDuTx/nRGe3g3kFhiu11jA0XYHU58qZFd5bWGEzgx5P81VdbToqeEdje+7QQssWhqHXfcoRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717520887; c=relaxed/simple; bh=54ydihiRs3glxrB7j/VdgJfU7tdLQHeIoW/Ag/kejKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q1eSejn7815kzmomLQ2vGEz72187+u53leJf1+fJcWs4kAVgV3RwJOpOaeZYoUFt3cADrn1xc4F59ZgIxTUp2d/gPFdU8qzvitPDVwKyzkieENnuZB9fwOU7QeBtX0W4mA7DiMTxbGgrtiguG/1ZPJe4LmCGXs+Oy14WX1TdQwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gnbSj/j+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91ED0C2BBFC; Tue, 4 Jun 2024 17:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717520886; bh=54ydihiRs3glxrB7j/VdgJfU7tdLQHeIoW/Ag/kejKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gnbSj/j+GifQ7H4Z4ICILKkdyo0+KlrBQ+gxHcdwdXJ+Q2W49CVb8vW4agM5ba3zB CmAWMTeFiz7Fz500K+4mjrN0fql9jTYK8o0YWXbjoSvtxSKlc+P0esCcSuWQk7E22D Q/hGLntRGrf9TCvgt2Ul4XSt1Zgyy9k2lAwxBFvYH6gcAiApDDMb7Eyon8UR9dxoYc b2qI0MD4VjZvPMEKW2RRHlcTAgL0O16zmp6clO90EDe5mMZ42AghgGH3gpD6NATU8H MXcxD8fIopZYm9VAE5gh5U3MQC6bVUBwxAawjizw9zjBptsNsdWuMlAzcweN/MJf2X 1K1U1p6ioIdtg== Date: Tue, 4 Jun 2024 18:08:02 +0100 From: Simon Horman To: linux@treblig.org Cc: allison.henderson@oracle.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr' Message-ID: <20240604170802.GC791188@kernel.org> References: <20240531233307.302571-1-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531233307.302571-1-linux@treblig.org> On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > 'rds_ib_dereg_odp_mr' has been unused since the original > commit 2eafa1746f17 ("net/rds: Handle ODP mr > registration/unregistration"). nit: Maybe commit lines are best not line-wrapped. I'm unsure. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert The above not withstanding, this looks good to me. Reviewed-by: Simon Horman