Received-SPF: pass (google.com: domain of linux-kernel+bounces-201099-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <13494237.uLZWGnKmhe@kreacher> <8366982.T7Z3S40VBb@kreacher>
 <bf3ebf1571a4788e97daf861eb493c12d42639a3.camel@xry111.site>
 <6d5ee74605bd9574baa5ed111cb54e959414437a.camel@linux.intel.com>
 <6ebadacd8aaa307a5766cdb1b4d4a5c69acd87ac.camel@xry111.site>
 <30a30c5107a47a2cc3fd39306728f70dd649d7fe.camel@linux.intel.com>
 <f382e06635b3b52841d1e0c11dcf639d225edae0.camel@xry111.site>
 <29d69252dcdc398f147c9139a8666d09e7bd831d.camel@linux.intel.com>
 <0324bc3a88654855719cd48a5ed69a34eea31037.camel@xry111.site>
 <c3526e7a0e80ec1a3a011259c38ab4b772040ea4.camel@linux.intel.com>
 <48eba83030e155f703b4248e9c1ae65aa44b1a83.camel@xry111.site>
 <CAJZ5v0jjLgG3VY_kBYc4mTrL2ybD2LfBTk2_H7xY0+Aq5g827A@mail.gmail.com>
 <f34c20ae3feac0e3570125f124e440d51c5e4d9b.camel@linux.intel.com>
 <1da736da33a61de92314934ecf7fa0420d6d6b81.camel@linux.intel.com>
 <aa643910265b9d92a397d5148b31d37b2c421b8b.camel@xry111.site>
 <63e98f2151ef64de92cf7e3da796937755ea5552.camel@linux.intel.com>
 <258ce61c155c28937620f6abe57a39f2b4b0ff56.camel@xry111.site> <101b903e58f2ebae60934edc374c7cda09f83de1.camel@linux.intel.com>
In-Reply-To: <101b903e58f2ebae60934edc374c7cda09f83de1.camel@linux.intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 4 Jun 2024 18:46:53 +0200
Message-ID: <CAJZ5v0jBBgjBny0Ps9bvHc7q1Un_6sdudpNL0==Z5HB+gHH0Hw@mail.gmail.com>
Subject: Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update
 global.turbo_disabled after initialization
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Xi Ruoyao <xry111@xry111.site>, "Rafael J. Wysocki" <rafael@kernel.org>, 
	"Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux PM <linux-pm@vger.kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 4, 2024 at 6:41=E2=80=AFPM srinivas pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Tue, 2024-06-04 at 18:32 +0800, Xi Ruoyao wrote:
> > On Tue, 2024-06-04 at 03:29 -0700, srinivas pandruvada wrote:
> > > On Tue, 2024-06-04 at 17:30 +0800, Xi Ruoyao wrote:
> > > > On Mon, 2024-06-03 at 21:31 -0700, srinivas pandruvada wrote:
> > > >
> > > > > > > Second, a delayed work can be added to check the MSR long
> > > > > > > enough
> > > > > > > after
> > > > > > > initialization and update global.turbo_disabled if it is 1.
> > > > > > > However,
> > > > > > > that would require some code surgery.
> > > > > >
> > > > > Something like the attached which does same way as user space
> > > > > no_turbo
> > > > > update.
> > > >
> > > > >  static int intel_pstate_register_driver(struct cpufreq_driver
> > > > > *driver)
> > > > >  {
> > > > >         int ret;
> > > > > @@ -3114,6 +3137,9 @@ static int
> > > > > intel_pstate_register_driver(struct cpufreq_driver *driver)
> > > > >         global.turbo_disabled =3D turbo_is_disabled();
> > > > >         global.no_turbo =3D global.turbo_disabled;
> > > > >
> > > > > +       if (global.turbo_disabled)
> > > > > +               schedule_delayed_work(&turbo_work, HZ);
> > > > > +
> > > >
> > > > I have to change it to 20 * HZ to make it work for me.  15 * HZ
> > > > does
> > > > not
> > > > work.
> > >
> > > Is there any consistency or it is changing every time?
> >
> > It seems consistent.
> With such a delay, I am not sure how this even worked before.
> Can you revert the patch in question and use kernel dynamic debug
> dyndbg=3D"file intel_pstate.c +p" kernel command line and collect log for
> 30 seconds?

I think that it worked because the MSR was read every time
intel_pstate ran, so it got updated at one point and stayed that way.