Received-SPF: pass (google.com: domain of linux-kernel+bounces-201166-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 4 Jun 2024 18:34:34 +0100
From: Conor Dooley <conor@kernel.org>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	David Lechner <dlechner@baylibre.com>, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dumitru Ceclan <mitrutzceclan@gmail.com>
Subject: Re: [PATCH v5 2/9] dt-bindings: adc: ad7173: add support for ad411x
Message-ID: <20240604-darkish-paprika-351ad2f72e96@spud>
References: <20240603-ad4111-v5-0-9a9c54d9ac78@analog.com>
 <20240603-ad4111-v5-2-9a9c54d9ac78@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ICeoNF/w62bKpKgP"
Content-Disposition: inline
In-Reply-To: <20240603-ad4111-v5-2-9a9c54d9ac78@analog.com>


--ICeoNF/w62bKpKgP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 03, 2024 at 07:23:00PM +0300, Dumitru Ceclan via B4 Relay wrote:
> +      common-mode-channel:
> +        description:
> +          This property is used for defining the negative input of a
> +          single-ended or pseudo-differential voltage channel.
> +
> +          Special inputs are valid as well.
> +        minimum: 0
> +        maximum: 31

I think this property, since it purports to be a common one due to the
lack of a vendor prefix, should be documented in adc.yaml.

> +
>        adi,reference-select:
>          description: |
>            Select the reference source to use when converting on
> @@ -154,9 +213,31 @@ patternProperties:
>            - avdd
>          default: refout-avss
> =20
> +      adi,current-channel:
> +        description: |
> +          Signal that the selected inputs are current channels.
> +          Only available on AD4111 and AD4112.

> +        type: boolean
Instead of boolean, use:
    $ref: /schemas/types.yaml#/definitions/flag

Otherwise, I think this all looks okay.

--ICeoNF/w62bKpKgP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHQEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZl9QKgAKCRB4tDGHoIJi
0opdAPdU6LlCW4TffD6ame5jjBfZLhk26hiOVuyNlT53peXSAQDWQrG9YcGs8XyW
xH1awVu8+MXKYRpbKhXBTh+nSqahDw==
=TIka
-----END PGP SIGNATURE-----

--ICeoNF/w62bKpKgP--