Received-SPF: pass (google.com: domain of linux-kernel+bounces-201259-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 4 Jun 2024 15:55:21 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: will@kernel.org, robin.murphy@arm.com,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, joro@8bytes.org, nicolinc@nvidia.com,
	mshavit@google.com, Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Avoid uninitialized asid in case of
 error
Message-ID: <20240604185521.GO19897@nvidia.com>
References: <20240604185218.2602058-1-smostafa@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240604185218.2602058-1-smostafa@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YwmMbSL2oSQ5FNUZKcnHQWiAHfnNh1KNItfgS33QDLhldUJFccXbAoIgXMh6?=
 =?us-ascii?Q?4gCVCmwBjevFXxFIbmdfD3N9KIEIW5RGrWGUo0kJsk520hq5FKXrqIpzHCaF?=
 =?us-ascii?Q?3GcHqV5aZljaEuAwA+eDyqq2X4m6XvfrOJkxcVdonzFV3foCg/LVlCxulHo5?=
 =?us-ascii?Q?51/Q6yfDLAHHhEjCZsVr6Syv59EZ5DCpSZl56E4FpJRibt6NR8Ji4tVduPHZ?=
 =?us-ascii?Q?QOrMWIcV9AHlROfiUeQOI5ijXDqMx5H7mQeGGiQWvgqF2frYpyhBb6DagRmU?=
 =?us-ascii?Q?EeCrbBIt0v+5UDgC+V/6IUeMovJ5zYFzdpdsikREHE4Wcr+WGMMzpm/rhEg4?=
 =?us-ascii?Q?1gi/hdyt6+wI7QrhNtfChhCv4gTpcoXmMUqNX1377zpiuPgfVC/peY2p68AU?=
 =?us-ascii?Q?Z6oWu8M1Uof6fkMDiOIet4pjviTIpvbH+jYt81nYYk+cjGORWvgFa3WKLYJr?=
 =?us-ascii?Q?vG9DCy5Hyjc+5SvkwpBdQrPhzfSKBCK9oAUB/ZDYe+YThDQ9LvbnpbIs5iF+?=
 =?us-ascii?Q?HzI00nJvGjycWznnJ5Buo5/Mt1Oa8NnnzWVGfeySlJ54gDos7PGkTIKEIUJy?=
 =?us-ascii?Q?1YEn+1EwImEh8Zb49KROULGz/2uLK0W8mcVSZn8g0Zs3Qtiu6J0HN8wZxKZp?=
 =?us-ascii?Q?QqvimDMDd5eiWbg+n29HZDJQLpf2l7/kUot8kX6ok0MxJO9ccxF3lHBZzUdJ?=
 =?us-ascii?Q?yAV4eLqoooARsqfocrmzimequmiX4EQX9Mb4/f3zD/mNbGmVXjwJOBaLegzZ?=
 =?us-ascii?Q?tgh+bikpxEWvn2iTlr4UY5OwMRQ/vH8CQ5xgN4s2HRJp1GzZq2FlYaHyYo9G?=
 =?us-ascii?Q?CJeFY2XGh7K8jJn0W50pJznus2+MVHgu3nYqB6OVcQBBfCVg+a8bMIiF7kPp?=
 =?us-ascii?Q?qlbS8x2qH2cbFgOEyzeZzeBFD/CQfJ9+e9DJKWtKTZBq3qODfWXbT14c0Pqi?=
 =?us-ascii?Q?3KBGgsEfSdg4AdFFQ8t5oWu+2FPzDiGGrtC0G6lLWgBgh1tz0LiG0iJE7vWO?=
 =?us-ascii?Q?RJFyEbDe7rKqyUjmWcab2Zzu58GbVxO02WgRW4hCd/1DhpxmiVMH1l5doyQM?=
 =?us-ascii?Q?Xz6doQLZXtolG92KIOk4YRZ+S8aVe1TtP7gTvwZu3YCnRqhyNaqfxZCFmJGy?=
 =?us-ascii?Q?UR2tBAtTSgslpK3nFwjaKBMB6qUMeXHrspLrwMpy2LB/5hBrkOt+2CU6oL0v?=
 =?us-ascii?Q?YBJfKGc+K3O3pkVNYoZ91Y/N1DmsrB1YT2CWDjX+hqVkKhKjzaUTb8UajiP6?=
 =?us-ascii?Q?GHyNN2/yY42ZKSt0WtWdnm/47c7nOTQS3ganQEfbjwgzZswvI0u3MFFb4FqM?=
 =?us-ascii?Q?U2okwhsxwFZXGyWByiptRU5qT5eSUEYDcLV/L8TP9S9Ci9b1dH/wmiX2B9m3?=
 =?us-ascii?Q?nmF1lAvMNxIhzSbdqz4nsWO2bH9RgSBThqtNlbKzxD1+skjdOlwdAgW72qdh?=
 =?us-ascii?Q?gXKifLPkFgW//G1wuGVHUS+v8FIqJBYsjxNhGJuqAvSmb6Y2O0dDf/TTeeYM?=
 =?us-ascii?Q?jzs7vOiTzLnX8NtZEtHnUb7WULsUzQc+PQUXZUmwPwPy/nA2O9o1ZjLL3vKt?=
 =?us-ascii?Q?Aqj1tg2chngIgK9VMiKCazRxPKMaxzkJxUq+3Pbv?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1610fad7-6758-4ab4-9878-08dc84c7e350
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 18:55:22.8043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +ft5ZeW0mMHGMaNVFevpLNsnKQ8Nlj0ZwArz8d1rjU4aZKt1U9Bg3Qx2LP+9oLwm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9200

On Tue, Jun 04, 2024 at 06:52:18PM +0000, Mostafa Saleh wrote:
> Static checker is complaining about the ASID possibly set uninitialized.
> This only happens in case of error and this value would be ignored anyway.
> 
> A simple fix would be just to initialize the local variable to zero,
> this path will only be reached on the first attach to a domain where
> the CD is already initialized to zero.
> This avoids having to bloat the function with an error path.
> 
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes:https://lore.kernel.org/linux-iommu/849e3d77-0a3c-43c4-878d-a0e061c8cd61@moroto.mountain/T/#u
> Signed-off-by: Mostafa Saleh <smostafa@google.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks this TODO is in my pile of emails :\

Fixes: 04905c17f648 ("iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd()")
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

(mind the missing space 'Closes:')

Jason