Received-SPF: pass (google.com: domain of linux-kernel+bounces-201267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <28a9290e-b8af-93bb-26d3-3b12864ada4e@igalia.com>
Date: Tue, 4 Jun 2024 16:05:18 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 7/8] efi: pstore: Follow convention for the efi-pstore
 backend name
Content-Language: en-US
To: Stephen Boyd <swboyd@chromium.org>
Cc: kernel-dev@igalia.com, kernel@gpiccoli.net,
 linux-fsdevel@vger.kernel.org, keescook@chromium.org, anton@enomsg.org,
 ccross@android.com, tony.luck@intel.com, linux-efi@vger.kernel.org,
 Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org
References: <20221006224212.569555-1-gpiccoli@igalia.com>
 <20221006224212.569555-8-gpiccoli@igalia.com>
 <CAE-0n50vo5xkUNK0-cF9HZRXShsxbikqmdVnmMzRsn+Z7MEJTg@mail.gmail.com>
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <CAE-0n50vo5xkUNK0-cF9HZRXShsxbikqmdVnmMzRsn+Z7MEJTg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 03/06/2024 20:02, Stephen Boyd wrote:
> [...]
> This patch broke ChromeOS' crash reporter when running on EFI[1], which
> luckily isn't the typical mode of operation for Chromebooks. The problem
> was that we had hardcoded something like dmesg-efi-<number> into the
> regex logic that finds EFI pstore records. I didn't write the original
> code but I think the idea was to speed things up by parsing the
> filenames themselves to collect the files related to a crash record
> instead of opening and parsing the header from the files to figure out
> which file corresponds to which record.
> 
> I suspect the fix is pretty simple (make the driver name match either
> one via a regex) but I just wanted to drop a note here that this made
> some lives harder, not easier.

Oh, many apologies for that Stephen - of course if I was aware of the
hardcoding in the tool, I'd not mess it up or would fix the tooling
first, before changing the kernel code.

At least, as a bright side here you found the tool's limitation and
there's the obvious improvement/fix for that =)

Cheers,


Guilherme