Received-SPF: pass (google.com: domain of linux-kernel+bounces-201284-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 4 Jun 2024 15:27:28 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
        linux-mm@kvack.org, akpm@linux-foundation.org,
        zhangpeng.00@bytedance.com, willy@infradead.org
Subject: Re: [PATCH 05/18] maple_tree: set store type in mas_store_prealloc()
Message-ID: <dn5l7tqprodlne4uxp2fg3wzu6qtvjfp7mbcshphovm7digi4f@53aizlonrrm6>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Sidhartha Kumar <sidhartha.kumar@oracle.com>, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, 
	linux-mm@kvack.org, akpm@linux-foundation.org, zhangpeng.00@bytedance.com, 
	willy@infradead.org
References: <20240604174145.563900-1-sidhartha.kumar@oracle.com>
 <20240604174145.563900-6-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240604174145.563900-6-sidhartha.kumar@oracle.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?XQrNZjoJaL/Z0IwRqf65+OQMBZQNix94GYCalmWpK9EsfLpTxQ8j2VdVH9nh?=
 =?us-ascii?Q?0J+atx+77Chi5RovVHw2NRCnX9ghqyE0gf7B/+xU+1q9rgQe2/HAalIq9KxG?=
 =?us-ascii?Q?XFv6pBRUgDxzNQ2cP+uFHp2FYraEuolBljPX2nsAw0KFnoFT9NVNs+IK7rH9?=
 =?us-ascii?Q?hP3ldHVYxf8CzuXeSdtCvekcn+VdmoAYU3iCUdDaOpA7UIlZLnhW2A8WYcjj?=
 =?us-ascii?Q?k9kyu+QNQ/zZIQ1dAR9ner1IkEeOxsD5nsq34XLSHeVqUWOTUTGJDnxrRihq?=
 =?us-ascii?Q?6OjT7GmqiCe3+uUmmUntQFpkTXIi0lGbNDWIAIzUsbEQGpRgxBvwf3GaDszA?=
 =?us-ascii?Q?LDNFcyzty544AeLUFeHtnqwIBp57ynreYrvDjfzo2ClGW5OBgoT0e95oBWyH?=
 =?us-ascii?Q?bx07aM1LTcT6vaYBcyG4bdHHT0bZ4qOBnQc0YUWOv5MqvejkZZGSUAbTlomm?=
 =?us-ascii?Q?NxhqdVeeeZsJHhOuyvW1qazZNXXF8RPAI1pzXIHH9tBwotD6M5dyIzL1lnDV?=
 =?us-ascii?Q?UskqqF5oVlSxuWt5IsIPlcotU7/xmhGFBgg583OkyQMBhToFdl8KqUlEkST0?=
 =?us-ascii?Q?XZeg+skq8McQ8H89Ne+ufpjZvbjYW9k9iMMdRAySqCoTD+4LvC/9BhQOOoBB?=
 =?us-ascii?Q?L/xDVxfYtK5GjWJ/02o/cV40ASgH7zn1l6b8P4Kv2l4ZYZZEkqGCletemMey?=
 =?us-ascii?Q?nNzTmKklBPS4QeWSDpwJx6hcylllfZmnghL4zzqJ5ksU8pbDJ+kL2HmlPdHW?=
 =?us-ascii?Q?Niicps4RMM6N0E/l/IuNWpD8csfvigeOHThEM0158a78wS/UQls74Ja8a+bN?=
 =?us-ascii?Q?81fjyvPrj/c+DB2rEs8+9glvUN1wjZJaViXMcXilNkp0Z8V5tsK8+xE1bb5X?=
 =?us-ascii?Q?4fzcKz3o/XLuA5MoLEKqAqQOE+uKeCjZVcS+FWdNJHEpvFbDgYj/uervvrNc?=
 =?us-ascii?Q?m1R2+ZDsSp+UueMpJglPBdLDbEd25eGhSOk2doqzm2XK07uGYGkOpVe+q9lX?=
 =?us-ascii?Q?4tlvc2/RqnU68PMLKdEX92VgzgkQ6pFc5eiUbppBUnG2XAWgkyA+YHGHOpb3?=
 =?us-ascii?Q?vQ/Ppf0uWX+g3JQHGLeYAjjMrS+JstFBHGfOiXxB9juy1NK9sCjWOTWPpAWU?=
 =?us-ascii?Q?IPuffSde5Ie5mS5fuKEXQ49/wRx5YqHRRZ1ZAqq+2zdWnKMjEjdyE+vR3pSl?=
 =?us-ascii?Q?WFwrpwa7B/iEj0e5eFki15AKCIFMSFNVGCbmR3FgCHtemSk823TR/OHsdMQc?=
 =?us-ascii?Q?K6p9uU33Ajqa/Wb7lgB+PkY8vU50fD76s0sD1yJzshFNotOeWdDIOt6QJ5y3?=
 =?us-ascii?Q?+1fEeZ37ZKS+DydeYXYzO+0MXYCj0NtbSd1QGQ9S1Ak1SzYKHRqLC45/okoE?=
 =?us-ascii?Q?yL/L20sKmGnYREyIRo+dOzxsDRci3F+Ks+anFKWHPqnmZ6Ics5d1ulJnm6q5?=
 =?us-ascii?Q?hD7eHIk23ag9H+uLKGr6mIrj4Q63i9nnleXnJoP3S7CxPd26MJafF8tBu1bH?=
 =?us-ascii?Q?r1rBJ5Pch7k+8z0w3hePDIqucQM/I8xHZ6UMi9pcLw+qQDMElhNoKrsvrJyT?=
 =?us-ascii?Q?mjdeZJ5j/Rl2WOyDTD148b9AoyKRZmC85S/xEcWQ?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	41qgYMWUOhH/688FL0hZiBjgPIbSZxV3N/WvUzqJ1nDqU0HPFjrxs2xODCC3R25RuvHXqba6039NM4PdtU8IuYbiWE0fpIttwW6/ASi8l93j7vFAsn/Qsue89SAC5wv9s3vb1DDWBgCxQrH397ICkvaPt4v4xM5ng+F4f26VZHnzIfcihZN1g2X6elXGpZRwufXI3joKpp6fI89EN5EHbgwergAuEgLA6VUk7z3opR/7Am/0BmWHb+9ArS63ag5Vp1IdygsngwURxbM22JKXLtjFATEl8l0b6mjVUYuAV4F5e5nYvQ0oAcL6B2GvSeP4VQFvcOtFh/eph9E8IMnsR8McMkfx9k9/UzXW/PuJ3mcDxuExs83F938Nv0F/g5MDob9pUZlaGd5WAixQhsnifgNxvXYil+nIyGRBlv1YODIOd49D9VthcOlk0Sq0sbaz8yPvfs00NsOawSFL34OXNCtpf0mpoFC1HfVeqLC/iMn5UTjWVYWv+U+s2kMh5pqLoC+cOfjasd8ksl/6snUJDzWRSLO1QLZoFZUIpOApqFpdq07MehdEUGBjCu7+O7TnjL0c+DLyMIASveCwJDs0tT/LgxlUm6R676MHZm3hJqM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fee1427-c3c9-4d21-dd03-08dc84cc6030
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 19:27:30.3132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uBI7WsDIfudmtYBbKpwKO1Zi1w6Vs6f4hX8BmxmDa+d6EIC0kYhofHwgrmx4v0ZRw2OaGctrklWM/Gpdm5vt2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5176
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_09,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406040156
X-Proofpoint-GUID: H3QUZGeIqq1GiL29eKT7NO3ZVhTusqNS
X-Proofpoint-ORIG-GUID: H3QUZGeIqq1GiL29eKT7NO3ZVhTusqNS

* Sidhartha Kumar <sidhartha.kumar@oracle.com> [240604 13:42]:
> Set the store type in mas_store_prealloc(). This is needed as
> mas_wr_store_entry() will be modified to read the store type to make a
> decision about how to complete the store.

You have two of these small patches, one has a different description
"set write store type" vs "set store type".  I think they both can be
combined into the mas_wr_store_entry() modification?  They are pretty
straight forward and the commit log can explain them.

> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  lib/maple_tree.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b37fa8690558..3780d4bb0415 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5631,7 +5631,8 @@ void mas_store_prealloc(struct ma_state *mas, void *entry)
>  {
>  	MA_WR_STATE(wr_mas, mas, entry);
>  
> -	mas_wr_store_setup(&wr_mas);
> +	mas_wr_prealloc_setup(&wr_mas);
> +	mas_wr_store_type(&wr_mas);
>  	trace_ma_write(__func__, mas, 0, entry);
>  	mas_wr_store_entry(&wr_mas);
>  	MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas));
> -- 
> 2.45.1
>