Received-SPF: pass (google.com: domain of linux-kernel+bounces-201312-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fc940d6d-7ac3-4f69-8ace-459955f72281@foss.arm.com>
Date: Tue, 4 Jun 2024 21:01:41 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC/PATCH 1/1] tools headers arm64: Sync arm64's cputype.h with
 the kernel sources
To: Mark Rutland <mark.rutland@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
 Besar Wicaksono <bwicaksono@nvidia.com>, Will Deacon <will@kernel.org>,
 Adrian Hunter <adrian.hunter@intel.com>, Ian Rogers <irogers@google.com>,
 Jiri Olsa <jolsa@kernel.org>, Kan Liang <kan.liang@linux.intel.com>,
 Namhyung Kim <namhyung@kernel.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-perf-users@vger.kernel.org, James Clark <james.clark@arm.com>
References: <Zl4MYzhP0NB-Z1DW@x1> <Zl7aOk2h4_73JmUu@J2N7QTR9R3>
 <a1990b2e-2c10-42b6-93e9-fef324cb91b2@arm.com> <Zl9jLtiFagBcH7oH@J2N7QTR9R3>
Content-Language: en-US
From: Leo Yan <niayan01@foss.arm.com>
In-Reply-To: <Zl9jLtiFagBcH7oH@J2N7QTR9R3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/4/24 19:55, Mark Rutland wrote:

[...]

>> Now more and more Arm CPUs support the data source in SPE and share the same
>> data source format. It's not scalable for us to adding every CPU variant
>> into the file util/arm-spe.c.
>>
>> I would like to expose the PMSIDR_EL1.LDS bit (Data source indicator for
>> sampled load instructions) via the 'cap' folder, and then we can save this
>> info into the perf meta data during record phase.
> 
> I'd be happy to expose fields from PMSIDR_EL1.
> 
>> In the perf report, we can parse the meta data and if the
>> PMSIDR_EL1.LDS bit is set, the tool will parse the data source packet
>> based on the common format.
> 
> I don't believe that's right.
> 
> PMSIDR_EL1.LDS indicates that the loaded data source field is
> implemented, but even when it is implemented, the format is
> IMPLEMENTATION DEFINED.

Thanks for correction. PMSIDR_EL1.LDS bit is necessary but not 
sufficient for using the common data source format.

> Today, Arm Ltd implementations happen to share a format, but that isn't
> implied by PMSIDR_EL1.LDS, and there's no guarantee that future CPUs
> will all use the same format.
> 
> For the moment we'll have to keep adding to this list.

I would like to use an opposite way - we can only maintain CPU variants 
with special data source format, otherwise, all other CPUs use the 
common format.

Thanks,
Leo