DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=rcGsi6l9ko303gjvlWeVsxRQooASsYgZyIXwSdIw4IgSEvDKaAGpekAZPW1jphh5A4uZWHBWbXAdUvsIVqvJ30yoQ7g2r/Ro46gcJlZxSpwmAMOBusa+ZVykAiUmAFBsOiBKodHko/bX8OuH3WLYTIsGN05SWc5Hd0zjdhyWmoY=  ;
From: David Brownell <david-b@pacbell.net>
To: Marc Pignat <marc.pignat@hevs.ch>
Subject: Re: [PATCH] at91_mci:  use generic GPIO calls
Date: Tue, 5 Feb 2008 02:07:44 -0800
User-Agent: KMail/1.9.6
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
       Nicolas Ferre <nicolas.ferre@atmel.com>,
       Pierre Ossman <drzeus-mmc@drzeus.cx>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       Andrew Victor <linux@maxim.org.za>
References: <200802011901.27532.david-b@pacbell.net> <47A74790.50207@atmel.com> <200802051053.33105.marc.pignat@hevs.ch>
In-Reply-To: <200802051053.33105.marc.pignat@hevs.ch>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802050207.44721.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1008
Lines: 29

On Tuesday 05 February 2008, Marc Pignat wrote:
> Hi all!
> 
> >  /*
> > @@ -946,9 +986,10 @@ static int __exit at91_mci_remove(struct
> >  	host = mmc_priv(mmc);
> >  
> >  	if (host->board->det_pin) {
> > +		if (device_can_wakeup(&pdev->dev))
> > +			free_irq(gpio_to_irq(host->board->det_pin), host);
>
> Seems strange to use device_can_wakeup(&pdev->dev) as
> have_we_requested_this_irq(gpio_to_irq(host->board->det_pin))... but seems to
> work.

Yeah ... it only works because the device_init_wakeup() is
done in the driver (sigh) instead of the device setup code.
Now that's only done if that IRQ was correctly requested,
so that bit does double duty.

Previously the driver always freeed that IRQ, even if it
hadn't actually managed to request it ... ;)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/