Received-SPF: pass (google.com: domain of linux-kernel+bounces-201329-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <532aa50e-b8e5-4e8e-a2bd-a05fd81274dc@web.de>
Date: Tue, 4 Jun 2024 22:06:14 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: kernel-janitors@vger.kernel.org, Chanwoo Choi <cw00.choi@samsung.com>,
 MyungJoo Ham <myungjoo.ham@samsung.com>,
 Stanley Chang <stanley_chang@realtek.com>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] extcon: realtek: Use scope-based resource management in
 extcon_rtk_type_c_init()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:G+pSpadvric=;2EdbEimaqR1zhnAl1Odt2yDHrIZ
 j2XPfbzrkmiVTG1OeuCx1a58gDVUOCVQDgt4HrCeckwzyUJItFRZr5RLKcgILgsXljwUNISWs
 G+HdNEoh1BSOq7MXaELkRfimlCsdGh3ijPMTYz+g/apY2j5xoJTwaztHvWET7w5pbmTdZvd6E
 SWfMIjf2LL3TuDb9SKBHKJe5XcvGNxZ9awzL/c+TAxP4xhNL2ubBa9R6/wlp3n6HDFvBfq/CX
 0pInHr5v5AdBe2GTVgrlaOKZK0uQYGsLGtlTklHq0CUB/HVa9g2oRGy39UXWBkDitznLbsrSZ
 AUKMCN/OKHirU61Tj+l7z4WhmM6vbnCXcOQQqUHoN9SGePYyftjx4NDger5+vsGaifqDrKsKO
 jEu79XqxIOWlvZ7KGJYjT6MOnoXNU/737tBd/j5hPtEqsk5GbeOTIb89XhPEbsgsmZH9PZzOg
 4KOQ3QtwP5OfEBSbNYSQnFezCYGg0wUNFz4Fm2Zk0vBfkyTptelpRoUxn9wdQEaZmLb/Vw4pe
 6J+aVk/0x9fenrmtBWnxxbhDly4h9ZwtnDkVfOdGqBRnqcZl3HcBHRcl2AtDa9BQ5+uSWfKu6
 I77mQAddGs9BXVoXNJMOAmy4QZao0Lt6Rj3EKhzfpMnAgYyOxlxZO1+lEtjKqW84mCsL6vxtJ
 Xo89EdpnbF4SnwM/ev7PMeIJzg7Or9PCRusN/VRtQ3Atai16K+dnNo4Coyb1cucXQIAhPJZmb
 YvNDZak7utenWSF+ifoDY7KAHw/UNvdVCcsOFwRYh9Pd0V7PN6HImgizXTcVO2C8Se86M0mtd
 GyqZf7GOqtoyOyznNWtN3K41G2vWCcNzFs72Eob1tFF0s=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 4 Jun 2024 21:55:08 +0200

Scope-based resource management became supported also for another
programming interface by contributions of Jonathan Cameron on 2024-02-17.
See also the commit 59ed5e2d505bf5f9b4af64d0021cd0c96aec1f7c ("device
property: Add cleanup.h based fwnode_handle_put() scope based cleanup.").

* Thus use the attribute =E2=80=9C__free(fwnode_handle)=E2=80=9D.

* Reduce the scope for the local variable =E2=80=9Cfwnode=E2=80=9D.

Fixes: 8a590d7371f0 ("extcon: add Realtek DHC RTD SoC Type-C driver")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/extcon/extcon-rtk-type-c.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-rtk-type-c.c b/drivers/extcon/extcon-rt=
k-type-c.c
index 19a01e663733..8a4b074fd745 100644
=2D-- a/drivers/extcon/extcon-rtk-type-c.c
+++ b/drivers/extcon/extcon-rtk-type-c.c
@@ -18,6 +18,7 @@
 #include <linux/syscalls.h>
 #include <linux/suspend.h>
 #include <linux/debugfs.h>
+#include <linux/property.h>
 #include <linux/extcon.h>
 #include <linux/extcon-provider.h>
 #include <linux/sys_soc.h>
@@ -1237,7 +1238,6 @@ static int extcon_rtk_type_c_init(struct type_c_data=
 *type_c)

 	if (!type_c->port) {
 		struct typec_capability typec_cap =3D { };
-		struct fwnode_handle *fwnode;
 		const char *buf;
 		int ret;

@@ -1246,7 +1246,8 @@ static int extcon_rtk_type_c_init(struct type_c_data=
 *type_c)
 		typec_cap.driver_data =3D type_c;
 		typec_cap.ops =3D &type_c_port_ops;

-		fwnode =3D device_get_named_child_node(dev, "connector");
+		struct fwnode_handle *fwnode __free(fwnode_handle)
+					     =3D device_get_named_child_node(dev, "connector");
 		if (!fwnode)
 			return -EINVAL;

=2D-
2.45.1