Received-SPF: pass (google.com: domain of linux-kernel+bounces-201340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240603223811.3815762-1-sboyd@kernel.org> <20240603223811.3815762-8-sboyd@kernel.org>
 <20240604130526.GA12945-robh@kernel.org> <cce5a85e48f35f5ad5464a2443ca972e.sboyd@kernel.org>
In-Reply-To: <cce5a85e48f35f5ad5464a2443ca972e.sboyd@kernel.org>
From: Rob Herring <robh@kernel.org>
Date: Tue, 4 Jun 2024 15:19:18 -0500
Message-ID: <CAL_Jsq+mGbW=4RbF+E1knvQco+5b1s7Tk8=2wyo9rT48Q=zkFQ@mail.gmail.com>
Subject: Re: [PATCH v5 07/11] dt-bindings: test: Add single clk consumer
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>, linux-kernel@vger.kernel.org, 
	linux-clk@vger.kernel.org, patches@lists.linux.dev, 
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, 
	devicetree@vger.kernel.org, Brendan Higgins <brendan.higgins@linux.dev>, 
	David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, 
	Saravana Kannan <saravanak@google.com>, Daniel Latypov <dlatypov@google.com>, 
	Christian Marangi <ansuelsmth@gmail.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Maxime Ripard <maxime@cerno.tech>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 4, 2024 at 1:28=E2=80=AFPM Stephen Boyd <sboyd@kernel.org> wrot=
e:
>
> Quoting Rob Herring (2024-06-04 06:05:26)
> > On Mon, Jun 03, 2024 at 03:38:04PM -0700, Stephen Boyd wrote:
> > > Describe a binding for a device that consumes a single clk in DT. Thi=
s
> > > will initially be used by a KUnit test to clk_get() the clk registere=
d
> > > by of_fixed_clk_setup() and test that it is setup properly.
> > >
> > > Cc: Rob Herring <robh@kernel.org>
> > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > > Cc: Conor Dooley <conor+dt@kernel.org>
> > > Cc: Brendan Higgins <brendan.higgins@linux.dev>
> > > Cc: David Gow <davidgow@google.com>
> > > Cc: Rae Moar <rmoar@google.com>
> > > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> > > ---
> > >  .../test/test,single-clk-consumer.yaml        | 34 +++++++++++++++++=
++
> > >  1 file changed, 34 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/test/test,singl=
e-clk-consumer.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/test/test,single-clk-c=
onsumer.yaml b/Documentation/devicetree/bindings/test/test,single-clk-consu=
mer.yaml
> > > new file mode 100644
> > > index 000000000000..8c384c48707d
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/test/test,single-clk-consumer=
.yaml
> > > @@ -0,0 +1,34 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/test/test,single-clk-consumer.yam=
l#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Test consumer of a single clock
> > > +
> > > +maintainers:
> > > +  - Stephen Boyd <sboyd@kernel.org>
> > > +
> > > +description:
> > > +  A consumer of a single clock used in tests.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: test,single-clk-consumer
> >
> > I don't know if there's much value in defining bindings for tests. We
> > could alternatively make 'test,' opt out of everything. There's already
> > some support in dtschema for this with 'foo,'.
> >
> > I need something for the DT unittest as well.
> >
>
> Ok. So I should drop this patch and the other one that adds a binding
> for the fake clock provider?

Yes.

> And replace it with something that makes
> the test vendor prefix opt out of all checking? How is that done?  Some
> patch to dtschema directly?

Yes, but I just added it for you.

Rob