Received-SPF: pass (google.com: domain of linux-kernel+bounces-201358-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844
Precedence: bulk
MIME-Version: 1.0
Message-Id: <fd2b865e-ddde-40ff-95a9-bc43bd48b549@app.fastmail.com>
In-Reply-To: <20240604201251.GA791043@ziepe.ca>
References: <20240528153717.2439910-1-arnd@kernel.org>
 <20240604155536.GA20674@willie-the-truck> <20240604201251.GA791043@ziepe.ca>
Date: Tue, 04 Jun 2024 22:44:06 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jason Gunthorpe" <jgg@ziepe.ca>, "Will Deacon" <will@kernel.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
 "Catalin Marinas" <catalin.marinas@arm.com>, "Baoquan He" <bhe@redhat.com>,
 "Kefeng Wang" <wangkefeng.wang@huawei.com>,
 "Peter Zijlstra" <peterz@infradead.org>,
 "Mark Rutland" <mark.rutland@arm.com>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] arm64/io: add constant-argument check
Content-Type: text/plain

On Tue, Jun 4, 2024, at 22:12, Jason Gunthorpe wrote:
> On Tue, Jun 04, 2024 at 04:55:37PM +0100, Will Deacon wrote:
>> On Tue, May 28, 2024 at 05:37:11PM +0200, Arnd Bergmann wrote:
>> 
>> I think this is superseded by Mark's diff in reply to v1, right?
>> 
>> https://lore.kernel.org/r/ZlcODqVXTDh6n0h-@J2N7QTR9R3
>>
>> If so, Mark, please can you post that as a proper patch so that we can
>> get this fixed?
>
> I wouldn't say superseded, but I agree with Mark that we should have
> the __always_inline added to the __iowrite64_copy() and
> __const_memcpy_toio_aligned64() in addition to the stuff here.
>
> When I originally wrote this I copied the fairly common pattern of
> having the builtin_constant_p test inside a macro, but I see now it is
> quite common to put that into an inline. Putting it in the inline is
> definately much better, so I like Arnd's patch.
>
> Arnd can you just make that addition and repost this?
>

Yes, sorry for failing to follow up earlier. I'm doing a little
more build testing now, will send soon.

   Arnd