Received-SPF: pass (google.com: domain of linux-kernel+bounces-201369-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 4 Jun 2024 13:55:34 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] linux/interrupt.h: allow "guard" notation to disable and
 reenable IRQ
Message-ID: <Zl9_RsKZNYPpmGJ4@google.com>
References: <ZljAV6HjkPSEhWSw@google.com>
 <87ed9c5yp1.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ed9c5yp1.ffs@tglx>

On Tue, Jun 04, 2024 at 08:51:06PM +0200, Thomas Gleixner wrote:
> On Thu, May 30 2024 at 11:07, Dmitry Torokhov wrote:
> > Drivers often need to first disable an interrupt, carry out some
> > action, and then reenable the interrupt. Introduce support for the
> > "guard" notation for this so that the following is possible:
> >
> > 	...
> >
> > 	scoped_cond_guard(mutex_intr, return -EINTR, &data->sysfs_mutex) {
> > 		guard(disable_irq)(&client->irq);
> >
> > 		error = elan_acquire_baseline(data);
> > 		if (error)
> > 			return error;
> > 	}
> >
> > 	...
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> I assume you want to carry this through the input tree, so you can
> modify the drivers.
> 
> If so:
> 
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Thanks Thomas. I'll stick this patch into an immutable branch off v6.9
in case you (or someone else) wants to pull it in and start using it.

Thanks.

-- 
Dmitry