Received-SPF: pass (google.com: domain of linux-kernel+bounces-201388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e066d250-b657-472f-ad27-585a64a51a9f@oracle.com>
Date: Tue, 4 Jun 2024 14:16:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 09/19] x86: Secure Launch kernel late boot stub
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-integrity@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        iommu@lists.linux-foundation.org
Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com,
        ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, jgg@ziepe.ca,
        luto@amacapital.net, nivedita@alum.mit.edu,
        herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
        ebiederm@xmission.com, dwmw2@infradead.org, baolu.lu@linux.intel.com,
        kanth.ghatraju@oracle.com, andrew.cooper3@citrix.com,
        trenchboot-devel@googlegroups.com, ross.philipson@oracle.com
References: <20240531010331.134441-1-ross.philipson@oracle.com>
 <20240531010331.134441-10-ross.philipson@oracle.com>
 <D1RHYMFSVGSW.39IL7KFK8A47N@kernel.org>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <D1RHYMFSVGSW.39IL7KFK8A47N@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MWRwTHhXdy9CaHh1M2hpK2JCSmdsRlo4dmVPYVQyY0orUDkvUFlTRVQzd1BK?=
 =?utf-8?B?cFQ3VGozaU04c1VwQU9nNG52bkJyUmg3eVB4OEdXZTZxVHd4N0NIQU94OW03?=
 =?utf-8?B?VzFtN0dzc01XUXBNL054NS91cGk4czVoSC82VXhGZ1NGaFNDZWxBeDY2WjA5?=
 =?utf-8?B?clUrOG5mZ0RRa3VSOVBPODVSNmZxQmRTMDNrK0JqcDJHdGNmQWdYU1NSeGJT?=
 =?utf-8?B?NFNRaGJjbVlDcDFiNkt3czNYazhNMHl0N1ZPSEc1WExkajdZWHVROHJTOU13?=
 =?utf-8?B?amQxTXZsbkRYdU4zdWJGb3VoemJIeGdiWjVXZWwyUzlUekFZSFVhWFAvQXBz?=
 =?utf-8?B?cEFnbko4V2VWT29PSWR1bE9KYXU1dDVQMnJZY3hwU1l2V1RBWFNQSE5JZUxl?=
 =?utf-8?B?aDA0aDVJbTRJUklmYmxwdHhNalV0U25OdXI1NVQwRVM5LzgyM21kYldIRnpH?=
 =?utf-8?B?OUk5SVBGQ0haWjhhYWdMVS9yNTU1YjlJSVVVOW04M0VIS2lJQWg1NGtGMjFB?=
 =?utf-8?B?V2Y5YUtNcFNCMEY0L2dEbGdIdDFkT0ZhZ1M4OExGSnZCdDNsMENYWk5kZG9j?=
 =?utf-8?B?Q3d3VGZQeklWODB0T3V1Y3lDV21KbnJMbmN5bkFhaUNMalM4MlZzb1NTeDAw?=
 =?utf-8?B?bUJkUmt0UXYveC9oT3dWQ1lEWk54ajhYV1E0OUQ4bk1veUs1amVNODhwTWxJ?=
 =?utf-8?B?NDgvWEhOODBtTWxkUmpMZllTOVB5bDJ0S1hab09CMFRaV3lwR1VhUTlJNFVV?=
 =?utf-8?B?ekNaNWw3Wk5Qa3czUFkyTFJ1WkFIUG1CZDNlYThyUDk5c2pyMkIzTlJ4b2Nt?=
 =?utf-8?B?aWdDUy9kT21rM0YzSDR5OUZ0ODUzemdDMTNWbXordDhaKy9GL0hyNkdpbUNq?=
 =?utf-8?B?L05OSkhkQzZGQUw5K2t4bExDTFpzS1Z5aEs1aEljZHdsTWIzRytMODdHb0Jr?=
 =?utf-8?B?SmQzTEZOczF5dWxTcnNCV2kwcytUNkg5aklCQkN4QkNBQTVpZ1ZQSklueHZU?=
 =?utf-8?B?S21NdHVVZElOcXpUVnZQWEFMY01QbGMyMXRpTnRxUHlUNURzMmxlMUhJYzE1?=
 =?utf-8?B?ekRMV0JpNEtGWFpYdTk4VHozV29UWStUM0RFWkxwbHFPSUFHdXpJTzZ0bmNs?=
 =?utf-8?B?QWJ3Z1BwUGp5WTljQVdoVjc2U0t2cDVUU1d4aFExckhIajc2NHE1R2NBOUxz?=
 =?utf-8?B?WklVSmNUbkUvakVzb2cxUzBYRUVOTWRPRExuMmQ3QTJsRHg2Qm04aTB5dEdV?=
 =?utf-8?B?aW9xYUhzazFHTVRlNkRRMktML29LcDNDS2hCZDk5SXJJUzFBbVNIdm4xbHJO?=
 =?utf-8?B?MEJlMnZtK0xPUld1VDRuMG9wSmJzbWs4UWZualNiTENCY1F1eWhoMUFEVzFr?=
 =?utf-8?B?VU9HcXoxL3JFQndyOXRnWVFpazk3cUxWNzBBdzJWVm1NanllQWZzT1g3SlJx?=
 =?utf-8?B?NHdJblpyWldDTDZ2MVNFNitJd1U1NmoyN1I1aUgwTFVCblpDbmJkVk8rRUt1?=
 =?utf-8?B?WG4wSWo3SS9FU1ZHeGRkeFV1NmNNVkdYT0VsT0FjQ3kzUzVJMnNsT2tnY2Yv?=
 =?utf-8?B?dkFLRCtLMC9NTWJ2QmYrWVM1dk1iU3ppTWkxWXUzMnp6dS85ajlLL1RiZklx?=
 =?utf-8?B?WWkyeitlbDhscllxdjNFdnlNT0tTa1R1bnpXN3Vxd3F2bHc5ZUM0ZHM3QnRi?=
 =?utf-8?B?VzlJSnV5ZUxvQlNMZlc4a0JTQTVLUnptTDFaekVIMHZmMG9rOUNzeWlKQSt2?=
 =?utf-8?B?MFJwQlpZSWpKQ21RWWprbld3R0xpOVVPdmhzTUFiYlpjaURsa0RSM1V4WmlN?=
 =?utf-8?B?aDF5UFBtY0FieW1ibzArcklvRmwzWDM0ZzVVb1c3MWo3LzF2eDJTNkJsa0s4?=
 =?utf-8?B?R2gxVHZjUTZWSm9FcUdtaFdvcXM4OFVHQjg1cnQ0UEovTnNGQVV2LzRyVjk4?=
 =?utf-8?B?SFhGOXJqSEdhdVgzck04QzdqbG5odkhzRVlRai9CVi9FNFlYL2tOS2NsQVJE?=
 =?utf-8?B?c2NXR0dQanF6ZFIyVFlDek9VUDVJN0hPMitiTktZaWFKQjgxckZaeVkvUWdt?=
 =?utf-8?B?RzlrYjdHTHliOEJFTkozNkExN1dRUjQxZ2RXNm5ZaGtOWCs1aHRpaTVpNjl3?=
 =?utf-8?B?QzJTbzA5S0V5MG16Kzh3ZHg4QWMzTENyamVKSlc4YnNvVUVNVzE1QVdJSDFn?=
 =?utf-8?B?SXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	CSynnrypXcWd9cOfD7OIYr1L7GLKIWP9kIbnJ+UaCCi1CMGiu1WiOl4IiOiNiHIAioqRQUSg/PghPdz23eui8kayThMpo2zUn5vezSW0blAbwiycyPB/I0jd1HWjk6k5nscOVXJcjxYhN28SLO84p9VjNy2F3x52I5a1NZNssp4eRi+cgNbTeZ6OQ88ooxDNlhYX3KcUrGTDTvxT3pzyQBTgiwWgdBCT+ut4fYHQouHo6q6Gw8UcJYIMrIomvtLmTmt0g6P9skNfQn/2+MltHbKFI3Tvf+f4qAo3KccdiTRhyHjpEgANmqgZo8KUCJvbCJFNCPbWxBTdJ/vqaagA6+lp5GOCP4KUR/s1pp5LLrP6EBcjYrMRKsgeTvsbthLNh9LEWsSpAgkBKBNbSHUtGSXGqywUGxHH5C79YpN/0I6YMdbqyzdJyRsXfsyuv0RSaOTgvTafT5LuHvlofz3/HWi+yVe8B35kAljrW5B209rTlxXUJx3CStqosy3avUU7aJEs037c0vXI/8pVlYXK7DzX/7Rqd9UgHQAa/ntlafgt3y/eOLWISJHbBIvJnB6Ssgh2Mpn45U1ruBvihpGWI2z+VSVQiOjIVlG+qTdTsIo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d27c4f2c-baa1-4536-6d92-08dc84db8f81
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 21:16:12.1466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qPn+oLwGTN8S9g578lSzBnKvfvzzlSZgx+m+nwWH23lgIc76PpE86t13oqJmIJtA9l6x5YAMGnT89fsWXq6Py4W9Zkj+mtq9f7byTSTsMSk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5109
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_11,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406040171
X-Proofpoint-GUID: gf0CHlnt_FT1pRAXg1lvODrSxE44Q3cY
X-Proofpoint-ORIG-GUID: gf0CHlnt_FT1pRAXg1lvODrSxE44Q3cY

On 6/4/24 12:58 PM, Jarkko Sakkinen wrote:
> On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote:
>> The routine slaunch_setup is called out of the x86 specific setup_arch()
>> routine during early kernel boot. After determining what platform is
>> present, various operations specific to that platform occur. This
>> includes finalizing setting for the platform late launch and verifying
>> that memory protections are in place.
> 
> "memory protections" is not too helpful tbh.
> 
> Better to describe very briefly the VT-d usage.

We can enhance the commit message and talk about VT-d usage and what 
PMRs are and do.

Thanks

> 
> BR, Jarkko