Received-SPF: pass (google.com: domain of linux-kernel+bounces-201389-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <74328ab7-c054-49ad-a40d-214fe6792adf@oracle.com>
Date: Tue, 4 Jun 2024 14:17:01 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 09/19] x86: Secure Launch kernel late boot stub
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-integrity@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org,
        kexec@lists.infradead.org, linux-efi@vger.kernel.org,
        iommu@lists.linux-foundation.org
Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com,
        ardb@kernel.org, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, jgg@ziepe.ca,
        luto@amacapital.net, nivedita@alum.mit.edu,
        herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
        ebiederm@xmission.com, dwmw2@infradead.org, baolu.lu@linux.intel.com,
        kanth.ghatraju@oracle.com, andrew.cooper3@citrix.com,
        trenchboot-devel@googlegroups.com, ross.philipson@oracle.com
References: <20240531010331.134441-1-ross.philipson@oracle.com>
 <20240531010331.134441-10-ross.philipson@oracle.com>
 <D1RHZDG3HJNK.ZWTFLXDBEXD1@kernel.org>
Content-Language: en-US
From: ross.philipson@oracle.com
In-Reply-To: <D1RHZDG3HJNK.ZWTFLXDBEXD1@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Z1hPTS9XZ2RmSWlHWFV5bUYxVzFYcFVaSEVsZndWSzh6YzJGNTZRZCtwYkhJ?=
 =?utf-8?B?Ky9Td1Vrd2ZyZmN6Ukg2dXVCVDFFNkl5UHZYZCtlbGliU1FlaEF2ckUydkU5?=
 =?utf-8?B?TkdGb1EvNDQxL3RGMG5IeG5lZFVMOGszYVVwM1QrWVF1RmV0aldLL2QydXdW?=
 =?utf-8?B?VkFta3BCR1g5RUs2Sjc4WGRNbFFVU1pNTmU3Lzg2YTc5N0tXK0FXcjBJODJQ?=
 =?utf-8?B?MHZhbjNIUVRxeUtaTFdnOUh0b2F4T0VuRFRLbDQ0S2hHaUhTQUhCcjZsYzlo?=
 =?utf-8?B?TTU4MFA0M0N1aUZWSFBrQkJTUUY2U1B1MC9UWW8wTURxbmtxZTRhUlAxUkp2?=
 =?utf-8?B?WlBieEhvUFc0Vmhud1JpV0lKcWQrRXMycDcxSGRyY0pRbkt0TXBoYkI0cElk?=
 =?utf-8?B?OUJFR0hrNWF0c2xvYzB4NlptaEpud2R6eTF6SmU2WHN3S2w4UmptKy9SRmQ2?=
 =?utf-8?B?SzV2WHlXeWdCQWJYamlmRFRGVWdHODVPMDVrREppTmNmUzQxZVE2cEpmUEdt?=
 =?utf-8?B?VE81YkFTSlFRcmRISVY0MHdmMTEzMHNEdmx6VmFHY3hQblFocUpOMWNLWkxJ?=
 =?utf-8?B?VFlwajFpYWY3Y0gzVmo4Yy9ReEwvRG1GSzM3azBnZzNUTEZDdjgrVUVVUi80?=
 =?utf-8?B?YkVaNGhMWWxhTjM5ZzFFM2FhcFFodlZ4UU5wb1l3bTJIZWphYjg2YmZKZmhZ?=
 =?utf-8?B?SmFwV2tjeHkvVmN1dkZyTFdZRk1LemdQS3I3QXAvM2dYS1cwYjZ4S0JOUkRF?=
 =?utf-8?B?U1NYbHVUVTR0NWdFaW5OOXNxOWVtWG1EV2I4Qzk0SnVsNDl1bzA5cEVZcVRE?=
 =?utf-8?B?QWYrN0xuNVhwdWx5UmtuTHRHL3lGanlTMWNsUk5IWU04MkZ6OHpCbmZOZTVY?=
 =?utf-8?B?OS9zT05zR2ZKUnpMK2xnTkdONktlZm5kY1E3aVhnL29qUTR2czBuWC93eWtY?=
 =?utf-8?B?cjRFdVp3cGlVVUtvZWFMS2NQVUpPWXpXMGtWUTNiTS9yYTluVUJBUVREaEZW?=
 =?utf-8?B?c3pDanF3VWtQcTI2SGtvSVNWWWlpaU9LMUZsbmpwYUNEcVFsVUJxVW1MOTdW?=
 =?utf-8?B?UU5PZDdxN1A0MWY5Q3Q3emRFM0ZMdm0vNldJdlNZUldtOUQ3YlhqZ1pCc04r?=
 =?utf-8?B?ZVFZeUdsSTk4N0pucGE4bWViY3c4NVIwZVR3RnI5T0FkdnZyNTgyQmVjTzlE?=
 =?utf-8?B?VGN3YUoyRUlMUmxpQWdWditqUi84NkNjQWxmVm9yZmVRdU9YZGJTcC8rT25F?=
 =?utf-8?B?M1FwMUdZQmsvRHMrbUpwNWo5UURpaElRYmhPS1JYMXNrd2l6VlBKWUt5Y25q?=
 =?utf-8?B?dHZja2d0OHdJMFN6dlFyOXloUVAvWnY4bUN3WFRmM2xzRlhBb2FBakxkeWEv?=
 =?utf-8?B?TXJTWFdNM3kzcjMveVVsL3BlWXA2REhsNWNCVUF5azVGaFZ3NC9aZ0NtVlJN?=
 =?utf-8?B?clZuSE82RzRCaG5DSzNUdDZOM0oySTRjZ01ualoybFMyWnA5U1BKbklJSy9w?=
 =?utf-8?B?Z0J6RSt1WTFiTVFXcXdLOVVpM1o1Y0VsWGdWUHBoSWtuL2dYd2ViM0FKK09s?=
 =?utf-8?B?cVZidmFXckFlcStRRDlqQy9maDI3alhQaFFwQ0R4Ulp5RmtqdEppVENYRmky?=
 =?utf-8?B?YjB3OXpNNzNIYnl2aDVHL2RmTVJDZTdNQW03OFBoaFVodnEzMFFoMHJaS2RY?=
 =?utf-8?B?ekdER0dkNnpQL2hvWXNMNmg0d1ZzVWpYai9rcWRDN1NGeTJ6QVdidk1ocGU2?=
 =?utf-8?B?TWg3T3hvUGkrUTdHRm5qTXQxa1kxdzRJbVQ2WEkvSVNkN29TOGEycWZUNkFT?=
 =?utf-8?B?UW1TYzlEYkdQK1pPWUdPSVVUdHEyU2ppNG03ZFdxbHA5Y0tDdHpCQnRMVEJs?=
 =?utf-8?B?b1RWMGdtVytTR3lZQUJodXBrZjY0WjRNOWJYU1drYlBrSGdINnN5akc2YXNF?=
 =?utf-8?B?WFN1ZmRYc1lvOWdyWU5maFRqdzJSZTlMRjZ5YTZ6bnZEVnFxZjhYeFZYNENl?=
 =?utf-8?B?L1lsS3B6ejZwSkpvWG5vZjFuWHlWU0VCcldQTS9DcGQvTUwvZk80V3dtWE51?=
 =?utf-8?B?dHJ3b0U5UjIyT0lOWTBjU1ViOTdWOHBjRXNtNm5xM3hFOUthNGRTbzRFWGVT?=
 =?utf-8?B?RFVBeXk5ZE1xSjJOQlFvSG1aM1JibG5Ub0ZuQ3JSbmdacHQxeDdhVUhOU3BV?=
 =?utf-8?B?TlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	HWbeJoCTPC9mia00vvLIJKIGMgK8YMfK4LbV/vWxIg3j64w5xWtljFmB1kLmL/ozHtmiiYxqpZFy/1tLcG6Ah8/t0krouTs3UsPuE4HABe1aRIcZ1xBZw3c9ikkAy7Wrdm4vlr6D5CduxfPEPTgq7j6zCMYr71gMQFmw0Y+RMnwriAIUZ6C9Y+E8dvd0dtbKhacbEX7/olgQkBHnO++ZtoASc1T/y8pMU+IIN1m6+Dql8lb7veTlt/YTNtlO4KGrbVWYFBf7sPNXV8NOlcDagUnGkpQWaEmCvUP4jD+iCTLS9JKIFnQWFMAG/eg8L/3/6afewX2twsAx0j7LexLaFi/S+zV5WUrHSRROxcE5ISi3fz3d3IgkXoVTVKEnDlRm34P35tfBYjzp0L75UMuaZcUyKeZyNd3qAxQsWnbMX8wKrnwQvJxmhdpB33jwB2I2lyswmhU62ly/6bdOCP9ncC/01Qcx82vi05ESXzLty8bwMM2A/Y4aTPgwC30hGwAe7N6s6cTpN5+akQTajDvkLlD5cUmfSPmNMdfNpA6ybkGYWLvmfQYpCErdtsA0OoXEw47si5xCtjFDawfv/u1TXtfqtKuWGfgbUT7t07gbArs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2400ddde-07e4-4b6d-47a5-08dc84dbaf09
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 21:17:05.0420
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BmqvrJE254+d8DMnVbunKzZ7vQlMg3LjlS6xz4JQgxttZX8x6M9s5q1VJN5G+RPKER70K6bIKnmKtJu5Z/DiIDMgB+iuCxyKiw9ikeeps3g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5109
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_11,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406040171
X-Proofpoint-ORIG-GUID: J8s9dANaYHo0xk1A6BICnQpVQoEqIfH4
X-Proofpoint-GUID: J8s9dANaYHo0xk1A6BICnQpVQoEqIfH4

On 6/4/24 12:59 PM, Jarkko Sakkinen wrote:
> On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote:
>> The routine slaunch_setup is called out of the x86 specific setup_arch()
>> routine during early kernel boot. After determining what platform is
>> present, various operations specific to that platform occur. This
>> includes finalizing setting for the platform late launch and verifying
>> that memory protections are in place.
>>
>> For TXT, this code also reserves the original compressed kernel setup
>> area where the APs were left looping so that this memory cannot be used.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
>> ---
>>   arch/x86/kernel/Makefile   |   1 +
>>   arch/x86/kernel/setup.c    |   3 +
>>   arch/x86/kernel/slaunch.c  | 525 +++++++++++++++++++++++++++++++++++++
>>   drivers/iommu/intel/dmar.c |   4 +
>>   4 files changed, 533 insertions(+)
>>   create mode 100644 arch/x86/kernel/slaunch.c
>>
>> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
>> index 5d128167e2e2..b35ca99ab0a0 100644
>> --- a/arch/x86/kernel/Makefile
>> +++ b/arch/x86/kernel/Makefile
>> @@ -76,6 +76,7 @@ obj-$(CONFIG_X86_32)		+= tls.o
>>   obj-$(CONFIG_IA32_EMULATION)	+= tls.o
>>   obj-y				+= step.o
>>   obj-$(CONFIG_INTEL_TXT)		+= tboot.o
>> +obj-$(CONFIG_SECURE_LAUNCH)	+= slaunch.o
> 
> Hmm... should that be CONFIG_X86_SECURE_LAUNCH?
> 
> Just asking...

It could be if you would like. I guess we just thought it was implied 
given its location.

Ross

> 
> BR, Jarkko
>