Received: by 2002:a05:6500:1b41:b0:1fb:d597:ff75 with SMTP id cz1csp382614lqb; Tue, 4 Jun 2024 14:29:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXXaRT0BwjDF/Hyu5HiAgnavGCUs+TkMZQfHCdpOFn87qwzloTFMSTPp52b7x8VVE0aYYjDr8INVrpQwwuC2fGUY2Tj1FCcpYUQWqy8NQ== X-Google-Smtp-Source: AGHT+IEIepzknL9yT/YgAWvQ88mhiBtPv4lQMK68+f8fNW3pJXqKgmo47cZquTDJ9CGKG1fa0Uk0 X-Received: by 2002:a05:6512:4019:b0:52b:8455:fb1f with SMTP id 2adb3069b0e04-52bab4ce6b5mr591164e87.10.1717536546201; Tue, 04 Jun 2024 14:29:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717536546; cv=pass; d=google.com; s=arc-20160816; b=RWVToqIQuAin2kHcUmmAGV+8RQ1kK6rHL7ypH7RGCjY/z1GJr8NNCnhKIKpsFk8RtA uf0nFqL/sx2UhW32mBUqRCN4YpUBcD8+ftSR451OMoRTaP1GbmllavDINM+nIyaCk3gM +1rml8J2Nfrl4A8U8hAWRXVz1oa8QOc0APza67IaTWqqEVkOr/sQmT8C77YM666dOmTH Q28UFEfbAicO/6oJmRBpDnRBEoN1pG8WUundK2N84HX16TOPMz5vASVhNz788ftCZ2yX 23A0/9zM2em/DbK79R7F4fdbp+/3RfzvLHoRpY0YI9bBnD09IS81maiZBFAhQRP/yP82 58Mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:subject:cc:to :from:date:user-agent:message-id; bh=tnrstzPrPnmylYc4/koYKK5o6BVghzFxOWTlG/T9SUI=; fh=mjDKelfe6UwtrbrQsWTm6mHxXqJJm1yC7XMGoQRRIY8=; b=jKa8PxTS6H6IGuPvQ1W7Z0+b3ZmiaIvHStFyp69ddPC5Fa10Rf0TRxvAJJ+ae0+imp TA6ayuW6iFWUYUnxhYHq2oLsGoviDvEJotFPzmKjGASwe5C77A5nd2RxyebAun2zj5Er u/DkQQnxmk4txVtJo+B4877C0DT9eEnBX0SBiEm6X22OA3u/Ikbfqofx/xsnUemXGPSO 6UiyMr6whyFnPdRfKA9362VM0GRt5ElYvNWrc1icsnNmxzYKumbNBMRQ1YLGqNKRP39V +bXagHh2/A40Cw1yHzrBxBzeNZNYWMzMDukmBMqm/tKv8MnBO3IBar8rSjzGM0v3IeOS apmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-201398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201398-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31cc7082si5469148a12.618.2024.06.04.14.29.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 14:29:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-201398-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201398-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E3ABE1F21633 for ; Tue, 4 Jun 2024 21:29:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A0E2014C5A6; Tue, 4 Jun 2024 21:28:54 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267A2143751; Tue, 4 Jun 2024 21:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717536534; cv=none; b=SuVQq2o5ucM3Dc636Buykdju1JkBFlWxXGAYhTnYhFH1ch5a8LMSdKz6eN+ClEiXksqW96G9EaFf6XsE1/quy7DZu5ha/rddHjgTG8Qa5xxQPTjC0Kbfe1RN/eMg4GhQ89nGqcpQ++N6iRG++W3yaL8Oh1qlqJtWRJ3kYtSMWVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717536534; c=relaxed/simple; bh=xCn7OmgsUX4Rqky5+7K3tAsdls0KrNgqlPwatU7slSQ=; h=Message-ID:Date:From:To:Cc:Subject; b=mJ0nuZFT5WTIwJVUmIrxhaSUl2GmZfIAAp/vmCaZVPqdorsC0ITdgmUxEQED1uP54lpeLvNtFK5byfH11tK1ZkSauHYO7n8UTSYRuXqf84DrdpWyxuDlDSUf6QNFuzRbgXzSFBDNa+JFUnqpiyQ4dTZyA8yPbPXJPEfBpXJAqgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05D04C3277B; Tue, 4 Jun 2024 21:28:54 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1sEbiA-00000000bCq-2Eth; Tue, 04 Jun 2024 17:28:54 -0400 Message-ID: <20240604212817.384103202@goodmis.org> User-Agent: quilt/0.68 Date: Tue, 04 Jun 2024 17:28:17 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton Subject: [PATCH 0/5] ftrace: Clean up and comment code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: While working on the function_graph multiple users code, I realized that I was struggling with how the ftrace code worked. Being the author of such code meant that it wasn't very intuitive. Namely, the function names were not descriptive enough, or at least, they needed comments. This series moves to solve some of that via changing a couple function names and parameters and adding comments to many of them. There's more to do, but this at least moves it in the right direction. Steven Rostedt (Google) (5): ftrace: Rename dup_hash() and comment it ftrace: Comment __ftrace_hash_rec_update() and make filter_hash bool ftrace: Remove "filter_hash" parameter from ftrace_hash_rec_disable/enable() ftrace: Convert "filter_hash" and "inc" to bool in ftrace_hash_rec_update_modify() ftrace: Add comments to ftrace_hash_move() and friends ---- kernel/trace/ftrace.c | 103 +++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 86 insertions(+), 17 deletions(-)