Received-SPF: pass (google.com: domain of linux-kernel+bounces-201409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 5 Jun 2024 06:25:20 +0900
From: Minwoo Im <minwoo.im@samsung.com>
To: "James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>, Bart Van Assche
	<bvanassche@acm.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman
	<avri.altman@wdc.com>, gost.dev@samsung.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jeuk Kim <jeuk20.kim@samsung.com>, Minwoo Im
	<minwoo.im@samsung.com>
Subject: Re: [PATCH v2 0/2] ufs: pci: Add support UFSHCI 4.0 MCQ
Message-ID: <Zl+GQGK9d3AvrEEz@localhost>
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240531212244.1593535-1-minwoo.im@samsung.com>
Content-Type: multipart/mixed;
	boundary="----CGP_Yo4KSd1.GMH1id3MjqccfDy5Ep7f4Yd1jhLawOabyReQ=_4cbea_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20240531213424epcas2p16d7360e12d310c9f299d449e66af07b3@epcas2p1.samsung.com>
	<20240531212244.1593535-1-minwoo.im@samsung.com>

------CGP_Yo4KSd1.GMH1id3MjqccfDy5Ep7f4Yd1jhLawOabyReQ=_4cbea_
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline

On 24-06-01 06:22:42, Minwoo Im wrote:
> This patchset introduces add support for MCQ introduced in UFSHCI 4.0.  The
> first patch adds a simple helper to get the address of MCQ queue config
> registers.  The second one enables MCQ feature by adding mandatory vops
> callback functions required at MCQ initialization phase.  The last one is to
> prevent a case where number of MCQ is given 1 since driver allocates poll_queues
> first rather than I/O queues to handle device commands.  Instead of causing
> exception handlers due to no I/O queue, failfast during the initialization time.
> 
> ---
> v2:
>   - https://lore.kernel.org/linux-scsi/20240531103821.1583934-1-minwoo.im@samsung.com/T/#t

Now the MCQ feature of hw/ufs has been pulled to QEMU [1]. You can test this
patchset with [1].

[1] https://github.com/qemu/qemu/commit/5c079578d2e46df626d13eeb629c7d761a5c4e44

>   - Not separate the newly introduced function from the actuall caller in the
>     other patch by squash the second patch to the first one (Bart).
>   - Rename ufs_redhat_* in ufshcd-pci.c to ufs_qemu_* to represent that it's
>     for QEMU UFS PCI device (Bart).
> 
> Minwoo Im (2):
>   ufs: pci: Add support MCQ for QEMU-based UFS
>   ufs: mcq: Prevent no I/O queue case for MCQ
> 
>  drivers/ufs/core/ufs-mcq.c    | 23 +++++++++++++++++
>  drivers/ufs/host/ufshcd-pci.c | 48 ++++++++++++++++++++++++++++++++++-
>  include/ufs/ufshcd.h          |  1 +
>  3 files changed, 71 insertions(+), 1 deletion(-)
> 
> -- 
> 2.34.1
> 

------CGP_Yo4KSd1.GMH1id3MjqccfDy5Ep7f4Yd1jhLawOabyReQ=_4cbea_
Content-Type: text/plain; charset="utf-8"


------CGP_Yo4KSd1.GMH1id3MjqccfDy5Ep7f4Yd1jhLawOabyReQ=_4cbea_--