Received-SPF: pass (google.com: domain of linux-kernel+bounces-201383-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 5 Jun 2024 00:11:34 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Stanley Chang <stanley_chang@realtek.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: realtek: Use scope-based resource management in
 extcon_rtk_type_c_init()
Message-ID: <Zl-DBkt8sNb9xypq@smile.fi.intel.com>
References: <532aa50e-b8e5-4e8e-a2bd-a05fd81274dc@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <532aa50e-b8e5-4e8e-a2bd-a05fd81274dc@web.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Jun 04, 2024 at 10:06:14PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 4 Jun 2024 21:55:08 +0200
> 
> Scope-based resource management became supported also for another
> programming interface by contributions of Jonathan Cameron on 2024-02-17.
> See also the commit 59ed5e2d505bf5f9b4af64d0021cd0c96aec1f7c ("device
> property: Add cleanup.h based fwnode_handle_put() scope based cleanup.").
> 
> * Thus use the attribute “__free(fwnode_handle)”.
> 
> * Reduce the scope for the local variable “fwnode”.

> Fixes: 8a590d7371f0 ("extcon: add Realtek DHC RTD SoC Type-C driver")

The problem here is that the above mentioned API only recently appeared in the
kernel. It will be impossible to backport without backporting a new API, which
is usually contradicts the idea of stable kernels. That's why it's better to
really fix without using a new APIs and then convert to a new one. Hence needs
two patches.

-- 
With Best Regards,
Andy Shevchenko