Received-SPF: pass (google.com: domain of linux-kernel+bounces-201418-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 5 Jun 2024 00:45:58 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chia-I Wu <olvaffe@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Baoquan He <bhe@redhat.com>,
	Alison Schofield <alison.schofield@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] resource: add a basic test for walk_iomem_res_desc
Message-ID: <Zl-LFtGP3z4rR-7S@smile.fi.intel.com>
References: <20240604213200.672279-1-olvaffe@gmail.com>
 <Zl-JUkLoxqraKciw@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zl-JUkLoxqraKciw@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Jun 05, 2024 at 12:38:27AM +0300, Andy Shevchenko wrote:
> On Tue, Jun 04, 2024 at 02:31:46PM -0700, Chia-I Wu wrote:

...

> > +	res[2] = (struct resource){
> > +		.start = offset,
> > +		.end = offset + SZ_1K - 1,
> > +		.name = "NESTED",
> > +	};
> 
> We have respective macros. Use them.

And use explicitly hardocded start in all of them instead of coding += for
offset variable. For the test cases is better when data is hardcoded, esp.
when it's an expected result (just to mention, here it seems an input data).

-- 
With Best Regards,
Andy Shevchenko