Received-SPF: pass (google.com: domain of linux-kernel+bounces-201543-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <87d6a52f-27e5-4b88-8a8c-c4c58d969a18@gmail.com>
Date: Tue, 4 Jun 2024 20:23:42 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ftrace: adding the missing parameter descriptions of
 unregister_ftrace_direct
To: Steven Rostedt <rostedt@goodmis.org>,
 Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
 Javier Carrasco <javier.carrasco.cruz@gmail.com>,
 linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
References: <20240528005046.3778431-1-marilene.agarcia@gmail.com>
Content-Language: en-US
From: Marilene Andrade Garcia <marilene.agarcia@gmail.com>
In-Reply-To: <20240528005046.3778431-1-marilene.agarcia@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 27/05/2024 21:50, MarileneGarcia wrote:
> Adding the description of the parameters addr and free_filters
> of the function unregister_ftrace_direct.
> 
> Signed-off-by: MarileneGarcia <marilene.agarcia@gmail.com>
> ---
> Hello,
> These changes fix the following compiler warnings of the function
> unregister_ftrace_direct.
> 
> The warnings happen using GCC compiler, enabling the ftrace related
> configs and using the command 'make W=1'.
> 
> kernel/trace/ftrace.c:5489: warning: Function parameter or struct member
> 'addr' not described in 'unregister_ftrace_direct'
> 
> kernel/trace/ftrace.c:5489: warning: Function parameter or struct member
> 'free_filters' not described in 'unregister_ftrace_direct'
> 
>   kernel/trace/ftrace.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 65208d3b5ed9..6062e4ce1957 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5475,6 +5475,8 @@ EXPORT_SYMBOL_GPL(register_ftrace_direct);
>    * unregister_ftrace_direct - Remove calls to custom trampoline
>    * previously registered by register_ftrace_direct for @ops object.
>    * @ops: The address of the struct ftrace_ops object
> + * @addr: The address of the trampoline to call at @ops functions
> + * @free_filters: non zero to remove all filters for the ftrace_ops
>    *
>    * This is used to remove a direct calls to @addr from the nop locations
>    * of the functions registered in @ops (with by ftrace_set_filter_ip

Hello everyone,
Do you have any feedback to me about the patch?

Thank you,
Marilene