Received-SPF: pass (google.com: domain of linux-kernel+bounces-201546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue,  4 Jun 2024 16:29:19 -0700
In-Reply-To: <20240510092353.2261824-1-leitao@debian.org>
Precedence: bulk
Mime-Version: 1.0
References: <20240510092353.2261824-1-leitao@debian.org>
Message-ID: <171754269008.2777502.9202264224544350112.b4-ty@google.com>
Subject: Re: [PATCH v2] KVM: Fix a data race on last_boosted_vcpu in kvm_vcpu_on_spin()
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>, 
	Rik van Riel <riel@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, 
	Breno Leitao <leitao@debian.org>
Cc: rbc@meta.com, paulmck@kernel.org, stable@vger.kernel.org, 
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="utf-8"

On Fri, 10 May 2024 02:23:52 -0700, Breno Leitao wrote:
> Use {READ,WRITE}_ONCE() to access kvm->last_boosted_vcpu to ensure the
> loads and stores are atomic.  In the extremely unlikely scenario the
> compiler tears the stores, it's theoretically possible for KVM to attempt
> to get a vCPU using an out-of-bounds index, e.g. if the write is split
> into multiple 8-bit stores, and is paired with a 32-bit load on a VM with
> 257 vCPUs:
> 
> [...]

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: Fix a data race on last_boosted_vcpu in kvm_vcpu_on_spin()
      https://github.com/kvm-x86/linux/commit/2b0844082557

--
https://github.com/kvm-x86/linux/tree/next