Received-SPF: pass (google.com: domain of linux-kernel+bounces-201713-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 4 Jun 2024 22:04:49 -0500
From: Colin Foster <colin.foster@in-advantage.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: omap2-mcspi multi mode
Message-ID: <Zl/V0dU6SjAMkpLG@colin-ia-desktop>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pp3805vJxllX3SyQnshFDrC4ytRPcaeNTVcrl2A9LluOm0Z5snZ7ZpDsXuot?=
 =?us-ascii?Q?fIHWuv/YrURkGWJItYDhAta9Zk4UViCd2R3K4boruFbA3LOnGjPECt5USAuY?=
 =?us-ascii?Q?zkATe/Ov4zPvRp3xnlzEai4NkSikWWgSMHaWutageFl0YgQrraseHmDCUgUF?=
 =?us-ascii?Q?/L+y/AkqD8+s+Lyadv4zM9P5ubTPpmaMM41JaeE1qpFuQylGKtWeoXjFQqsQ?=
 =?us-ascii?Q?vdcOPmu9u92/jNyayIFrpr43zKpWQb88MEfCvgkFTu/7tNmghlF3uf/OkN1X?=
 =?us-ascii?Q?/couGcUyGzsTrW7FsEqWIinISTJJIea2m33Ve50rqYgxWRld4X1SorPFKFDl?=
 =?us-ascii?Q?aghxY7+1qn7Iu00K0fyvTr6XK0/Sy4GpAO1H8VXDfw8rjMsqe09n6hyhPi9r?=
 =?us-ascii?Q?qRbj4oUNKq+iCzvR5+hznTs6/axaKu+LkCUkvxTe0HgjPAHaJBjBq4ECiULN?=
 =?us-ascii?Q?3r+kSO9k6x+ePuXo9im+W7KJXwCsJhgcZDpgc5aR6adgRoVCxCGFN/39nBlK?=
 =?us-ascii?Q?ULBQbEwqiuTBktMMbPHhJt4lqsvz30zQyRSbtKS8TDLa/4l9b92YuYlsfSdv?=
 =?us-ascii?Q?M/xdOGTiKPzF2N4MJJBFRY/I3rlMwYoTrpEy0DnnHjpwnmXizkqQZbCFrMUh?=
 =?us-ascii?Q?IoMUW9mvcUzLxCIAt8TkTXznbuXgwQokLyyfpPGGYir4iUhJZHYLU8ub74KI?=
 =?us-ascii?Q?htlT0nYyHG49ATeG7fsgulbLJ7b+1M3dycTtvix33KekifFygcfV4NDxSQwt?=
 =?us-ascii?Q?1cZ10rnzl1yP8LlZsS3zGZBxLocJqUZ9ovstsN9V5WiKpgal3hiNGeKLf0nn?=
 =?us-ascii?Q?ziZ2rjQVMuPoqe5pZEmR7E6UCLOJM3FlSBo3N37dcO7KVPywvJDNP5puGOOw?=
 =?us-ascii?Q?JTKwJ3oA1Y5vtNrtvq71cIyzsoSokdeTwLJF3y7CSm3pR3y+G+AkHKY2wuIB?=
 =?us-ascii?Q?O9LYujZ9JUP27ToYZS2iq8BU0uXK9GHbEWDlw2bPoFWkzxWKBQ9k2zLd97eu?=
 =?us-ascii?Q?HGbeUjtiHlaFwVDIBX+giHS2MWAXUJJI4InPI13zYN1c6weerHPw81glZdK8?=
 =?us-ascii?Q?elRTIv9U4bRgDE7GACChKlRppJW+jrbJUpvMCTlsW5G7OMoSYCx6zdAtFmxB?=
 =?us-ascii?Q?pLOx5gbMx0p4fDQCU0umywEhGTvsuSm0aDdaKGQkBXDCe/3HgE0KtlLbXGJ+?=
 =?us-ascii?Q?G+HF7HEPUmv/FBZWA38VyZogueZaJwPLatSh0ujIqWi3q/G4w7anCbAfTZV5?=
 =?us-ascii?Q?qLwBwUkkvhBr792a1Dypr8N2ECr9sIDAqWE4THCBJmBF+LNdVXuZHOlCL/Hi?=
 =?us-ascii?Q?P0hqSinVL/6srqXmxGgjXtbgR3D5M5rTQZ+VC+/Wt1536qWGSIwYq9AjJRwD?=
 =?us-ascii?Q?0j7JHPXUGJDusPHN3iezuyNy82Q+K1AkN+nuAkBrnappBW6/nn1NneRSTKd4?=
 =?us-ascii?Q?Qp7rVECeVkcRl/8ujb+5Q50nOP0Qfni8NDJ6gZ/bbZ3/PN0B20hMPj38VEVq?=
 =?us-ascii?Q?UUJWI3gXECQo35zbZvLMZ4Qlr2zmk/r3cNmjRa70DimBSVEnW235mNURSVer?=
 =?us-ascii?Q?opsmYy4nSmLzAmdWOo7ndCz1R6ZBP80o65YI4Mh8jHSBG7aWY90Ue//RDTge?=
 =?us-ascii?Q?1DD/DRAlJOY2M4MCTH03dW4=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c97e5aa8-a78d-4eae-632f-08dc850c44f0
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6974.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 03:04:52.4189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jBkzlmlQwrXXPsbEirTwqWtTyjEJyvYi817wovAR2Cs4riCzw40888ztHd+9oY684wBHIitAODD3xOALV3uECDEUhHu6sMyn352QT5bBiRs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4315

Hi Louis,

I found that commit e64d3b6fc9a3 ("spi: omap2-mcpsi: Enable MULTI-mode
in more situations") caused a regression in the ocelot_mfd driver. It
essentially causes the boot to hang during probe of the SPI device.

The following patch restores functionality. I can hook up a logic
analyzer tomorrow to get some more info, but I wanted to see if you had
any ideas.

--- a/drivers/mfd/ocelot-spi.c
+++ b/drivers/mfd/ocelot-spi.c
@@ -225,6 +228,8 @@ static int ocelot_spi_probe(struct spi_device *spi)
        }

        spi->bits_per_word = 8;
+       spi->word_delay.value = 1;
+       spi->word_delay.unit = SPI_DELAY_UNIT_NSECS;

        err = spi_setup(spi);
        if (err)


Colin Foster