Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp43886lqr; Tue, 4 Jun 2024 20:25:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU/F4lqs6TZC+2YcB6vXhf80bNFHU5DNIIyYfYyKV8I5qPqy2MMSGC5hHsLuWbWdJIGGFWNxpmEjG03P8aAGDh0H+zzhRyuhK4j7WQuZA== X-Google-Smtp-Source: AGHT+IFyZ9z5I2ZO7/eT8I7IavDvfl5NZQkGwcT4m8CRR6GJ9BCblbYhPDeBU6VhYagipYb/YHRz X-Received: by 2002:a05:6358:6f04:b0:192:b048:293f with SMTP id e5c5f4694b2df-19c6c685cb6mr166190955d.5.1717557952393; Tue, 04 Jun 2024 20:25:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717557952; cv=pass; d=google.com; s=arc-20160816; b=Fok1CogoGDgmv8Ur3UpO7x3LIdu7z4PHs3LG47GdMlbHi2akAtSKCGVSEWPso39OPU IhmgSpOejZF2CVQSiScRoUJPK4AT8+b+bUoeDCM/QoSMpQXf2kDuJvWqb6Stk7zyKWql w9fN34nXkQ+6XWGbM8QVnQv7BB6LCg/ndk8EioRmOFxADnmO7Zdny4h8L1AFjNcUoJ/O /Hd4itcvCHcASf+m0E5c35j3MPTFeaZMn5Ry8lqULkjtr34eut+Bn1qAOSLPzZIVT4Nr 1JKD/W9WaHIuGUVb9cbdOG8EqpSGwKpKz/dgZQCddaL1imR3Dp6BD1ZzBYyy2MjKES7Q 3mmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=LqhAN6sQk4HBabeE+lzI83mnQJ6I3DYfK5MX1xRWXmo=; fh=tmG6wILP6X4IQKOfsyCZ+qGmA7i3vz25YkDSmA+Iwpk=; b=OkQeqsNnVfDKCtgtiHCAEbLS2TFv+jx6zcb4DMejKxZ+7erED3uUWg+MWHsUxjL/bU 5q29o3XQwRJOlVnyv+6y80MRlwZa5iXzqOfLkxaa6Ut9CK2jwqaY7bKKrjCtofzF+9Zu h1ywgFdh7HyIbTXR453eL5lyG6vDuosyl+GNptwomX6IL86eDDBd/ba3zDV7g1H9MZ2y zT1/Qe5YHQ81zv4S74z4dSVYS+gtM68+kignnl2EWv2nj1L/xlWrRa5XumXwNKVEdPIL LiHDXI0wlSPcx0jxjUsI9FKOi+4WIYjcSyKqiy6/t1qqZgG6wjR5pqKgfUNkK6EoX+Qt F52g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Qqk+zrTb; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-201719-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201719-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c359e09c7fsi8056145a12.276.2024.06.04.20.25.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 20:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201719-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Qqk+zrTb; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-201719-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201719-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E3EB0B22487 for ; Wed, 5 Jun 2024 03:25:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E550073461; Wed, 5 Jun 2024 03:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Qqk+zrTb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0642056470; Wed, 5 Jun 2024 03:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717557933; cv=none; b=X1X2IcEU3VW7Pjlh9IBNFQlGqAK6TJiQopRT7qDazw9v+unG0ttM26RJNgdaUOv6cdtah7ZQtihiYHy2kngAF5nvGyrhaIPYwp0tl+bCJpn33aitg+YQ6kpz/EUW8oTFYVs//DTMRjDXmoW5JftbsL3+UGpmwzqspCeR0WUoQ1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717557933; c=relaxed/simple; bh=kSrIVEn5+ULziH4lIqSRZBF9y1SbsW1rFOIKZRGUYMY=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Pa+/GZZ0invzHaUlBADMPdIUoh+riZ7zELqbwbDNlIZ+phRBN5mww8Ub8PfhvQ7JyWg0Yi34M/3TAY4K+W5olmbCZa8tUNzmuEgHVw623302gWojHm0+fODTD0jfdOb5ReuvhmXxwnRHalWUwHA3GwHDPlx38ThGEXVuydiwpCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Qqk+zrTb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FB8BC32781; Wed, 5 Jun 2024 03:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1717557932; bh=kSrIVEn5+ULziH4lIqSRZBF9y1SbsW1rFOIKZRGUYMY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qqk+zrTb3qN0u7nr+Ltb8BGII6GpqS9r3xPSvfVItICcFbPgKyQdNoxG25i7GOTg8 aS+pj1Ao1N1lbuNg24jqF+JAEi/vN4E+gsPVlAUMF6t2DjeVFQ1oY1v/nxzdpxSBJu W8lxcEcDUrdIu5pH0BiEVOB4oHcVD/m3+rkLB2v4= Date: Tue, 4 Jun 2024 20:25:31 -0700 From: Andrew Morton To: Alexey Dobriyan Cc: Amer Al Shanawany , Shuah Khan , Swarup Laxman Kotiaklapudi , Hugh Dickins , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Javier Carrasco , kernel test robot Subject: Re: [PATCH] selftests: proc: remove unreached code and fix build warning Message-Id: <20240604202531.5d559ec4daed484a7a23592c@linux-foundation.org> In-Reply-To: <14f55053-2ff8-4086-8aac-b8ee2d50a427@p183> References: <202404010211.ygidvMwa-lkp@intel.com> <20240603124220.33778-1-amer.shanawany@gmail.com> <14f55053-2ff8-4086-8aac-b8ee2d50a427@p183> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Mon, 3 Jun 2024 17:24:47 +0300 Alexey Dobriyan wrote: > On Mon, Jun 03, 2024 at 02:42:20PM +0200, Amer Al Shanawany wrote: > > fix the following warning: > > proc-empty-vm.c:385:17: warning: ignoring return value of ‘write’ > > > --- a/tools/testing/selftests/proc/proc-empty-vm.c > > +++ b/tools/testing/selftests/proc/proc-empty-vm.c > > @@ -381,9 +381,6 @@ static int test_proc_pid_statm(pid_t pid) > > > - if (0) { > > - write(1, buf, rv); > > - } > > no thanks Why not? Why does that code exist anyway? It at least needs a comment.