Received-SPF: pass (google.com: domain of linux-kernel+bounces-201719-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 4 Jun 2024 20:25:31 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Amer Al Shanawany <amer.shanawany@gmail.com>, Shuah Khan
 <shuah@kernel.org>, Swarup Laxman Kotiaklapudi
 <swarupkotikalapudi@gmail.com>, Hugh Dickins <hughd@google.com>,
 linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, Javier Carrasco
 <javier.carrasco.cruz@gmail.com>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] selftests: proc: remove unreached code and fix build
 warning
Message-Id: <20240604202531.5d559ec4daed484a7a23592c@linux-foundation.org>
In-Reply-To: <14f55053-2ff8-4086-8aac-b8ee2d50a427@p183>
References: <202404010211.ygidvMwa-lkp@intel.com>
	<20240603124220.33778-1-amer.shanawany@gmail.com>
	<14f55053-2ff8-4086-8aac-b8ee2d50a427@p183>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On Mon, 3 Jun 2024 17:24:47 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Mon, Jun 03, 2024 at 02:42:20PM +0200, Amer Al Shanawany wrote:
> > fix the following warning:
> > proc-empty-vm.c:385:17: warning: ignoring return value of ‘write’
> 
> > --- a/tools/testing/selftests/proc/proc-empty-vm.c
> > +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> > @@ -381,9 +381,6 @@ static int test_proc_pid_statm(pid_t pid)
> 
> > -	if (0) {
> > -		write(1, buf, rv);
> > -	}
> 
> no thanks

Why not?

Why does that code exist anyway?  It at least needs a comment.