Received-SPF: pass (google.com: domain of linux-kernel+bounces-201740-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6a5afc74-ecc4-4818-b425-47d843e25735@intel.com>
Date: Wed, 5 Jun 2024 06:05:07 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] net: ethtool: fix the error condition in
 ethtool_get_phy_stats_ethtool()
To: Su Hui <suhui@nfschina.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <nathan@kernel.org>,
	<ndesaulniers@google.com>, <morbo@google.com>, <justinstitt@google.com>
CC: <andrew@lunn.ch>, <ahmed.zaki@intel.com>, <hkallweit1@gmail.com>,
	<justin.chen@broadcom.com>, <jdamato@fastly.com>,
	<gerhard@engleder-embedded.com>, <d-tatianin@yandex-team.ru>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<llvm@lists.linux.dev>, <kernel-janitors@vger.kernel.org>
References: <20240605034742.921751-1-suhui@nfschina.com>
Content-Language: en-US
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240605034742.921751-1-suhui@nfschina.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnVSL1FUZk5uR014NXdKeGE1V3F6ZWprcVVia25ld09QbE9LV3Erbm1pTjlR?=
 =?utf-8?B?a2ZUVk5SSUZ4T25DS3BLNVRWVDR2QmtrWWk4T0tNYWhBenpZWEF2MzlRN0l4?=
 =?utf-8?B?ZUtXc2V5VVcvZVFyTTlWWFFqUEI2UEFOWXNMeHVPRVlVdzFlaEp5ZFZ6OFZh?=
 =?utf-8?B?ZzNyR1FTNnI1V0RvVGZaaGxoQ2VsSmRkTjFzOFJTcWozbW15WFozWTNoZENj?=
 =?utf-8?B?WWVFaEhEb1Y5UGtFZ3d4eGh6aldQamNrTmFXNFlxeGw0dVRibHVUYitFdlhS?=
 =?utf-8?B?V2YxaWNMZXVNNlBRajFtR2VtUWErOHhpaVBaRnBuVjVWckdSZjlDcE5NcG82?=
 =?utf-8?B?WFRQaDdJWDJKYURvR0lOTmdqU3k0N2cvWjVvVWZZdytXQXJWRVhnWGZnQ0FZ?=
 =?utf-8?B?Y2ZZSHZJRHRpc0NqelpBYlN2eEZCNG83Wi9sWUdHb3hJckJKQ3JXdUFkRDg0?=
 =?utf-8?B?U1BLZkwvcS90QlRxd3Z4NEVVT2RrNExJSUlFVlhTanUwSVNGNUcrczlDNmJj?=
 =?utf-8?B?QjV4aVBtQmpSNmJieUt6anhvUEZYeStKQnhYMWlKOGMxa3QxdzlyR2IvSXFW?=
 =?utf-8?B?dHpReXJwRSs2S0pKQWxUT3JVc0tKSzFNR3drQklkY040eDVQWkFmVzJUc3d3?=
 =?utf-8?B?RXFUeXpNVnFVbTVQSEtpVU1nam1HL3pERHFZY3V3K2FDOThLNFBFRWJlUWxj?=
 =?utf-8?B?UUtVV2ZKNHFEdVZlVVJyY3FrcVo1Z1NNWkpXWHVEZ2VlYURsY3lKdVk0ME44?=
 =?utf-8?B?QVlVUnpsU1RhbGFNZzg1Q0h0bmlGbUxBc0ROV3NtWjlwcG54aER1aGJ6S3Bs?=
 =?utf-8?B?azRnV2VQRmllNklvODFXRE81a2JTaEJiNWFLSlNzUHVFd3I2M1JxVDJUaFRT?=
 =?utf-8?B?S0dSYTFkVXZNd25jN1JXL2twQXYxcVg5ZzhGREdJbUhjMW5SRWsvUWxWeFdQ?=
 =?utf-8?B?YnQ4K2pNejFJRG94NU5venppOWVKdmxKNWZVMFBhdWcxeHlQTndDd3JOV2Rj?=
 =?utf-8?B?OWpTbWc1TVordmZCb0d3NjEyUXljYjVkNDFJTXFFbTF2L0g2bHlmdkgyUUg0?=
 =?utf-8?B?SVhaZTFpaWhZUDk5d0tQaXFjc3l5a1c4OG52VUlzYXVtZVZlSURod3g2OUZl?=
 =?utf-8?B?U01NOGJ3V2xseDFxU2lkSXN3cUJsejVDbW9hNWFad25LL1hkODZJNnNVMFBn?=
 =?utf-8?B?ayttM0F3dXNRZm9UMVZZMDNCOEI5VFJmQ0pJU2dnWTc0cWNkTnVjWXQxQS9X?=
 =?utf-8?B?czNDZWsvRGRFeVppcHUxUkZvMlduQ25rZzJwaXFlMVd2aEVBMmdjbUdIQWNF?=
 =?utf-8?B?eGFrYjNTWFF2cmg3TklkT0VrdGlQV0NOaTNiTmY2SkZFN0g0c2pyTnZGUWtM?=
 =?utf-8?B?MU11K21GVE1kRzdYOVUxaUFVVVNtR1duOXRiYlN1V2Q5U3poMW9BcGl0L1du?=
 =?utf-8?B?ckxjWWkrajV0aFVwTXJ5SVhYRHhOMkxLelFEaFd6dmZjT0s5a01EVWhXZG9o?=
 =?utf-8?B?Y3VONTN1QVRXZUNkZ0FBWHBQRzhOS3dwZGVnV1dUN0tWYTd2aVlGWjhvRE1Y?=
 =?utf-8?B?cmVucERCMTN3MzZVYlNhNDI5WXRvT1d2MlpGQWNYQ1VreXJxdHJyM3JGTzJL?=
 =?utf-8?B?d0JFTG9MbGVEWTZ4bEw1dE9zaWs4eENvQW1JK3dOaEJRV1BxSEVMK1lnSlNR?=
 =?utf-8?B?RCtucVl2ckxlSm41enc4SldnUS9vcWUxNWxGYmtvQ1JweVBFUW9rc2I3M3Ar?=
 =?utf-8?B?VmpCVVJIK2E0bHNjdUpMbWJheUtZaFJ4WjN0M28vbmV4V1h4WUIyQnpqKy9N?=
 =?utf-8?B?NE05MlVDOThxUXA5dllmZ2FwVi9YNW5jOTUySzd3akJNTUdNT0FaTng1VzR2?=
 =?utf-8?B?Zm9hNmdsYkd3U2NxaHdicWpOd3pNOWVrWVJqNXV2TXk2V1hiZG5MdlAyZHFR?=
 =?utf-8?B?YzBncXlwaWlvQ3JGT2VDM3V0dkJZR1FyU0VPMUpqTnlxR0gzc0NoZDVIQW4v?=
 =?utf-8?B?ZCtCbXppTC9BNGVaQ1E4TkR0c1hNMHpEZ0kwdnVXb3c1NzcwZHdRdkczbWpZ?=
 =?utf-8?B?UTZFL016dFZmUWNsZzY0dm5ZQmY3dFNXWHJwM3B1N0hGUVFjSHlRbXJQUlZz?=
 =?utf-8?B?cVFMNWk5bEtVek1rVk92R0xEYkFqSERuUXl1aWJ2WUFCZlRlSnZxdzl0QUxP?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13b62539-4ffb-4f16-63f9-08dc8514b427
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 04:05:14.9909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AYSGF+Zy0qiEJLvWYb7eKU90Yqz6SeWPIu61/x/p73rMh0pSvoVPTTMt05Sn51vQvwl0IACHsDLvoyD2W8uJbQJL1/j3MMMXP5Z/1GhH2RY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8214
X-OriginatorOrg: intel.com

On 6/5/24 05:47, Su Hui wrote:
> Clang static checker (scan-build) warning:
> net/ethtool/ioctl.c:line 2233, column 2
> Called function pointer is null (null dereference).
> 
> Return '-EOPNOTSUPP' when 'ops->get_ethtool_phy_stats' is NULL to fix
> this typo error.
> 
> Fixes: 201ed315f967 ("net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
>   net/ethtool/ioctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
> index 5a55270aa86e..e645d751a5e8 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -2220,7 +2220,7 @@ static int ethtool_get_phy_stats_ethtool(struct net_device *dev,
>   	const struct ethtool_ops *ops = dev->ethtool_ops;
>   	int n_stats, ret;
>   
> -	if (!ops || !ops->get_sset_count || ops->get_ethtool_phy_stats)
> +	if (!ops || !ops->get_sset_count || !ops->get_ethtool_phy_stats)
>   		return -EOPNOTSUPP;
>   
>   	n_stats = ops->get_sset_count(dev, ETH_SS_PHY_STATS);

Thank you,
both the change and provided Fixes tag are correct.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>