Received-SPF: pass (google.com: domain of linux-kernel+bounces-201827-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Su Hui <suhui@nfschina.com>, "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "nathan@kernel.org" <nathan@kernel.org>,
        "ndesaulniers@google.com"
	<ndesaulniers@google.com>,
        "morbo@google.com" <morbo@google.com>,
        "justinstitt@google.com" <justinstitt@google.com>
CC: "andrew@lunn.ch" <andrew@lunn.ch>,
        "ahmed.zaki@intel.com"
	<ahmed.zaki@intel.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "justin.chen@broadcom.com" <justin.chen@broadcom.com>,
        "jdamato@fastly.com"
	<jdamato@fastly.com>,
        "gerhard@engleder-embedded.com"
	<gerhard@engleder-embedded.com>,
        "d-tatianin@yandex-team.ru"
	<d-tatianin@yandex-team.ru>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev"
	<llvm@lists.linux.dev>,
        "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: net: ethtool: fix the error condition in
 ethtool_get_phy_stats_ethtool()
Thread-Topic: net: ethtool: fix the error condition in
 ethtool_get_phy_stats_ethtool()
Thread-Index: AQHatxYSXfoPHCepTkml03iA540XAw==
Date: Wed, 5 Jun 2024 07:00:38 +0000
Message-ID: 
 <PH0PR18MB4474096265EED015A2A7FBE0DEF92@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240605034742.921751-1-suhui@nfschina.com>
In-Reply-To: <20240605034742.921751-1-suhui@nfschina.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?4lJ4Q2PGCEPueivPBIPvgQYGx+30ehwnJK/f+1ah8qyTJZKwk3kWvilgWnOg?=
 =?us-ascii?Q?WpWAxlJ78ZgICz4mQBBIh5YXzBsnLRQ6ddi4bqm7XxU6wXNSEa1pw0i0hN1F?=
 =?us-ascii?Q?LqHs7lhjQkjz3yhPuY9KA5EWfKe2YYYeYLtuxlTO6eq0JfT6e3tULXHjHJUv?=
 =?us-ascii?Q?JgM+5UN/NEcNrM+Iq5ix1/i4Z9NWoaKACzzgsR40sc6mdwInCXmRxK9IhPXw?=
 =?us-ascii?Q?7479Xi1HpK+61YsEAQGfq6yEj6UYM3x90zM8F9fLkAr9isG4vvz0noDKGzAj?=
 =?us-ascii?Q?KbKqfmeIZ7mI/S1c2Xg0hBn+0WooPCNB/R75NcySdUWMiHKwG6vqz4xIIwbM?=
 =?us-ascii?Q?7EYsE1+uLlAG6V5SHqnFWbThJRbUgEuIV9V0Syze119dy+0GipNforyoWcCL?=
 =?us-ascii?Q?DCZAcMKqATA3ixRbzzVWZX6IS8bJN2mf0f+odqh0yIlM/AKWgTSLm1mMN9MK?=
 =?us-ascii?Q?T7yHK56HFiu5wZf6sJRxPTq8LG7gqBx2w2eSN2F5Oi6WArRg/59yBKGnK2Xj?=
 =?us-ascii?Q?J8CvwN1L5QIEsmmgGPTfHCDpwt8Rv2cbQBjx/i6c+OoEHe/1St5Z8CIilGYm?=
 =?us-ascii?Q?IUyBH1fluuwTM37LcX1GuR+T6CHeQtTgG1q2QFzFF3SHzZ30DsX2L1Nl5Grd?=
 =?us-ascii?Q?lNVaWEoou7LnU08LEFn3CIRugLNmF3DhwuGAZfkXqb6H7XEm7XOtXVJdbREg?=
 =?us-ascii?Q?H66MlUAUgiB6+Xz7COLyhB7BIpCnhcI1SZfVzhn35Beo6oU7AVWjQVCwvcdL?=
 =?us-ascii?Q?d9Npa6PZf8gN65Z9aigrAupngz5LFOpGXNjYa6v1RBEDXdQ0efbZ4DXv1iZw?=
 =?us-ascii?Q?i4Nudm9cHACxefWMBjEVvTvLnpwIKRiuRbpVA9YB97q0mtkUzQX0NAEpMDLP?=
 =?us-ascii?Q?RP4Scuuc5h/O9Pfd36VpQtH3soZv87/xW6tewxABuzn7UxbjjQ5SZD5xxan4?=
 =?us-ascii?Q?dGXENwpQjONR2lp13yAz5rGPyVPPJmyZ/pPta0ekiZPeZ2NXqyihzAuuwUrn?=
 =?us-ascii?Q?l46rH4EUr6LMbjity0r57Cq1Xib0aQNG3bay1IH2D2Ap3rD53AI9IGjWvowy?=
 =?us-ascii?Q?Eq36E5j9MJ3Ax95kJgIzdpLtow2a/zqnSsI9SqP8roc+rAjT/0NK8CuL+NfW?=
 =?us-ascii?Q?mKm8zICGd7WrazbKsVIvu4w3B6jpqelCV5TbWKkrnIkJyVD6n3+AVbkcG39N?=
 =?us-ascii?Q?wwSMNjgRMpl6JeixllHijaMVbGAs662lQKUje9er1uhWRIEsZEwNPNtnP2fu?=
 =?us-ascii?Q?omvwDx3lRrqSAS0Xjouad/uI2jASEDV0FgfDjZiMgpQhnROk99PZr0dmzxFj?=
 =?us-ascii?Q?2ibRDWiWFE+PnmwuXg8bEvPQvU+H4OesyUpSaGlMpc+DMHnLZ2wwWycAeyw1?=
 =?us-ascii?Q?L90cnPLcmKj8K0TEjape07acgsgXvSMaoQdSxsE+QuiOTI0xjFcq5bknL3Kb?=
 =?us-ascii?Q?qt8M0oAPWqwAQM/8DRFugARuXEqi7h8HNY1w+W9fRJ7RBRtbkHyv5yHVIszH?=
 =?us-ascii?Q?cPlLJrGFRXhxkFti5IH8qv+g0CxjXq6jKNL8FjF1ge5xY/dnMWDvhXblDVJn?=
 =?us-ascii?Q?V8DxZYyE6WqYxIm/Rt4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fa3abc5-4b01-47b4-fd3e-08dc852d34b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2024 07:00:38.3881
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QGbls36K8j3JbOvXt+JjEeI02o8YK9zIqSF2LpEawvmFAzAA27Viyo/7gRXCNuVscDbB4OeXOcw1PR9hxD3g8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB5210
X-Proofpoint-ORIG-GUID: bOU1_Y3k0uGnyvPzksPpn52BoZZNAaEK
X-Proofpoint-GUID: bOU1_Y3k0uGnyvPzksPpn52BoZZNAaEK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_11,2024-06-05_01,2024-05-17_01


> Clang static checker (scan-build) warning:
> net/ethtool/ioctl.c:line 2233, column 2
> Called function pointer is null (null dereference).
>=20
> Return '-EOPNOTSUPP' when 'ops->get_ethtool_phy_stats' is NULL to fix thi=
s
> typo error.
>=20
> Fixes: 201ed315f967 ("net/ethtool/ioctl: split ethtool_get_phy_stats into
> multiple helpers")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
>  net/ethtool/ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index
> 5a55270aa86e..e645d751a5e8 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -2220,7 +2220,7 @@ static int ethtool_get_phy_stats_ethtool(struct
> net_device *dev,
>  	const struct ethtool_ops *ops =3D dev->ethtool_ops;
>  	int n_stats, ret;
>=20
> -	if (!ops || !ops->get_sset_count || ops->get_ethtool_phy_stats)
> +	if (!ops || !ops->get_sset_count || !ops->get_ethtool_phy_stats)
>  		return -EOPNOTSUPP;
>=20
>  	n_stats =3D ops->get_sset_count(dev, ETH_SS_PHY_STATS);
> --
> 2.30.2
>=20
Good catch!!

Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>