Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp117191lqr; Wed, 5 Jun 2024 00:10:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUq32Cho4et4C3ALruFoljmg3rXdbRoMREKsxPvMKcgvVNGYQZeiJvHOE6LuTaGXA8+g4pR5/UaI0qNqQC611qPIy5bp67M9gFRlWgLJQ== X-Google-Smtp-Source: AGHT+IFPmAZM42PCniM1cGNe2209oSw4pD664QRbW+VMPzSX01M/Zkz4jj8IEHHiFNT+bw5Snj2k X-Received: by 2002:a17:906:31cd:b0:a68:cf22:ebdb with SMTP id a640c23a62f3a-a699f88868bmr95290666b.43.1717571403458; Wed, 05 Jun 2024 00:10:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717571403; cv=pass; d=google.com; s=arc-20160816; b=bCz+Lo4z6xYycsE8xhW6DZBVuNxWL4Hem2pt6HxZjEP3ASTGhrtM0FuZ797pA0NlAW vY7JtOH+CEQvAUqgFqBC7JxJ8JgiuKoTnWGGkAxJs+jfyDTtCiAJ2LJ6nLXyGkgP26ep 3jWHr64DanqyXLQ+DBH1+j5xL/w2HAj/1aZl6NEXDf6HewnmFpxzlS52DkPQBkoX0yD7 lDbXRGlls3B69KPLSsKzuyhMROWTv64Z75rI4L0IlpV8criOP8vJmFfZVqIS7RxDdqPw 8jcLZtROeVyQqsJfgZyg5suTSUXwG8V55S2xhNDAKFLQHCgfhNq8RlJXqX8u+da+iJFk Aqeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sQSephwmytgo/YLLaqWzVbfXRJtJuGRKYodF45aiwbI=; fh=TqCc2fBSkfpFMh/tghEBz13A0nDJk9SC12XPSpNiaaY=; b=fH2I25lWEOt8lwNpXTP9NcQQHCiuz5UzTbVUsyqnmMfDkknBaZ3QIXMh1j8cbPfaLu vSX9qYqVryYRFa93ibiJv6rQKb+lyFIKhHJc5zvtLw1dZRpKiI9sPEg2RCLeAOaSxo8T 9UgdYhO8fkp4C5yCpAxBgt42xsQfBfnN+G53iqAw4RZNOmRrkfVjETu7shL1fpa2NrJf Cg6GE8SlMw9WpgP3C3WWZF16SRaCC/WW8wqDSJ0QeaLmda0ZZ00Ak0jWjWoudu6NBl6r 5OWIgq6qs3lPNBI2Miy2A4Cmk+29jk05V8o9z8n7B38A+bs+lEYcdSvaggmZmHL3eAtW vBmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U7b7OZCK; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-201843-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201843-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a67ea38f2ffsi589025666b.477.2024.06.05.00.10.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 00:10:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201843-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U7b7OZCK; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-201843-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201843-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 25DC31F22A9C for ; Wed, 5 Jun 2024 07:10:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E357B18C32B; Wed, 5 Jun 2024 07:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U7b7OZCK" Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712DBDDA5 for ; Wed, 5 Jun 2024 07:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717571363; cv=none; b=YVjL6omoUPjNGFkCmngTPbvucfFv9XjP2zFgDZWPXb/TDk5VLLLV0kTnFnNR1lENM21xl7MUf5fToF0lwFPVCC6JQRatsGQMzQ9CkUQUncSqXn3tXrvxegMk6yPrj1YJsEG7EPIPG/7y78gL31k1Eyrd3FA/WSsTmaNV6fBn9GI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717571363; c=relaxed/simple; bh=gtowOOZmB6VPvTmh98OBdJ/GTkP1Yo/Ot5b/hFyw0YM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vGdCqx3ZKVV90Sk2FIQ6JaUiMZfSKAANu/masBlXA0Nh4BEIeqh8d4kZGflles+bo1NwZO3/CXn/XEKHoJLGLkMWOFq7IDwgl0I+DrYpiMNJtRbjsvBHT7S5pbOSnQyAwAzwL5cabJ98DMnFhATsMGSDbBaoZUn6fa94Yew8DDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U7b7OZCK; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57a32b0211aso2234115a12.2 for ; Wed, 05 Jun 2024 00:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717571360; x=1718176160; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sQSephwmytgo/YLLaqWzVbfXRJtJuGRKYodF45aiwbI=; b=U7b7OZCKTFzT1gCjgU606ZD33vKTBiTIQgMsppNqTdnFnPXoIGUkvd527yYF7wwU56 BLm6MyNr9D92TUms3Nh842MfaPrt/vPpzchD3aju2W2mCLJHQVt9RAMQ877xDRXB/F90 OAcuLzPW8zBBtZYqPmFcsmPDs0w3bBy0Ly+E8tcEHJiGlDHZnIDk5gTRN/jzjx2fOS+O XGPrjy2F34Q8HS3rsWhqJwm6p21R/fStDKzTgaEwba3+jC3lsGIgrfzI4a4nlvIOalv4 VK3tXFESi8AdM6zNjgSmQuZc/w0zT+jN7lx+G4c298ADpX3s1Y+BmKZBjlIy/vEOqisO vLjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717571360; x=1718176160; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sQSephwmytgo/YLLaqWzVbfXRJtJuGRKYodF45aiwbI=; b=g215smPJi+vxnjahMVZ440CC677tC1KBvPOzHM+PBrBGVFyAOIFQR73t0RvTflgzO7 mVOwWipWizRp1qWjoPpO76JAJ2rYTGOGv16Ra8UZMdXCXuFeWoMOX6iUTG0CiyK0T4cU hmec9VIGK4wQSCQdDXEebYMQN3co6JS8g57ykSnNY8Yt4elXhpKEzzS8j208ggt2jJ2D oHEvUEunttk/wj3fbq4BpE9wkj4paHjOWBmVvET4oOQU4NYfwHLdrS6GnXQAZa5dEogT 2v3xjCCF6KG3E4nFFlXjsBMGUFwBo+Gzl8YdQd1M5/Gn8C4zSokqegYt4B8cFSA6oJxZ 8POQ== X-Forwarded-Encrypted: i=1; AJvYcCU63TqMLrjVK9tWvq6D6PlFS3bs4dIVzdv53LOY8JzQ47CDwGz9L9pjMbZKEFUxLuB0kSkLyc7GezOPHqGK+xTJag+in+uykkh/iTy1 X-Gm-Message-State: AOJu0YxcaT8njsCTw1dg8vIXjFFYF5KaPdPh/WQIhjk+DTqpBKc+hkfo p0HQU4M8cFQiNmMhWCJZUUmSLSVpgPe4hfgvFYDmDYa2Fz+WNQIGMCaDom3o7LU= X-Received: by 2002:a50:9e62:0:b0:579:cf9d:d6a with SMTP id 4fb4d7f45d1cf-57a8b6b88c5mr1085082a12.20.1717571359412; Wed, 05 Jun 2024 00:09:19 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a35e86c36sm8560156a12.54.2024.06.05.00.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 00:09:18 -0700 (PDT) Date: Wed, 5 Jun 2024 10:09:14 +0300 From: Dan Carpenter To: Dmitry Yashin Cc: Linus Walleij , Heiko Stuebner , Luca Ceresoli , Jianqun Xu , Jonas Karlman , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] pinctrl: rockchip: delay recalced_mask and route_mask init Message-ID: <094fbb0c-099c-4839-b2c5-162775e35710@moroto.mountain> References: <20240604141020.21725-1-dmt.yashin@gmail.com> <20240604141020.21725-2-dmt.yashin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604141020.21725-2-dmt.yashin@gmail.com> On Tue, Jun 04, 2024 at 07:10:19PM +0500, Dmitry Yashin wrote: > For some SoC's like rk3308 additional runtime setup needed, so delay > recalced_mask and route_mask init. > > Signed-off-by: Dmitry Yashin This sounds like it needs a Fixes tag. Should it be backported to stable? I understand that you only know that rk3308 is affected, and probably you worry that other devices are as well? Just do your best on trying to figure out which is the first commit where this bug started to matter. Any information is better than no information. The commit message should say what the bug looks like to the user. Why would a user want this patch? I can probably figure it out from reading the code, but I shouldn't have to. regards, dan carpenter