Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp122417lqr; Wed, 5 Jun 2024 00:23:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQ63JXWSSUK2rHuLASWoM+ABu/cJmuIemXVgoXWc4oI4QQx3aTGBkgOP0j88jdcazC0YvXmoIaCo7WeZLhaHXZLY+YAlh6A0c4BnmNqA== X-Google-Smtp-Source: AGHT+IEwd/hEmiiKnhLxI/mAe3fIR8t2eSMYy3zBdI+D0Sdjheck26aGWA2mX2awqxEeyfTcgc4f X-Received: by 2002:a50:8d1d:0:b0:579:c4f6:dee9 with SMTP id 4fb4d7f45d1cf-57a8bca213dmr1057601a12.34.1717572213066; Wed, 05 Jun 2024 00:23:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717572213; cv=pass; d=google.com; s=arc-20160816; b=SQKcaVHtSVte068JNIg84PbCEvIR74gjjzJcohYQ9KYtOtW/hUwoprjpY3pE80bBMc 5NjlbXXwEYz7/45KJSOYjPOcG59rzDfq+y26xc+Azu/9FiKvET8n+idrVFrLvXsdvLF6 +FCMK1Cbsj27IPa2z4AebMit4hu46g1WE7tv0E407wtAPhnKBpmuycMHks96cGQIaEHe cxmwB0Vywdi6Mk9tSBz+z2hmlST3z5IrNUtasf90/IheJ90r9ogMQsTBpWWh48bTLFkb YHglRszP6A+EwEuCOb1hOEiEKCVs0ibi1p6oVDPcedANxGDpPooHqhtC8NU9GoDtW2iF kP0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RqnZdFgvboe7tX2UKgOGW0Pa1N7zuJuJPg9c9wyxQMg=; fh=lUb91V2gtc9kywuzz693oJtqruwzVYg2ev7tucuN17o=; b=JmOWW8uYC7czoB4xbgUdjf1LQrwv8nRSy8PZJVw4DFL4IJPa4w5QFR4zHISGzlBxJa Y4W81vox81VuHgR714XLcuWrotgICDJvpRnWgV5WeHZ+CgokPFrSs1nyY7PdjJ7+zIx4 TNYDx1bvUCkuUxlpIdTaFcatydQVLwDUqlCjUiQ0ru7NrolrWDjRGxgb+gUGLLhx0xuN QvgJ/slnR1bpXUWC0ZgBNJWbtjUcxaFWZZawj3dD4z+7i0DkQY6tju7eafy0jr2/FPF1 QyKCJfhu3Lo3UcsZ+XBoWg7P32n8ANesA98lphsx2O3C1C178hT4LqkPFPbJduMfh083 5Frg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YD55qfcj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-201875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a4b46367asi4595362a12.197.2024.06.05.00.23.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 00:23:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YD55qfcj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-201875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C609D1F222DC for ; Wed, 5 Jun 2024 07:23:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2AE991922F0; Wed, 5 Jun 2024 07:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YD55qfcj" Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84351922DD for ; Wed, 5 Jun 2024 07:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717572177; cv=none; b=e7T6GC8xJslOvaPP8rXQ+YBh+3oBb97UwrIZmZ5hIwSqD+RMyuPTrVR5u538hKdKQBL9H/xwniWZQ3ezBdF2bDkB6nGV6h+3eHefK3Cefa87p5gaOa1Qn4yv9vaPrDnL9+1lmeyXXbS+wPcjbdMqABp/rEwebZgiSO+TJNU6fHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717572177; c=relaxed/simple; bh=R4YKIM6OKd1WIlOGsM6YjhBav9nZ9U9MhpDx2XiXALo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m9ZZfYUAnfQs6jG8+PYNBd6aAUnYUhTziM19nbO9pbJYH2GCU+setlm37YezLG/GviHKc1e27JQUyP/phzRuG6UocHjg6Yz1QINK4uxfly2SqW0RkQs1s1YhFBInqDeGNfDMvxX6nCE71wZdqMqiJcz47IBctkmM+PSnHTbILDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YD55qfcj; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52b950aa47bso2644220e87.1 for ; Wed, 05 Jun 2024 00:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717572174; x=1718176974; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RqnZdFgvboe7tX2UKgOGW0Pa1N7zuJuJPg9c9wyxQMg=; b=YD55qfcjDfOPWxSNsWWoCc7hMBzAWe+akRiI8lzSH8z/iGpBGcYp0JFqNsj3je+ItV P1V6WizYoA/H0X5EsVo03D2uWwuj3nt648KNBkko/8+xZIHTi8NF35GhdFEJgMBHAfwA 0CrWixDkKgPJjXRXdHIMPsc90/VuMNk7X8HX+5nSzmTUidkjHs91TPIXzvSIjxkU+w31 EqRBBlF6p50NGZAYwFW9USrK5daTHT+T9/NihUkPrJ0F03W5KiGZMVQJXz9beozjj7Bz V5QfTpO/kxaiEqr04mcE7etRSEon+zfE4F+aVLK6p70w5phZf57JmDX41BEjFlSOLlqh pDJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717572174; x=1718176974; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RqnZdFgvboe7tX2UKgOGW0Pa1N7zuJuJPg9c9wyxQMg=; b=sls2MaRPkIK+KHxELOgsmC+aVdFKHJBjdTVSJoiwE1k42rI9PZoiRZnRPLDiymdhyB 3J9r1oelklftObCQbFWzZoxzxPfdoM/fHv3kfJs/QriJoBAnLbRtAvOo/APQ84nU7Zzg HGwcJIsLEidCvsMSCpWe6NwIongVuypHPOxjDFxGMl22jxlLlAdZnecjj7pn9km+kniw 7JtUcX0QT8YjW0ahHUG84T4zD5wyDjQhRTzWOr8S7oXQyif9WREy1B8ZnaZ669VZRCPi HHgVxlIb01zEftrRYWyL2WShdFl/NVX7/7Q5kFD/aDOLkzFWdSJfdUK8eNSQIWsS+5tl 67pQ== X-Forwarded-Encrypted: i=1; AJvYcCVNzNTnb7zFFox6VS6anZn3obgRVwYtGd3Tk0/YrnLJ1KqvU0IiQcVjIFks0TchDr/6sGKLE4hCfRVDZudftr7jpB/0ZodfrnLIb44k X-Gm-Message-State: AOJu0Yz503iOGpMvesCBBVYQz+6fUP7ztW90THxr9RT6Lzduglqawo6a 93FY+AbjiVgNB0L0oxhkf9FULEhEHFiAGsKy0bi6F7d1VOm5Ib1D3qRrYxeKP6g= X-Received: by 2002:a05:6512:2308:b0:52b:83d5:34 with SMTP id 2adb3069b0e04-52bab2843eemr1239519e87.0.1717572173579; Wed, 05 Jun 2024 00:22:53 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68519892c8sm695071366b.65.2024.06.05.00.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 00:22:53 -0700 (PDT) Date: Wed, 5 Jun 2024 10:22:49 +0300 From: Dan Carpenter To: Dmitry Yashin Cc: Linus Walleij , Heiko Stuebner , Luca Ceresoli , Jianqun Xu , Jonas Karlman , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] pinctrl: rockchip: add rk3308b SoC support Message-ID: References: <20240604141020.21725-1-dmt.yashin@gmail.com> <20240604141020.21725-3-dmt.yashin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604141020.21725-3-dmt.yashin@gmail.com> On Tue, Jun 04, 2024 at 07:10:20PM +0500, Dmitry Yashin wrote: > Add pinctrl support for rk3308b. This pin controller much the same as > rk3308's, but with additional iomux routes and 3bit iomuxes selected > via gpio##_sel_src_ctrl registers. Set them up in the function > rk3308b_soc_sel_src_init to use new 3bit iomuxes over some 2bit old > ones and update iomux_recalced and iomux_routes for the new SoC's. > > Fixes: 1f3e25a06883 ("pinctrl: rockchip: fix RK3308 pinmux bits") Why does this one have a Fixes tag? Isn't this new hardware support? Possibly patch 1/2 was not actually a fix but just preparation for this patch? regards, dan carpenter > Signed-off-by: Dmitry Yashin > Reviewed-by: Luca Ceresoli