Received-SPF: pass (google.com: domain of linux-kernel+bounces-201887-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Frank Wang <frawang.cn@gmail.com>
To: bjorn.andersson@linaro.org,
	heiko@sntech.de,
	heikki.krogerus@linux.intel.com
Cc: gregkh@linuxfoundation.org,
	andriy.shevchenko@linux.intel.com,
	devicetree@vger.kernel.org,
	djrscally@gmail.com,
	hdegoede@redhat.com,
	krzysztof.kozlowski+dt@linaro.org,
	linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org,
	rafael@kernel.org,
	robh+dt@kernel.org,
	sakari.ailus@linux.intel.com,
	william.wu@rock-chips.com,
	yubing.zhang@rock-chips.com,
	frank.wang@rock-chips.com
Subject: Re: [PATCH v5 5/7] usb: typec: mux: Allow multiple mux_devs per mux
Date: Wed,  5 Jun 2024 15:37:55 +0800
Message-Id: <20240605073755.17452-1-frawang.cn@gmail.com>
In-Reply-To: <20220422222351.1297276-6-bjorn.andersson@linaro.org>
References: <20220422222351.1297276-6-bjorn.andersson@linaro.org>
Precedence: bulk

Hi Bjorn,

> In the Qualcomm platforms the USB/DP PHY handles muxing and orientation
> switching of the SuperSpeed lines, but the SBU lines needs to be
> connected and switched by external (to the SoC) hardware.
>
> It's therefor necessary to be able to have the TypeC controller operate
> multiple TypeC muxes and switches. Use the newly introduced indirection
> object to handle this, to avoid having to taint the TypeC controllers
> with knowledge about the downstream hardware configuration.
>
> The max number of devs per indirection is set to 3, which account for
> being able to mux/switch the USB HS, SS and SBU lines, as per defined
> defined in the usb-c-connector binding. This number could be grown if
> need arrises at a later point in time.
>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v4:
> - None
>

With this commit, TCPC device shall match *two* endpoint ports both for switch
device and mux device if they have the same parent node like the following
existed DT. It causes the callback function is invoked twice both for switch and
mux in tcpm_mux_set() process.

// arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
&usbdp_phy0 {
        mode-switch;
        orientation-switch;
        [...]
        port {
                #address-cells = <1>;
                #size-cells = <0>;

                usbdp_phy0_orientation_switch: endpoint@0 {
                        reg = <0>;
                        remote-endpoint = <&usbc0_orien_sw>;
                };

                usbdp_phy0_dp_altmode_mux: endpoint@1 {
                        reg = <1>;
                        remote-endpoint = <&dp_altmode_mux>;
                };
        };
};

BR.
Frank