Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp139291lqr; Wed, 5 Jun 2024 01:08:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXQuFv1cLidWOZ5qzoWvvbBZl1JcyOA/4RmThH9BiBvQzC2woIBKAResd7VU2CkDIH7QYWATN4JkG0Yy4WmWBmRKQTENTIjxTN5g9yPsA== X-Google-Smtp-Source: AGHT+IFxX7fmdhj7fJdmelN5rbs4AVwTBZ88u2RdAZrGbidKeE6FnTIMsKTN55mHissALomwd7Qr X-Received: by 2002:a05:6358:5926:b0:19c:548f:8064 with SMTP id e5c5f4694b2df-19c6c68517bmr225962355d.2.1717574891979; Wed, 05 Jun 2024 01:08:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717574891; cv=pass; d=google.com; s=arc-20160816; b=QuYam6aGMuYcve6MP5aDp15rA6GoG6+f1cCAhKRC+cRX1QbI7xqkr6QnQDdRuPJFr1 +Yzi3YmxRS35F0WwAUvqHAmSgxqqYWAFd28rP4k7uvwY6ijrGGUhBBvmFJUMXu1JVoMY 8XvZgtnqgrbHsRiIfj1ffUp8GHQCx205AIA2Nb3nEy95cTNrdWjyChWh9h2Zm7MrAga4 o1Lx5OXJMdWjkiA52SjNLtXzyx6NS3fdvuYvuASvtFeNLcf7uU0w2ok/xCYT/3VZ5xId cU+Dt+ZtbcjmXh15446lCupYem0wVpwny++hUNIflWWPgOLvaNPq0fmXvaxQLpZFAqrF lKtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=mrCOiRPfrbF8KgkjXf2+OjTb6u3WQ9a+GX9ZNmr2TUc=; fh=vA1X5Od/CA9XhmigijdpZT/O9y28Q7ZYKx1ZUFs2Ocs=; b=vcXsN22wMnLWh9YTLXuy++Qfu5xxkyPMA54zjg5r52QS7dOSndCF/QP+LDRt9TSoMe eeN6z73g/UX7VrkK2NDUjkCNO53L/MHjL/OtZYi0f3RFOnhuny7PlHZ7xzEdOfV0cb8X RflxUqnk+r6kClCf9R8qWZzb+fNM14ZhGBsZz4wZSEf/yqaIdmG3e/BFPMNlNOxCQvwd SktHZ0fHybHKF/n/hiStq1A9s6cCi31AfZeOEKu141Lhm2shpTaoFCgNMdJEF2cFrTZA mLMASVaWU0Gx+qCpcMo6fvzsfFUfkjZrzp0o3gbkyawN7Egq+Y9ZoDQ6yml4iaIqCKjm 7dqQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=eKb9SgiM; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-201926-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35d59fa47si2494104a12.857.2024.06.05.01.08.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 01:08:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201926-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=eKb9SgiM; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-201926-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8268B281EED for ; Wed, 5 Jun 2024 08:08:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0372F18F2F2; Wed, 5 Jun 2024 08:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eKb9SgiM" Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7072518F2E4 for ; Wed, 5 Jun 2024 08:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717574882; cv=none; b=TetOEVrgezTqwSvASMIa1YZSsslqN4DfaqYGxhsnjSs7R7tBePsCOz/vhiGBBi7P/vYAo+c/pwNm+OUBW3yjLzYcEipQsWCpnpbsGYI2YhRv5RoSQ1ZoTQJJPrmzAPMMiok7fG+SDn+2fKGf1+pIIw+EI4NjjS6Aogy/DN46xnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717574882; c=relaxed/simple; bh=PaE7mEZfJxLBb2yt2DAyS73D75IvOfORiK3X0XZJW+Q=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=aW2cfb9qnT15m+FVr2KtJidk7Tmz7dr53EzHJqV/p7dKcaW5y5rNFbrVsBk0aXlreL3/NP2cPXlJxNgnr81zDAOsmOxDg0MW+60zz1rOHiFJkXUQEW+flx8Zb8p2nw3YYrdZWjxLrmGDNyuA6JWEPfdxrtovQA1pe1Yqo7qHsQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eKb9SgiM; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4213a2acc59so45255e9.1 for ; Wed, 05 Jun 2024 01:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717574879; x=1718179679; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mrCOiRPfrbF8KgkjXf2+OjTb6u3WQ9a+GX9ZNmr2TUc=; b=eKb9SgiM1Ywd2b2fjnigch5afjE0A0sA+5Y+7Kxa2Ik6GFQm6MkPKA79Jf6P449FLk wkY5C2oA4Okd3khdhVjQ4RhEhINz8LklGcuS5CSfFJfMdOfHhPxEK/TnzPk3p7N7KVei 6P0nm/NjadEW9M5E9wJBsIbZGCbSuL0K/Dpgo54/+8521YoHQ03NS8S12V7PQGJH0uEp q7R4HJeIWQ02V3hIgr7kl+rS2tJeDipyE837GUaoJmxzsvx2WwXKn+jj4ShMW3xe+4Oa YN1AfOk6ku8bO7ZqiOQireFUzTDZPPl9Ccl8J+9kwWddNwsIIhS8JYop0nV0X7iOuNqI +1CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717574879; x=1718179679; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mrCOiRPfrbF8KgkjXf2+OjTb6u3WQ9a+GX9ZNmr2TUc=; b=tJjuImwTwVqzfWDGewRrBRz4dOjFHVXXM2Qmxn6OzEX/SI+jLaVumv9/pyLT+bF87K wdlC9rbNTIKPBR6Z49Xgcw95bnPFndWMylgO6kudWjeHOvQLE9D8Qa477wJzna8AVtxd r4ZMnm3LVPbWzXNAQQqtW7k9MHtiE7fFmTl0lGRbu57kL7QMTJHWtNDjByuJtpn3q3L5 BlN/ahJiaRXSLMyThQuZYfhZer0zlrPpvfrA/VX/Q3l0U4HlPXdiZpmyG8mu6I0cxOFH zSTzoCAIbTjofX2vq+bKax3U6nYhsKZO6g7MfZk9fuzpEq8sbGom4Ks/M2IQnNxFmc2/ ooIg== X-Forwarded-Encrypted: i=1; AJvYcCUjMcGo/pLwZ3nEBAkhHnheyrCSxcyEkPe+HNd9NHzzmUArLf784l7BjdjPaBqe0++sb3btU1WqZcxEKGLrhp0gTygTgK8pzD5Qcukb X-Gm-Message-State: AOJu0YyHywlupm1PNVe25BdVSBLNt1t3BR4ofjPZKRcE9kswt86sbZbT WD2O7lUaxHX9KgqBGsBox8IDFCtsq1Dv4hlNJoNsGmy4HGVVwA1OPWxRcoRdP38JtSr96yLq6bb ysYMR6EA+7kTZxwK3Hp+uY3Qa8PQLhDrD76g/ X-Received: by 2002:a05:600c:2942:b0:418:97c6:188d with SMTP id 5b1f17b1804b1-42157e4cd5cmr1243755e9.7.1717574878367; Wed, 05 Jun 2024 01:07:58 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240605-tcp_ao-tracepoints-v2-0-e91e161282ef@gmail.com> <20240605-tcp_ao-tracepoints-v2-3-e91e161282ef@gmail.com> In-Reply-To: <20240605-tcp_ao-tracepoints-v2-3-e91e161282ef@gmail.com> From: Eric Dumazet Date: Wed, 5 Jun 2024 10:07:47 +0200 Message-ID: Subject: Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers To: 0x7f454c46@gmail.com Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , David Ahern , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Mohammad Nassiri , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 5, 2024 at 4:20=E2=80=AFAM Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454c46@gmail.com> > > Two reasons: > 1. It's grown up enough > 2. In order to not do header spaghetti by including > , which is necessary for TCP tracepoints. > > Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> Then we probably do not need EXPORT_SYMBOL(tcp_inbound_md5_hash); anymore ?