Received-SPF: pass (google.com: domain of linux-kernel+bounces-202019-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <131231eb77014ce38bbe611e99be5ebb713c471d.camel@gmail.com>
Subject: Re: [PATCH v2 1/3] iio: adc: ad7192: Clean up dev
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Alisa-Dariana Roman <alisadariana@gmail.com>, Alisa-Dariana Roman
 <alisa.roman@analog.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, 
 Michael Hennerich <michael.hennerich@analog.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org, 
 linux-kernel@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>, Alexandru Tachici
 <alexandru.tachici@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor
 Dooley <conor+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark
 Brown <broonie@kernel.org>
Date: Wed, 05 Jun 2024 10:40:24 +0200
In-Reply-To: <20240605075154.625123-1-alisa.roman@analog.com>
References: <20240605075154.625123-1-alisa.roman@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-05 at 10:51 +0300, Alisa-Dariana Roman wrote:
> Clean up by using a local variable struct device *dev.
>=20
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
> ---
> =C2=A0drivers/iio/adc/ad7192.c | 45 ++++++++++++++++++++-----------------=
---
> =C2=A01 file changed, 23 insertions(+), 22 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index 0789121236d6..f06cb7ac4b42 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -1196,17 +1196,18 @@ static void ad7192_reg_disable(void *reg)
> =C2=A0
> =C2=A0static int ad7192_probe(struct spi_device *spi)
> =C2=A0{
> +	struct device *dev =3D &spi->dev;
> =C2=A0	struct ad7192_state *st;
> =C2=A0	struct iio_dev *indio_dev;
> =C2=A0	struct regulator *aincom;
> =C2=A0	int ret;
> =C2=A0
> =C2=A0	if (!spi->irq) {
> -		dev_err(&spi->dev, "no IRQ?\n");
> +		dev_err(dev, "no IRQ?\n");

Since you're here, dev_err_probe()?

> =C2=A0		return -ENODEV;
> =C2=A0	}
> =C2=A0
> -	indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st));
> +	indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st));
> =C2=A0	if (!indio_dev)
> =C2=A0		return -ENOMEM;
> =C2=A0
> @@ -1219,71 +1220,71 @@ static int ad7192_probe(struct spi_device *spi)
> =C2=A0	 * Newer firmware should provide a zero volt fixed supply if wired=
 to
> =C2=A0	 * ground.
> =C2=A0	 */
> -	aincom =3D devm_regulator_get_optional(&spi->dev, "aincom");
> +	aincom =3D devm_regulator_get_optional(dev, "aincom");
> =C2=A0	if (IS_ERR(aincom)) {
> =C2=A0		if (PTR_ERR(aincom) !=3D -ENODEV)
> -			return dev_err_probe(&spi->dev, PTR_ERR(aincom),
> +			return dev_err_probe(dev, PTR_ERR(aincom),
> =C2=A0					=C2=A0=C2=A0=C2=A0=C2=A0 "Failed to get AINCOM
> supply\n");
> =C2=A0
> =C2=A0		st->aincom_mv =3D 0;
> =C2=A0	} else {
> =C2=A0		ret =3D regulator_enable(aincom);
> =C2=A0		if (ret)
> -			return dev_err_probe(&spi->dev, ret,
> +			return dev_err_probe(dev, ret,
> =C2=A0					=C2=A0=C2=A0=C2=A0=C2=A0 "Failed to enable specified
> AINCOM supply\n");
> =C2=A0
> -		ret =3D devm_add_action_or_reset(&spi->dev, ad7192_reg_disable,
> aincom);
> +		ret =3D devm_add_action_or_reset(dev, ad7192_reg_disable,
> aincom);
> =C2=A0		if (ret)
> =C2=A0			return ret;
> =C2=A0
> =C2=A0		ret =3D regulator_get_voltage(aincom);
> =C2=A0		if (ret < 0)
> -			return dev_err_probe(&spi->dev, ret,
> +			return dev_err_probe(dev, ret,
> =C2=A0					=C2=A0=C2=A0=C2=A0=C2=A0 "Device tree error, AINCOM
> voltage undefined\n");
> =C2=A0		st->aincom_mv =3D ret / MILLI;
> =C2=A0	}
> =C2=A0
> -	st->avdd =3D devm_regulator_get(&spi->dev, "avdd");
> +	st->avdd =3D devm_regulator_get(dev, "avdd");
> =C2=A0	if (IS_ERR(st->avdd))
> =C2=A0		return PTR_ERR(st->avdd);
> =C2=A0
> =C2=A0	ret =3D regulator_enable(st->avdd);
> =C2=A0	if (ret) {
> -		dev_err(&spi->dev, "Failed to enable specified AVdd
> supply\n");
> +		dev_err(dev, "Failed to enable specified AVdd supply\n");

ditto

> =C2=A0		return ret;
> =C2=A0	}
> =C2=A0
> -	ret =3D devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, st-
> >avdd);
> +	ret =3D devm_add_action_or_reset(dev, ad7192_reg_disable, st->avdd);
> =C2=A0	if (ret)
> =C2=A0		return ret;
> =C2=A0
> -	ret =3D devm_regulator_get_enable(&spi->dev, "dvdd");
> +	ret =3D devm_regulator_get_enable(dev, "dvdd");
> =C2=A0	if (ret)
> -		return dev_err_probe(&spi->dev, ret, "Failed to enable
> specified DVdd supply\n");
> +		return dev_err_probe(dev, ret, "Failed to enable specified
> DVdd supply\n");
> =C2=A0
> -	st->vref =3D devm_regulator_get_optional(&spi->dev, "vref");
> +	st->vref =3D devm_regulator_get_optional(dev, "vref");
> =C2=A0	if (IS_ERR(st->vref)) {
> =C2=A0		if (PTR_ERR(st->vref) !=3D -ENODEV)
> =C2=A0			return PTR_ERR(st->vref);
> =C2=A0
> =C2=A0		ret =3D regulator_get_voltage(st->avdd);
> =C2=A0		if (ret < 0)
> -			return dev_err_probe(&spi->dev, ret,
> +			return dev_err_probe(dev, ret,
> =C2=A0					=C2=A0=C2=A0=C2=A0=C2=A0 "Device tree error, AVdd voltage
> undefined\n");
> =C2=A0	} else {
> =C2=A0		ret =3D regulator_enable(st->vref);
> =C2=A0		if (ret) {
> -			dev_err(&spi->dev, "Failed to enable specified Vref
> supply\n");
> +			dev_err(dev, "Failed to enable specified Vref
> supply\n");

ditto

> =C2=A0			return ret;
> =C2=A0		}
> =C2=A0
> -		ret =3D devm_add_action_or_reset(&spi->dev, ad7192_reg_disable,
> st->vref);
> +		ret =3D devm_add_action_or_reset(dev, ad7192_reg_disable, st-
> >vref);
> =C2=A0		if (ret)
> =C2=A0			return ret;
> =C2=A0
> =C2=A0		ret =3D regulator_get_voltage(st->vref);
> =C2=A0		if (ret < 0)
> -			return dev_err_probe(&spi->dev, ret,
> +			return dev_err_probe(dev, ret,
> =C2=A0					=C2=A0=C2=A0=C2=A0=C2=A0 "Device tree error, Vref voltage
> undefined\n");
> =C2=A0	}
> =C2=A0	st->int_vref_mv =3D ret / 1000;
> @@ -1305,13 +1306,13 @@ static int ad7192_probe(struct spi_device *spi)
> =C2=A0	if (ret)
> =C2=A0		return ret;
> =C2=A0
> -	ret =3D devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
> +	ret =3D devm_ad_sd_setup_buffer_and_trigger(dev, indio_dev);
> =C2=A0	if (ret)
> =C2=A0		return ret;
> =C2=A0
> =C2=A0	st->fclk =3D AD7192_INT_FREQ_MHZ;
> =C2=A0
> -	st->mclk =3D devm_clk_get_optional_enabled(&spi->dev, "mclk");
> +	st->mclk =3D devm_clk_get_optional_enabled(dev, "mclk");
> =C2=A0	if (IS_ERR(st->mclk))
> =C2=A0		return PTR_ERR(st->mclk);
> =C2=A0
> @@ -1321,17 +1322,17 @@ static int ad7192_probe(struct spi_device *spi)
> =C2=A0	=C2=A0=C2=A0=C2=A0 st->clock_sel =3D=3D AD7192_CLK_EXT_MCLK2) {
> =C2=A0		st->fclk =3D clk_get_rate(st->mclk);
> =C2=A0		if (!ad7192_valid_external_frequency(st->fclk)) {
> -			dev_err(&spi->dev,
> +			dev_err(dev,
> =C2=A0				"External clock frequency out of bounds\n");

ditto=20

- Nuno S=C3=A1