Received-SPF: pass (google.com: domain of linux-kernel+bounces-202047-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 5 Jun 2024 14:28:22 +0530
From: Jai Luthra <j-luthra@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
        Tero
 Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
        Krzysztof
 Kozlowski <krzk+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jayesh
 Choudhary <j-choudhary@ti.com>,
        Devarsh Thakkar <devarsht@ti.com>, Bryan
 Brattlof <bb@ti.com>,
        Aradhya Bhatia <a-bhatia1@ti.com>,
        Francesco Dolcini
	<francesco.dolcini@toradex.com>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs
Message-ID: <yd4doskkq443xkvc4ahnxexyi7f5oteoh5egiv3plcduyl7dfr@dgtdwd3dbdkg>
References: <20240604-mcasp_fifo_drop-v1-0-03ebe25f47db@ti.com>
 <20240604-mcasp_fifo_drop-v1-5-03ebe25f47db@ti.com>
 <20240605084713.GA10711@francesco-nb>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240605084713.GA10711@francesco-nb>

Hi Francesco,

Thanks for the review.

On Jun 05, 2024 at 10:47:13 +0200, Francesco Dolcini wrote:
> Hello Jai, thanks for the patch.
> 
> On Tue, Jun 04, 2024 at 03:11:06PM +0530, Jai Luthra wrote:
> > McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
> > on the DMA IP. Drop these for better audio latency.
> > 
> > Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
> > Signed-off-by: Jai Luthra <j-luthra@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > index 2038c5e04639..27e5220e1dc7 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > @@ -1364,8 +1364,8 @@ &mcasp0 {
> >  	       0 0 0 0
> >  	>;
> >  	tdm-slots = <2>;
> > -	rx-num-evt = <32>;
> > -	tx-num-evt = <32>;
> > +	rx-num-evt = <0>;
> > +	tx-num-evt = <0>;
> 
> From my understanding of the dt-binding having these properties set to
> <0> is equivalent to not having those properties at all.
> My suggestion would be to just remove those, therefore.
> 

I was following the existing convention of setting it to 0 for 
disabling, as done in k3-j721e-common-proc-board.dts

IMO it is better to keep it explicit, but I don't feel strongly against 
dropping it either (as long as we do the same for j721e). Will defer the 
decision to the tree maintainers.

> With that said, in any case, whatever you do my suggested change or 
> not,
> 
> Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Francesco
> 

-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145