Received-SPF: pass (google.com: domain of linux-kernel+bounces-202088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <996a88c057dd2b6b4d960fbe9f8e35bd69270e86.camel@gmail.com>
Subject: Re: [PATCH v3 3/6] spi: spi-gpio: Add support for MOSI idle state
 configuration
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>, broonie@kernel.org, 
 lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, 
 robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
  nuno.sa@analog.com, dlechner@baylibre.com, marcelo.schmitt1@gmail.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 05 Jun 2024 11:26:09 +0200
In-Reply-To: <8dcce41a69a89cb8ace2587ca7ddb1c665f2d1cb.1717539384.git.marcelo.schmitt@analog.com>
References: <cover.1717539384.git.marcelo.schmitt@analog.com>
	 <8dcce41a69a89cb8ace2587ca7ddb1c665f2d1cb.1717539384.git.marcelo.schmitt@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-06-04 at 19:42 -0300, Marcelo Schmitt wrote:
> Implement MOSI idle low and MOSI idle high to better support peripherals
> that request specific MOSI behavior.
>=20
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---

Acked-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/spi/spi-gpio.c | 12 +++++++++++-
> =C2=A01 file changed, 11 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
> index 909cce109bba..d3b8c99f0cb4 100644
> --- a/drivers/spi/spi-gpio.c
> +++ b/drivers/spi/spi-gpio.c
> @@ -236,6 +236,14 @@ static void spi_gpio_chipselect(struct spi_device *s=
pi,
> int is_active)
> =C2=A0	}
> =C2=A0}
> =C2=A0
> +static void spi_gpio_set_mosi_idle(struct spi_device *spi)
> +{
> +	struct spi_gpio *spi_gpio =3D spi_to_spi_gpio(spi);
> +
> +	gpiod_set_value_cansleep(spi_gpio->mosi,
> +				 !!(spi->mode & SPI_MOSI_IDLE_HIGH));
> +}
> +
> =C2=A0static int spi_gpio_setup(struct spi_device *spi)
> =C2=A0{
> =C2=A0	struct gpio_desc	*cs;
> @@ -411,7 +419,8 @@ static int spi_gpio_probe(struct platform_device *pde=
v)
> =C2=A0
> =C2=A0	host->bits_per_word_mask =3D SPI_BPW_RANGE_MASK(1, 32);
> =C2=A0	host->mode_bits =3D SPI_3WIRE | SPI_3WIRE_HIZ | SPI_CPHA | SPI_CPO=
L |
> -			=C2=A0=C2=A0=C2=A0 SPI_CS_HIGH | SPI_LSB_FIRST;
> +			=C2=A0 SPI_CS_HIGH | SPI_LSB_FIRST | SPI_MOSI_IDLE_LOW |
> +			=C2=A0 SPI_MOSI_IDLE_HIGH;
> =C2=A0	if (!spi_gpio->mosi) {
> =C2=A0		/* HW configuration without MOSI pin
> =C2=A0		 *
> @@ -436,6 +445,7 @@ static int spi_gpio_probe(struct platform_device *pde=
v)
> =C2=A0	host->flags |=3D SPI_CONTROLLER_GPIO_SS;
> =C2=A0	bb->chipselect =3D spi_gpio_chipselect;
> =C2=A0	bb->set_line_direction =3D spi_gpio_set_direction;
> +	bb->set_mosi_idle =3D spi_gpio_set_mosi_idle;
> =C2=A0
> =C2=A0	if (host->flags & SPI_CONTROLLER_NO_TX) {
> =C2=A0		bb->txrx_word[SPI_MODE_0] =3D spi_gpio_spec_txrx_word_mode0;