Received-SPF: pass (google.com: domain of linux-kernel+bounces-202165-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b52758c4-a0f4-4cda-9bd0-5ff022a9c9d0@intel.com>
Date: Wed, 5 Jun 2024 12:02:59 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3] net: ti: icssg-prueth: Add multicast
 filtering support
To: MD Danish Anwar <danishanwar@ti.com>, Dan Carpenter
	<dan.carpenter@linaro.org>, Jan Kiszka <jan.kiszka@siemens.com>, Diogo Ivo
	<diogo.ivo@siemens.com>, Andrew Lunn <andrew@lunn.ch>, Simon Horman
	<horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski
	<kuba@kernel.org>, Eric Dumazet <edumazet@google.com>, "David S. Miller"
	<davem@davemloft.net>
CC: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>, Vignesh Raghavendra
	<vigneshr@ti.com>, Roger Quadros <rogerq@kernel.org>
References: <20240605095223.2556963-1-danishanwar@ti.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240605095223.2556963-1-danishanwar@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTd3dElHSEVHTCsxUytJeTZDM3M2U1VUTFoxQVM3ajF4L0ZVK203Zzl3WWtk?=
 =?utf-8?B?SHlnZFZtd2RFOXhLRWtQbzFhc2xVU0N0ZHhPUHBzU0FKWHVjWkJPaFIrTkdy?=
 =?utf-8?B?ZWZBWHFWN0didGxBaTg2WDlhcUxsaEdndUlNZzZKSUgzUmZNdWR4ZzRid1VK?=
 =?utf-8?B?VEtHbnArL0FmVWhDaTRZL2lqeTZsTXdyZkhMV0NBelFIWU1pTHM3QkVqMENz?=
 =?utf-8?B?R0RDSUJVNDkvcjhMSlJOWHRNTGZvWFRpREt1V3Qwc1Q2Qk91YmJ6SDMvVjVH?=
 =?utf-8?B?eWlTcVFuUXFuMGcxRlpRVFpnWXBaWkF6aTVOSUlOQXFDSy9xRkJndHJzZnJX?=
 =?utf-8?B?bnpRZEQ2aGdXOGF6WU5FVnNqeVhMNjV1OTgwRVpJdDI3bHIvSnN2ZG1Xa2Rj?=
 =?utf-8?B?L0t6N1plb2dvckxrMFVKZDU2TkhDNGVSUXRxM0ZOL2VZcVhGM01sSjZ6MGZU?=
 =?utf-8?B?R3A5R2xvTlVBeS9MNUZ1dllMdXlIRExxWlpzL3Y4a1FYUzRkMG9IUmpGM201?=
 =?utf-8?B?cDN4TUJiTHoyZDdwdGF4eDRvbW9HMTl3VDRyOGJPOGRzNmE4OXdDWHRod3NH?=
 =?utf-8?B?TCsxTGNVKzRlelVsalpmaVdsdmdJMEZUbFhYVVlCOHlyUGNySm9HeUV2NVly?=
 =?utf-8?B?UW9YWS8xYnVLd3NQRE1laENGZGEwT3ArNytDbG9Ibkc2cjZEMytEVmxCS1ZB?=
 =?utf-8?B?cjc3emw5YmZlWHBQTkwyNnNLZjA0blh5S0U0czIvRHZzazNqZGh5WUNHRlJy?=
 =?utf-8?B?OUhsUjV3aVI5Z2sraGhvNWxiMzAxUlJzVUxYZ2p6cy8zakFFNGJVaFFWSWxu?=
 =?utf-8?B?TEpNVUNVTlcwVjhLRmo2Ukl3VmU5M0YySnUyVG5UYzlHbmhSbktOb25MUnlK?=
 =?utf-8?B?SHY0cFRQQlBFc09NR3EwNnFscHluQm1OUDk2dnU2RnI1K0NhTlNUdkwrNi9J?=
 =?utf-8?B?dDJOc3gzNXo1NCtPa3FhQkJxaW1VU2JrUzBUOUJWYnpid3d1aEhyemdKb095?=
 =?utf-8?B?K2FPVGI4ZitRVVBvcW9jT2k4MjVlb1QvWFZ1SzVQdUhOVWYxYXp5cnZuK1FP?=
 =?utf-8?B?OUFhRnl5bDFpZndpVDh6VStYY1UzeTBCdFhJTGpYcnN3RC9oV3dZclNpSjg5?=
 =?utf-8?B?VjN2SUxvSEViL25CS3hJM2FqMWhUTWdlK2Z6c0YxQk5vNWJocDhubDhqQys2?=
 =?utf-8?B?V1cydjNBMnpRLzBKSmFNRW9zT3JUTmZDT1FqejBHcUZxM2tUK01PVklBcnVX?=
 =?utf-8?B?ZUphd09Sank0eUlLTkZZN0tSVWovNjlJUEtzVWE5MEZOREl4cVRGMmtpSFJj?=
 =?utf-8?B?eWp0TDRVVUtHNkoxNVRTc09JbURhVXRkYTExQlVBU0pZWGNkeDZmMjFDSUVV?=
 =?utf-8?B?TTVBdVlrSzZhUWVkVWhYYXc5UTkza040cGxzY2FJRjBoUHkyUE01UHF2WHJO?=
 =?utf-8?B?anlLR2hKV1hYam9ZaW1tNERFZEdIRERYMTVzNWxEa3h1dXRQbjZyc2VmUVh4?=
 =?utf-8?B?WjNSSXJySC9lL3lZWVcyTHpjakllY1VoMWoyY2hXcDl0VGtDZ21BS3lnRmNq?=
 =?utf-8?B?OEZmRE9yaHBiVmlvdXUxd0p2SmdkZkRIR2RWSHVBQ3ovWE5uN0xZU0JsS0Zy?=
 =?utf-8?B?MnpRa0J2YWZtOGZ5RCsrQU5YTndJVTF6WE4xNUlrdFo4Zmo3NTRzQ2tRUmZv?=
 =?utf-8?B?RWtQOHlONkFXMTE4ZjJuSXVuSFh2ZURXRnNKUUk4VysyVld6bkJrS1JPekc3?=
 =?utf-8?B?TzVDRFdvekJ5NjZveFBaZ044NytPQ0pMQnB6WFJVcWxhUVRTM2hNWEdVS201?=
 =?utf-8?B?UW0zWGFsYUZVelMrT1ptRjZwdHgvYlZ6eGVsMmxOVXJUOEdYa00zWDFUdE9M?=
 =?utf-8?B?ZlRCaXQwSnZvdzBkUlp4SS8zUEpUME9SMlpxRUVnUTFrSjhCNEtKMTl6QjYv?=
 =?utf-8?B?TTFJYVZmWHlvdTZuZDZoR1VSc3VuTDZvSmVYN0hteTdKM1Y2SUg3aWdEMUZN?=
 =?utf-8?B?bUlvSGVrSHNLUG9mWDF6WDFHRGhIdTV4U2xsZFFrL2JMNzBtbmNHaXJETzNS?=
 =?utf-8?B?OTE1VlNrU3NPWXVrTDVTZUNjZkw2Y3VuNVlqMVhIc2t3MnhKTndheWV1Rlg0?=
 =?utf-8?Q?N9jijDOAh+fx+BI2p9ef4v+GJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c3d0fc37-8a37-4d1d-90bf-08dc8546b2d4
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 10:03:07.6506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FQkbJ4+XREhMBcmPZ9ZX41Gqhg5qoTZ+Rx6g7tL8QP5FSJ22GdnvcQIrcmwNNskblLB/hMkVKJ+QJcaXRuJfOtsuDn/8GXHZJrmKcIPDSBw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7473
X-OriginatorOrg: intel.com


On 05.06.2024 11:52, MD Danish Anwar wrote:
> Add multicast filtering support for ICSSG Driver. Multicast addresses will
> be updated by __dev_mc_sync() API. icssg_prueth_add_macst () and
> icssg_prueth_del_mcast() will be sync and unsync APIs for the driver
> respectively.
> 
> To add a mac_address for a port, driver needs to call icssg_fdb_add_del()
> and pass the mac_address and BIT(port_id) to the API. The ICSSG firmware
> will then configure the rules and allow filtering.
> 
> If a mac_address is added to port0 and the same mac_address needs to be
> added for port1, driver needs to pass BIT(port0) | BIT(port1) to the
> icssg_fdb_add_del() API. If driver just pass BIT(port1) then the entry for
> port0 will be overwritten / lost. This is a design constraint on the
> firmware side.
> 
> To overcome this in the driver, to add any mac_address for let's say portX
> driver first checks if the same mac_address is already added for any other
> port. If yes driver calls icssg_fdb_add_del() with BIT(portX) |
> BIT(other_existing_port). If not, driver calls icssg_fdb_add_del() with
> BIT(portX).
> 
> The same thing is applicable for deleting mac_addresses as well. This
> logic is in icssg_prueth_add_mcast / icssg_prueth_del_mcast APIs.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> Cc: Wojciech Drewek <wojciech.drewek@intel.com>
> 
> v2 -> v3:
> *) Using __dev_mc_sync() instead of __hw_addr_sync_dev().
> *) Stopped keeping local copy of multicast list as pointed out by
>    Wojciech Drewek <wojciech.drewek@intel.com>

Thank you!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> 
> v1 -> v2:
> *) Rebased on latest net-next/main.
> 
> NOTE: This series can be applied cleanly on the tip of net-next/main. This
> series doesn't depend on any other ICSSG driver related series that is
> floating around in netdev.
> 
> v1 https://lore.kernel.org/all/20240516091752.2969092-1-danishanwar@ti.com/
> v2 https://lore.kernel.org/all/20240604114402.1835973-1-danishanwar@ti.com/
> 
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c | 38 +++++++++++++++++---
>  1 file changed, 34 insertions(+), 4 deletions(-)
> 

<...>