Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp198692lqr; Wed, 5 Jun 2024 03:28:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWpHJ/F7Pn9SNSEI14UIb30FN+aOcIMyaWlmpLYPmhmt4OOxviLIlp0eha/cLmaLIvARSZRsVb4vPJXjcFFzXb12/xrRWF512nVu5vrGw== X-Google-Smtp-Source: AGHT+IFk9izzyisMZwG1Yz6NCC5rGKQwGkwkRm60Yl8GVKt0O6vJurBhrweEgG/+k0MqDsOCekb2 X-Received: by 2002:a17:906:7b87:b0:a68:e335:3e67 with SMTP id a640c23a62f3a-a699f665513mr164315366b.17.1717583307056; Wed, 05 Jun 2024 03:28:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717583307; cv=pass; d=google.com; s=arc-20160816; b=wUybw41hg5zrVkvhUZK0ZhpHSTjrzEJ8uA9QQNlHXz84Uf5fFnNVM5jW1JlRzxmeKX iXOi+PPYtf6Q1RTFTKs1somibIRwDuDKq8j2AQBqdN0g4mrin7oC61QBBfK59mtJ+XZn HHPu5dQMLOqCiBt7xdgVqSYKR+KIT3LI0fTaEluMNg359Z86QnR3A0HSOgIhdSm6Hw71 ZLfQRNNmAya+dKHH/q5UfkPaRQp0dI3E6vrgPu/rVt4FO937udrfq8i1f4g+JaBQSrAN U3JwCmtmClKhTdhcfk2G24++DFxBaGambGLF//I25wEsf9/M+s7BRdqJSYGUYNC8GSpy gr+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=LOCR+CIbOTwU3daD56Hj9k34unAHeOtnFYBrUoPiqis=; fh=m8JFO14zsbUvmW0drpXDS5KYk9RXiQSJnDvH4PhkEEs=; b=sUmbmaA6sa9xnWOaBAPUd/4/fmF00hyzbWq68LQ5Sn6mCjmfnkpt3wOm1Z/iCCf0oc h9N9NGo1NDMsOUDQE3AbnO5/foviHzkoI9b6knJxFCoGh5vHK1OF5PtP9NognqObdWvn 5KFQVL5doMgVKQ6zdxkUNiVk4l5k9mfeP1wWw0NoPNLDEwMUVrRH7gBhnza27TNEY5iI LOfai3/obYEoUrYg5sbkW7Ph7GVIX+nySlco7wZsjOZYHZocuwv/ng0aNDM6EMJlr2H8 /H00faHsTdGR88KHtpHTfrwAql7vlYqBC4k9FkoNZ1/ST/Fq3ZvK+jhSIO8xovXFzT4o 4ViA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=esl7LlX5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-202197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202197-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6900fd97afsi334028066b.372.2024.06.05.03.28.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 03:28:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=esl7LlX5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-202197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202197-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C302A1F23D85 for ; Wed, 5 Jun 2024 10:28:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 443FF191477; Wed, 5 Jun 2024 10:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="esl7LlX5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 638F4190048; Wed, 5 Jun 2024 10:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717583295; cv=none; b=mmZBAgCOxYKshFvEeQZ3PmjVSFGINIPdutL29BIHtBiHyqfbrB8yA6pxWd5PfngmPjm8oE4scn8PbMGpUsh72/tERFdoKLj2VLpEBP1bDx+pqPdljCX+M79oCEg5zDrsfK7/rTvAAOPND2f7aQwcJrpKi4/vo7bR47LwOfAIujg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717583295; c=relaxed/simple; bh=4OAyJRFBCWhd57GkH0+Vdq+6qk4KBfmFKqynSGutKcA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r5Eq9sFBJ6gXY9e+1keHwJuwnP23i7HmQR6qlRNwoNQYMrBfRxzGf6bDjC1mv6osQchkg/49/F4GNFfwcI4wYP0UlQZ/Bi4Ze4u8ZaX7dvSfygt4WX2dUV8MI6QnKRIFTTqrLFC89te1luA2VY44G8I003yRycSv+D8frqx1LZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=esl7LlX5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 677D1C3277B; Wed, 5 Jun 2024 10:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717583295; bh=4OAyJRFBCWhd57GkH0+Vdq+6qk4KBfmFKqynSGutKcA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=esl7LlX5Hnl8Wr9JETfxAYEr2uDnklk2I//XLWaX2U8G8sQtUs6478AnN5xPXyzlk 1YISe5y3JQs7yPRhd6aZBagykgnzk6SZT2X8D0Q7WNpY9s5ov2WQlD+edKude9G2Vf 8nQUKEHwwu6XDZ2d25FKNEqaRTYa2xf+daoAh0GrAcXLjgiOYDWcYcNlII0AcFJdlo +yCytkmMMOICF5gQdpgeKKDZRm5h4qB1vh3IyA/AGe0hluv54GzAxo7kXCpAMr80DF zSs2ZozWApgnn+VBvvY/1tiKPIntArhgdC6nmA59gkKvXi5K48dB/uLr+FFW9F8+78 ZbOBHUckptSRA== Message-ID: <9afab1bb-43d6-4f17-b45d-7f4569d9db70@kernel.org> Date: Wed, 5 Jun 2024 12:28:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 net-next 14/15] net: Reference bpf_redirect_info via task_struct on PREEMPT_RT. To: Sebastian Andrzej Siewior , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Boqun Feng , Daniel Borkmann , Eric Dumazet , Frederic Weisbecker , Ingo Molnar , Jakub Kicinski , Paolo Abeni , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Hao Luo , Jiri Olsa , John Fastabend , KP Singh , Martin KaFai Lau , Song Liu , Stanislav Fomichev , Yonghong Song , bpf@vger.kernel.org References: <20240529162927.403425-1-bigeasy@linutronix.de> <20240529162927.403425-15-bigeasy@linutronix.de> <87y17sfey6.fsf@toke.dk> <20240531103807.QjzIOAOh@linutronix.de> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <20240531103807.QjzIOAOh@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31/05/2024 12.38, Sebastian Andrzej Siewior wrote: > On 2024-05-30 00:09:21 [+0200], Toke Høiland-Jørgensen wrote: >> [...] >>> @@ -240,12 +240,14 @@ static int cpu_map_bpf_prog_run(struct bpf_cpu_map_entry *rcpu, void **frames, >>> int xdp_n, struct xdp_cpumap_stats *stats, >>> struct list_head *list) >>> { >>> + struct bpf_net_context __bpf_net_ctx, *bpf_net_ctx; >>> int nframes; >> >> I think we need to zero-initialise all the context objects we allocate >> on the stack. >> > Okay, I can do that. Hmm, but how will this affect performance? --Jesper