Received-SPF: pass (google.com: domain of linux-kernel+bounces-202170-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <3f9f0ef1-7290-21df-ef01-dc56b34a0195@huawei.com>
Date: Wed, 5 Jun 2024 17:52:16 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate
 versions of MSR ALLINT
To: Mark Brown <broonie@kernel.org>
CC: Mark Rutland <mark.rutland@arm.com>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <maz@kernel.org>, <oliver.upton@linux.dev>,
	<james.morse@arm.com>, <suzuki.poulose@arm.com>, <yuzenghui@huawei.com>,
	<tglx@linutronix.de>, <ardb@kernel.org>, <anshuman.khandual@arm.com>,
	<miguel.luis@oracle.com>, <joey.gouly@arm.com>, <ryan.roberts@arm.com>,
	<jeremy.linton@arm.com>, <ericchancf@google.com>,
	<kristina.martsenko@arm.com>, <robh@kernel.org>,
	<scott@os.amperecomputing.com>, <songshuaishuai@tinylab.org>,
	<shijie@os.amperecomputing.com>, <akpm@linux-foundation.org>,
	<bhe@redhat.com>, <horms@kernel.org>, <mhiramat@kernel.org>,
	<rmk+kernel@armlinux.org.uk>, <shahuang@redhat.com>,
	<takakura@valinux.co.jp>, <dianders@chromium.org>, <swboyd@chromium.org>,
	<sumit.garg@linaro.org>, <frederic@kernel.org>, <reijiw@google.com>,
	<akihiko.odaki@daynix.com>, <ruanjinjie@huawei.com>,
	<linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<kvmarm@lists.linux.dev>
References: <20240415064758.3250209-1-liaochang1@huawei.com>
 <20240415064758.3250209-2-liaochang1@huawei.com>
 <ZjUKMWPknEhLYoK8@FVFF77S0Q05N> <Zjjz-tzLRC2nH51A@finisterre.sirena.org.uk>
 <cde4d448-dc9d-eaad-4a2d-a6d34bda4449@huawei.com>
 <ZjpALOdSgu-qhshR@finisterre.sirena.org.uk>
 <e632a9ed-7659-9336-6e7f-a43c4759a7a3@huawei.com>
 <9868a5ac-ae23-4481-afe6-ba3cd8dbfa47@sirena.org.uk>
From: "Liao, Chang" <liaochang1@huawei.com>
In-Reply-To: <9868a5ac-ae23-4481-afe6-ba3cd8dbfa47@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Hi, Mark

在 2024/6/4 21:29, Mark Brown 写道:
> On Mon, Jun 03, 2024 at 11:26:39AM +0800, Liao, Chang wrote:
> 
>> Mark, Is your concern is that the series of pstate related macro name in
>> sysregs.h are lack of self-explanatory nature, which make it diffuclt to
>> understand their functionality and purpose? If so, I daft some alternative
>> macro names in the code below, looking forward to your feedback, or if you
>> have any proposal for making these helpers discoverable.
> 
> ...
> 
>> -#define SET_PSTATE(x, r)               __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))
>> +#define MSR_PSTATE_ENCODE(x, r)                __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))
> 
> Possibly, yes?  TBH I was thinking of a comment but that does have "MSR"
> in it so might come up in greps.  Not sure what others would prefer.

I am going to push revision v4 of the interrupt masking patchset, this revision
involves several improvements based on feedback and further testing:

- Addressed feedback comes form Mark Brown.

- Enrich the commit messages of patch includes major changes to provide more
  detailed explanations of the implemenations, purpose and potential result.
  This aims to improve developer understanding and reviewing efficiency.

- Revising the function names of logical interrupt masking to better reflect
  their purpose.

- Fixed bugs during local testing on platform with FEAT_NMI support.

Additionally, i note you left a feedback as below.

>...I've started looking at this in the series. There are some subtleties here, and
>I don't think the helpers in this series are quite right as-is. I will try to
get back to you next week with a description of those; it'll take a short while
to write that up correctly and clearly...

I appreciate your time and look forward your further feedback at your convenience.

Thanks.

-- 
BR
Liao, Chang