Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp259596lqr; Wed, 5 Jun 2024 05:29:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWLat6DKRiGsdEpvYI6CqOHWap5cyb0Yvfd4r2tnwSchYTRsJEpwqiE1nBgh+AeC4L8YSgQcdRWQKmGmT9VXG77CPDQ/VMiROc26o5rlQ== X-Google-Smtp-Source: AGHT+IGL7dRxip81Ro8kbpdrbVWEW7RUaVVTP4TvNAWALlBQk1ry130Xo654wDQ+SyZyo4kW5l9Y X-Received: by 2002:a17:90a:c292:b0:2bf:e6f1:59ed with SMTP id 98e67ed59e1d1-2c27db59a45mr2401378a91.32.1717590597349; Wed, 05 Jun 2024 05:29:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717590597; cv=pass; d=google.com; s=arc-20160816; b=puz2Rjr2vSRX/WgZ14//w2an7Z7wgVvisCtyXdVJGUmI4kEr0IDlPr7039ytCVjp15 ZD/5im64LWNYbxgTyW5+aPjLJs7rBxqWT7vqFSimp9vvKJiawKgCuTW9ImiItv+963e5 elM864zWfJN53oAWpTakcGhu+JR60vBJWqW+Ged4Z2FRM3XCmJDzpG9n/yskYQ9xjxRF y73+WXTj6zIAmrIAemlGdgCkYiiEzSYjyqnjx0UWn0ZHUs2CCwljIg1T+RNBWshGPkkJ BD4xDPNHh9kYC7V8R9pdAuBkJTGCy5gFzCoFaTcR4aMj+MoopnGYfOBsB9mAnMY6y+DE ZbMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=aV7BH4bTJ0KS+deiZLyoHPi2CIE4mm9DS/9jLD7oBFw=; fh=i3P+QXLBIYF6eCDeZ96TRPL0fgAjkcVhsLOlMU5kcE4=; b=0O/N2Pgc8gjI8Cq7vnX0gOm42Q0Wr66g86/0LWlwP++hj/BLHNd9SZueUAfmTyNO6R DHFyGM9sl1moEgRrvpwxOagDUoGWhPX+NSskjV7GUdGnGtI0jt/xSQrIaixctiYqqKvk 6HmCDRJV2ryZ7nG2sRxuTeUSSkOtjS5INhOHzUyBBcICS0i0lGs//2IMqEvl2hG843pK i+VPBJEXACxkrou8nY2MpNe7MHxTXjuSTV5Gj2uI8keaSadn5iumWfM2UzkFuCXai35G AMteuR+y8QUOKq1AtRz24QOcSDRo0lfWE2N/UdATL/tsKPrR+sZpGAqXRLC1aIgCPsl1 7i5g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WsxfZCxC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-202393-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202393-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c28063a64bsi1125683a91.10.2024.06.05.05.29.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 05:29:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202393-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WsxfZCxC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-202393-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202393-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1487828788E for ; Wed, 5 Jun 2024 12:13:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B357E1B29C6; Wed, 5 Jun 2024 11:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WsxfZCxC" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D477E1B29B3; Wed, 5 Jun 2024 11:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717588460; cv=none; b=nZnQC/pw+tKIdxnXMyqKo7IOUcQ0ELVpqifmDQTMWtQN6g1DTfAnnfOm1C+WucNFcPj+9fEQU96JxwROe2ybHIP09XiCpMcJiEQi09hINr7ZxUyXctyQ/JraB8phomuapJdlVo51tEBmuWHb4ymYvv7AaTaMT8Ps7X+SSToxGsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717588460; c=relaxed/simple; bh=keKYWfzN1djD6KLmxuPPa4XdGqVyHQTp9UFTeJAwljs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tLe8Y6DsKyAxGzwhnOjYVln5qv5LZGATMb54FQkbjWpoMhRgQndTX2zGladVigGA0nek7txkm/kLlx3pIOOL5rmWqFR+ccNu29gxC0jAFYKrRoWv+WJaL4NrQudQg0IjMr7JZx2CLHAc0k2CjnPZpYzLTsjTFp0epdBvFDLrmPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WsxfZCxC; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8214C32786; Wed, 5 Jun 2024 11:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717588460; bh=keKYWfzN1djD6KLmxuPPa4XdGqVyHQTp9UFTeJAwljs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WsxfZCxCYXH+wR+Lu6r6XGhpITj8mjTotbY/9FA1WspKbcPVuUzyUR6dSSr9PEalN JbmwSm30f6wiMgM+0Ow3IFi7daUdK+gLJ2KSDTiEXZGPsijrv0Nf8xkido5hs/GBXD MaKoWHQnESjuaMxUotHUn9x11Cj+0gUR/Ktx3Izfc0NTV5o0jLXgBMJ4OchvpB5zra qasRUa7IdQcpKy9kFtvuHkJduerrgn+5S/FSoiu8ciF03JxhLNYwZFkXf85EC6fPlo MKzbNA8/IcBWoGbsJYIwy/suz78IRC1g+KIXvaqWWhfW6YG6B3AVjcWw9XAaJE+pZ/ lyUt8W1cg64zQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Henrie , Greg Kroah-Hartman , Sasha Levin , sudipm.mukherjee@gmail.com, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 2/9] usb: misc: uss720: check for incompatible versions of the Belkin F5U002 Date: Wed, 5 Jun 2024 07:54:00 -0400 Message-ID: <20240605115415.2964165-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240605115415.2964165-1-sashal@kernel.org> References: <20240605115415.2964165-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.160 Content-Transfer-Encoding: 8bit From: Alex Henrie [ Upstream commit 3295f1b866bfbcabd625511968e8a5c541f9ab32 ] The incompatible device in my possession has a sticker that says "F5U002 Rev 2" and "P80453-B", and lsusb identifies it as "050d:0002 Belkin Components IEEE-1284 Controller". There is a bug report from 2007 from Michael Trausch who was seeing the exact same errors that I saw in 2024 trying to use this cable. Link: https://lore.kernel.org/all/46DE5830.9060401@trausch.us/ Signed-off-by: Alex Henrie Link: https://lore.kernel.org/r/20240326150723.99939-5-alexhenrie24@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/misc/uss720.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 0be8efcda15d5..d972c09629397 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -677,7 +677,7 @@ static int uss720_probe(struct usb_interface *intf, struct parport_uss720_private *priv; struct parport *pp; unsigned char reg; - int i; + int ret; dev_dbg(&intf->dev, "probe: vendor id 0x%x, device id 0x%x\n", le16_to_cpu(usbdev->descriptor.idVendor), @@ -688,8 +688,8 @@ static int uss720_probe(struct usb_interface *intf, usb_put_dev(usbdev); return -ENODEV; } - i = usb_set_interface(usbdev, intf->altsetting->desc.bInterfaceNumber, 2); - dev_dbg(&intf->dev, "set interface result %d\n", i); + ret = usb_set_interface(usbdev, intf->altsetting->desc.bInterfaceNumber, 2); + dev_dbg(&intf->dev, "set interface result %d\n", ret); interface = intf->cur_altsetting; @@ -725,12 +725,18 @@ static int uss720_probe(struct usb_interface *intf, set_1284_register(pp, 7, 0x00, GFP_KERNEL); set_1284_register(pp, 6, 0x30, GFP_KERNEL); /* PS/2 mode */ set_1284_register(pp, 2, 0x0c, GFP_KERNEL); - /* debugging */ - get_1284_register(pp, 0, ®, GFP_KERNEL); + + /* The Belkin F5U002 Rev 2 P80453-B USB parallel port adapter shares the + * device ID 050d:0002 with some other device that works with this + * driver, but it itself does not. Detect and handle the bad cable + * here. */ + ret = get_1284_register(pp, 0, ®, GFP_KERNEL); dev_dbg(&intf->dev, "reg: %7ph\n", priv->reg); + if (ret < 0) + return ret; - i = usb_find_last_int_in_endpoint(interface, &epd); - if (!i) { + ret = usb_find_last_int_in_endpoint(interface, &epd); + if (!ret) { dev_dbg(&intf->dev, "epaddr %d interval %d\n", epd->bEndpointAddress, epd->bInterval); } -- 2.43.0