Received-SPF: pass (google.com: domain of linux-kernel+bounces-202450-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 5 Jun 2024 13:02:05 +0100
From: Mark Brown <broonie@kernel.org>
To: Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>, lars@metafoo.de,
	Michael.Hennerich@analog.com, jic23@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	nuno.sa@analog.com, dlechner@baylibre.com,
	marcelo.schmitt1@gmail.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] spi: Add SPI mode bit for MOSI idle state
 configuration
Message-ID: <67f94cfb-6a33-4390-8032-a942f5f7b944@sirena.org.uk>
References: <cover.1717539384.git.marcelo.schmitt@analog.com>
 <e1d5d57f7a7481c84f64a764f9898122e278739b.1717539384.git.marcelo.schmitt@analog.com>
 <21d3314355b43ecd6acc42f9dfedec501418332d.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mHnYXajvsMh4YQv8"
Content-Disposition: inline
In-Reply-To: <21d3314355b43ecd6acc42f9dfedec501418332d.camel@gmail.com>


--mHnYXajvsMh4YQv8
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 05, 2024 at 11:14:33AM +0200, Nuno S=E1 wrote:
> On Tue, 2024-06-04 at 19:41 -0300, Marcelo Schmitt wrote:

> > +	/* Check against conflicting MOSI idle configuration */
> > +	if ((spi->mode & SPI_MOSI_IDLE_LOW) && (spi->mode &
> > SPI_MOSI_IDLE_HIGH)) {
> > +		dev_warn(&spi->dev,
> > +			 "setup: erratic MOSI idle configuration. Set to idle
> > low\n");
> > +		spi->mode &=3D ~SPI_MOSI_IDLE_HIGH;
> > +	}

> Should we assume such a thing? IOW, should this be treated as a warning o=
r a
> real error? I would assume this should be a configuration error and retur=
n -
> EINVAL but...

Right, and the error message isn't very clear.

--mHnYXajvsMh4YQv8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZgU7wACgkQJNaLcl1U
h9A0/ggAgTnq3tUcFs/WHjsTmKen81FYend6Evg4EOrYaNr+oZYdmcjeA66KPgrD
vYwFJb8WGJFeUKw0f5BKIUMhaKfrPaQWbnNWcgd/PijcnpVPUpeSmcZhFrqyrBh6
t55SxVxckcatxKdiNFg4jkAA8VrVQe+kSMcldyEfoj57VBURiL/KDMDHZX8Dibe6
aqfyos5JxZgkSoQtKxPBNCLglqNAxDn2EXSkUFYychLsWu3YiDJt9DegA8ueq4XF
vO5kCGFX+koWdOF8YS0a1NmDs/Stt86OzpJNTfwoFrnJtsbOtim71pkAM/aZsBgO
7Jqoa4uiUvDtAWt0aOGNJw7jHvKPag==
=Y7mf
-----END PGP SIGNATURE-----

--mHnYXajvsMh4YQv8--