Received-SPF: pass (google.com: domain of linux-kernel+bounces-202448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 5 Jun 2024 13:00:48 +0100
From: Mark Brown <broonie@kernel.org>
To: Dev Jain <dev.jain@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
	will@kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
	Anshuman.Khandual@arm.com
Subject: Re: [PATCH] selftests: arm64: Fix redundancy of a testcase
Message-ID: <a518770a-371e-4333-b85d-6a5808a7ac09@sirena.org.uk>
References: <20240605115448.640717-1-dev.jain@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WhGyFEmanl/izRpt"
Content-Disposition: inline
In-Reply-To: <20240605115448.640717-1-dev.jain@arm.com>


--WhGyFEmanl/izRpt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 05, 2024 at 05:24:48PM +0530, Dev Jain wrote:
> Currently, we are writing the same value as we read, into the TLS
> register; hence, we cannot confirm updation of the register, making the
> testcase "verify_tpidr_one" redundant. Fix this; while at it, do a style
> change.

Please don't combine unrelated changes into a single patch.

>  	/* ...write a new value.. */
>  	write_iov.iov_len = sizeof(uint64_t);
> -	write_val[0] = read_val[0]++;
> +	write_val[0] = read_val[0] + 1;
>  	ret = ptrace(PTRACE_SETREGSET, child, NT_ARM_TLS, &write_iov);
>  	ksft_test_result(ret == 0, "write_tpidr_one\n");

This is a good fix:

Reviewed-by: Mark Brown <broonie@kernel.org>

> @@ -108,7 +108,7 @@ static void test_tpidr(pid_t child)
>  		/* Writing only TPIDR... */
>  		write_iov.iov_len = sizeof(uint64_t);
>  		memcpy(write_val, read_val, sizeof(read_val));
> -		write_val[0] += 1;
> +		++write_val[0];

I'm less convinced that this is a good style change.

--WhGyFEmanl/izRpt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZgU28ACgkQJNaLcl1U
h9DqTgf+Ly/z4a+HW3C3ySPkAGM0USl5jc+LFjhwyijiNycgjcsQQwSNAqpkXbU/
i5NIAOBMsU/3Cu84mE+ccJzmKY9mqGJXze+b0p6lCtFAFX2lEUO8mwhk6wZwlYph
gaojRR2GZkNn8FFGBJFtDd676eXRpbY/PV0pAItO5Ckd5CVfICcM65NnVhzNnvav
Y7PD+B9rLpBvIrH5L4kPw82W9d/24nEtG1kXQJY/X72AATiGRz9RRkldVcCzOkf1
9NzBCyf3MjWzmbn9VFYyqfQsPQU41Q8nAM2/4tjzLouG+zXASVam6Y81PT0dzlkJ
i4VFYzvpDpz8y3hmNOGPkS/mr94TXA==
=8QbU
-----END PGP SIGNATURE-----

--WhGyFEmanl/izRpt--