Received-SPF: pass (google.com: domain of linux-kernel+bounces-202567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 5 Jun 2024 14:15:27 +0200
From: Juri Lelli <juri.lelli@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
	John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH linux-next] printk: nbcon: Fix
 nbcon_cpu_emergency_flush() when preemptible
Message-ID: <ZmBW3-j2f-pNdIzT@jlelli-thinkpadt14gen4.remote.csb>
References: <87zfrzvhsp.fsf@jogness.linutronix.de>
 <ZmA5oIkImclKM0vx@pathway.suse.cz>
 <ZmA6oGrO1YVF-IYj@pathway.suse.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZmA6oGrO1YVF-IYj@pathway.suse.cz>

On 05/06/24 12:14, Petr Mladek wrote:
> On Wed 2024-06-05 12:10:50, Petr Mladek wrote:
> > On Wed 2024-06-05 11:57:34, John Ogness wrote:
> > > nbcon_cpu_emergency_flush() can be called in a preemptible
> > > context. In that case the CPU is not in an emergency state.
> > > However, in order to see that the CPU is not in an emergency
> > > state (accessing the per-cpu variable), preemption must be
> > > disabled.
> > > 
> > > Disable preemption when checking the CPU state.
> > > 
> > > Reported-by: Juri Lelli <juri.lelli@redhat.com>
> > > Closes: https://lore.kernel.org/aqkcpca4vgadxc3yzcu74xwq3grslj5m43f3eb5fcs23yo2gy4@gcsnqcts5tos
> > > Fixes: 46a1379208b7 ("printk: nbcon: Implement emergency sections")
> > > Signed-off-by: John Ogness <john.ogness@linutronix.de>
> > 
> > Great catch!
> > 
> > Reviewed-by: Petr Mladek <pmladek@suse.com>
> > 
> > I am going to push it...
> 
> Juri, should/could I add your Tested-by ?

A yes please if you like. Thanks!

Tested-by: Juri Lelli <juri.lelli@redhat.com>

You guys were so quick to act on it! :)

Best,
Juri