Received-SPF: pass (google.com: domain of linux-kernel+bounces-202599-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 5 Jun 2024 13:24:33 +0100
From: Mark Brown <broonie@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com,
	marcelo.schmitt1@gmail.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] spi: Add SPI mode bit for MOSI idle state
 configuration
Message-ID: <0a716b10-0ae0-425f-919a-ea5d8b7975b6@sirena.org.uk>
References: <cover.1717539384.git.marcelo.schmitt@analog.com>
 <e1d5d57f7a7481c84f64a764f9898122e278739b.1717539384.git.marcelo.schmitt@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/ai5QVhWnEmXwiWy"
Content-Disposition: inline
In-Reply-To: <e1d5d57f7a7481c84f64a764f9898122e278739b.1717539384.git.marcelo.schmitt@analog.com>


--/ai5QVhWnEmXwiWy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 04, 2024 at 07:41:47PM -0300, Marcelo Schmitt wrote:

> The behavior of an SPI controller data output line (SDO or MOSI or COPI
> (Controller Output Peripheral Input) for disambiguation) is not specified
> when the controller is not clocking out data on SCLK edges. However, there
> exist SPI peripherals that require specific COPI line state when data is
> not being clocked out of the controller.

This is an optimisation for accelerating devices that need a specific
value, really if these devices need a value they should send it.

>  #define SPI_MOSI_IDLE_LOW	_BITUL(17)	/* leave mosi line low when idle */
> +#define SPI_MOSI_IDLE_HIGH	_BITUL(18)	/* leave mosi line high when idle */

Realistically we'll have a large set of drivers that are expecting the
line to be held low so I'm not sure we need that option.  I would also
expect to have an implementation of these options in the core which
supplies buffers with the relevant data for use with controllers that
don't have the feature (similar to how _MUST_TX and _MUST_RX are done).
Even without that we'd need feature detection so that drivers that try
to use this aren't just buggy when used with a controller that doesn't
implement it, but once you're detecting you may as well just make things
work.

--/ai5QVhWnEmXwiWy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZgWQEACgkQJNaLcl1U
h9BzVwf/XOcTR4d09YYBn0fjTHLD5RTAADKdYqwP/EXFklqqszGee4v3Q6MrGCke
1sfN9zIt5WxA7ETFjlpAF+jOjOxk/uaRgytTArEdFGh92N7fsIvcXpR+bKG6L5h5
DoHrUaEMPoWSC0ZPtCtE/Mtp/CIfa8zwjHMfkmYRgh+YIL1XnA+0BZ8H7N5bEQ5e
T4SLBCfgfqck2SlIDFU/+X3Z3nM4TF9g4/D2E1dLH5W/KHhX6ErFbhZVUcRvWh8R
mT3qNkxo+0hx+t5gwZR6TUSIUulew59oyKfDSr6yRvUj0RhdI1BvJsm74GlubUpw
fQerDO3rspJBANa5nCTDRkubmDR0Ag==
=7FcH
-----END PGP SIGNATURE-----

--/ai5QVhWnEmXwiWy--