Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp288749lqr; Wed, 5 Jun 2024 06:17:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVlmV6T8yypUnQLKL7XRl/1gFs6kCORjTCQYfqxYRf4HGzFTReHNrj6TAYJ1yQB0sG3jOpfbxs+iw8JGkeY7YscRN3gXzU5ngbgKilasw== X-Google-Smtp-Source: AGHT+IHSbiLU1Dfct16laiBlGZXXU9K6w4fNFdg3P4Fwbi3SacDNIakI8CW/DBB5jjHJjt3D75f0 X-Received: by 2002:a17:907:7e9e:b0:a68:ae2f:ea42 with SMTP id a640c23a62f3a-a69a0000c00mr196022266b.65.1717593476679; Wed, 05 Jun 2024 06:17:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717593476; cv=pass; d=google.com; s=arc-20160816; b=bZwNHXZunDzukqW5LeYsf43K4mGFVhD4bJN/jL522Z+ONfRy2mY24YhhihuUeZLnWY 1lXHtfphlBawVKZBgYmb3pv05b4wPaAmmb8yKqTt5P/ZkCx/wqpm1REVy8ewAgL6m+lQ +9Xp6pgx5ouWNHOhkeHtxBF7Hm/CJ6YN0nRa/XjfAIOvoXyoxrRtJIolJaqESi1eLQbo TSnWiU/REg55YwutabVPN5nfelGKQw6h2wY20cQp/HqxF3Vd4e5vgnr4NQpeZfsNQvQL uOcYejsujqpD1MYmqHIKYFHJ2z+clPy4vW5ghO+u/zkD88Nvvdd9fTwKAFb8ghIgOLVM q6rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=f+3E3BzuIwy3nzt7rPCLz2ZJt8+Iri1AkQe8yvM0D7Y=; fh=ooLAXhnjBAaQfbR02OLRo0Zj5Rkb1VP91DPhKU1Y/OE=; b=EEChjOuwJk4Xh7K6oK6ZqCa2ejLxCTn+RB7UhdJ5fefsd+8dw4GOxBBSPeSI9TXoC9 ubqWx2wG1oE2UEFIYjr6buehAzmH9r2DHhqU5AUDfvzuv/Rpx81HyvVu0dMwVILMlASN yP2hP28D6TY7712SU0gqYZA2cE+58T6JjBc2ljxg4aX30MkNw3dJBcU8HqS6M6m3egNA HuIH08aLOM5xWmYqd0SUT7VbRiK9/WL3RzwBHjzkfXzuhS7gODDRHdxnbReEPX9q/X5D kCv2KL1N4rlXTYIul5ujhdNN24Ix61ay6fW+UGm152ZitPTyL+jxQdCy7cmda7yvao03 yqyA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Pek2bJcX; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-202609-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202609-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a68bf85a912si445885466b.87.2024.06.05.06.17.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 06:17:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202609-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Pek2bJcX; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-202609-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202609-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9E6281F2515D for ; Wed, 5 Jun 2024 13:12:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2B44195391; Wed, 5 Jun 2024 12:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Pek2bJcX" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B4319CD0F; Wed, 5 Jun 2024 12:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717590470; cv=none; b=giqijUleLTkYrpbXckljNbnpQp/AM7utuZP8xeigBkjff71A0Qz/NSCBYhxetIlXYn2BGNk6ekPrT2rACK2ghJz4FfYTJODL3fZjg75xgIIv8N/B298mKTgXnLwkiGSvhjKSz59snMuXmpml0AkGFI2/9bRfpdo6/Q3pIPMVlQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717590470; c=relaxed/simple; bh=vAfBbs/RE3A6rRHJDVOYFTEdlEOETIb1vUNfnhuTtSk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e12kXUglU0wvjmRXDmA9/Q7N50AnXdOMKDxCmr7Qd+TsxlwopPPbneoaBg6pJ79+loMDPUj6hLNgZxKZmqA6AAvsHBeGIbIBXFEjLHNy2y4pAkAB6sSyD5yvv6scVe/DPsH+92jC0oWTv8AtjN6BU71p3zjX4SlJPrGu/XscYMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Pek2bJcX; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=f+3E3BzuIwy3nzt7rPCLz2ZJt8+Iri1AkQe8yvM0D7Y=; b=Pek2bJcXAetLeba80NpZqCB3WZ SwAmst1EdTciAd7vJLkCoF5TRBk+/RvfDUnxuI7PxjNmThA/UiaGnff6wEkeJiWfERCvhAWBXG7gh EMnm03V7gsaHnwLGlv+Zc5CT+7XmKgQ2O+pHhe6E026CjZXIvuHEF5Zpyi2x91BLxwz8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sEpjp-00GuN0-Ln; Wed, 05 Jun 2024 14:27:33 +0200 Date: Wed, 5 Jun 2024 14:27:33 +0200 From: Andrew Lunn To: MD Danish Anwar Cc: Wolfram Sang , Diogo Ivo , Roger Quadros , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, srk@ti.com, Vignesh Raghavendra , kernel test robot , Thorsten Leemhuis Subject: Re: [PATCH net-next] net: ethernet: ti: Makefile: Add icssg_queues.o in TI_ICSSG_PRUETH_SR1 Message-ID: <28803aee-e3fe-4e9d-8410-4ac957d77dd6@lunn.ch> References: <20240605035617.2189393-1-danishanwar@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605035617.2189393-1-danishanwar@ti.com> On Wed, Jun 05, 2024 at 09:26:17AM +0530, MD Danish Anwar wrote: > icssg_config.c uses some APIs that are defined in icssg_queue.c. > TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a > result the below build error is seen > > ERROR: modpost: "icssg_queue_pop" > [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined! > ERROR: modpost: "icssg_queue_push" > [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined! > > Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1 Please take a look at https://patchwork.kernel.org/project/netdevbpf/patch/20240528161603.2443125-1-arnd@kernel.org/ Andrew --- pw-bot: cr