Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp289668lqr; Wed, 5 Jun 2024 06:19:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTjLfV1izE6B0m3UolmFiFmXkGAS6iVJFiQ5tFJ5KGenKOrG51O8Pb6GeXBVab/PXswtIqYUslZKR3khvVIEflAt8IYdwsbTi0BRXHEQ== X-Google-Smtp-Source: AGHT+IEIydGZ8mJG5IWvEw+S+RTR1gvqsOQgjVIZBKSCZu0ZQ0oc/p8uzV2xb7ld+iDxxx3FLJGp X-Received: by 2002:a05:651c:198e:b0:2ea:7a2a:4d1c with SMTP id 38308e7fff4ca-2eac797f3b6mr21559021fa.8.1717593560403; Wed, 05 Jun 2024 06:19:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717593560; cv=pass; d=google.com; s=arc-20160816; b=TJcCbXEGfKcHr01dF8Gs7BWgTUlcIq4mnhKSLELB5eB4HnXYKRAucU76xDUPBLnnxk VKR22JHTuc9Dwn44uH+t51KnqrXtf1gg5/Lm6LYFbMMWLFMtdacU/kNvtFeGvk5WcbaY fqBg1F03Kl9n/wzb6/UbrWST+bCLmDiNQbdiyObfDChwWomYxvNYWhCxnBeTj0eY0Lcv p847d6qv4bp452wyTL1ePFRXBSvMQ0rLn9yaWS/ujXxnLxc92VlZWN4LFifFx6Hx2oW3 /R2vv7g/9EvkHuJQS+/HQePS6hEhOKK7i8Vh4frrF4vmgDGcgf5yEqq9q1QE4eA5O0+u Y2Zg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=BPo+1b9cy3Fmv+y1xRUSrrj3UDFxCnljcz5ROjfBrrU=; fh=8XvThbTZEBM5wWxGCS9k2lohKnXnOyMHsvJ9G5/PudU=; b=iLHJuUiQHUA1EaD4D7FrqVJgUytchy89ob9NTt7WJY2T9kialO6A90fThcnFbuAs8D glsqSy+qK8U6wvzuE6PD7N2vO87zyGIJ2BXamxWej6v3g3/aq1eSGpcsl0RlflT/3oVU BTbpycvjwKWXGOq6+3KkbFd5MSah3zHxZBlG9YbKLES+VGHLh5Zi+hxHcCUKDRkAu+tq 3WsbVZQuF+kWkrvhWsyDO5tftS9y9TjYTjIWcN8quHTfyu9jQmKFgHV4xJ+BxJo21Fn8 EP4lth+T5siAxU5BOet7UBK+K6vq4jIQ3koMZlI8lk1ntnz9LkulS+f4gEF6E/w1IHoc dnGw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T6iaxC07; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-202616-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202616-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a697d84bf06si134216566b.895.2024.06.05.06.19.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 06:19:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202616-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T6iaxC07; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-202616-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202616-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E91441F26BF2 for ; Wed, 5 Jun 2024 13:14:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F54919645A; Wed, 5 Jun 2024 12:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T6iaxC07" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A45196454 for ; Wed, 5 Jun 2024 12:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717590861; cv=none; b=lGg5ck84/9rfYR3/SMpWBwBaRbvI5AMMchp3uefiaSF+u+NAnXUz8WshoTqAIhh6G5AtCMj1/JuP+gmjHAU9dgS8Q5ImtCOXtGsl2YWwy97xuyv7mIkkWnSfkewiWGMD86Dz7+4jgu/Cy60XSPyEOkSA+WrkQiR0cXAgX0N7Zzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717590861; c=relaxed/simple; bh=cw4QG8ZuM3rLgISrTwKm/LFKjF4GZV19pyCzD0g8r1c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SfnfuDIgopeBuP5xp8vzud2N+ACPO1KmzILxD1Iw90NIu9GE1CUAFZATdKNhwi3cE2g29Y9QZsOpzle2FLKOh1ojgvKMnQUxAd5skin8YwxVFxFqb8QpcMPgbh1lXp9zUBm1WPn9tZok+TadV1DitSSxUSF/8MlWvgT3d28gG3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T6iaxC07; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717590858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BPo+1b9cy3Fmv+y1xRUSrrj3UDFxCnljcz5ROjfBrrU=; b=T6iaxC07i2I2EpkyPYMUqry9HQkN+CVWFONPWw8+KI7TdkdoXTy0cwOiCHoyW5NJD7v6bI hOxkkZUvTyrGubaMWrxv5nB9CjfHYoMX0gZOGnjUEdLc3IcXvJq2x5ceaIqDbA+rvzGJWf 9rj0kT7by6MqIBo0xXiCXrQkmStXV/M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-sE0i9_G5OOGhwZiRmhM7xg-1; Wed, 05 Jun 2024 08:34:17 -0400 X-MC-Unique: sE0i9_G5OOGhwZiRmhM7xg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4212a4bb9d7so52916985e9.1 for ; Wed, 05 Jun 2024 05:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717590856; x=1718195656; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BPo+1b9cy3Fmv+y1xRUSrrj3UDFxCnljcz5ROjfBrrU=; b=toKdmyqAFiVSzR1v0ixQja1o9zUOzrR3YtD6Fa8xt+cyvBceLlwEPbwkXTRP0i6aHw 2uWSXYv9zPqkYuf5KhXYMgZzyV2RqrCcnTsEoPskOrgFkutcbeSey0ctArhUKcTurRgg oJ8c17UeelIhu3D987Cfq6TpU/vXATGxGW/SK2xvLr1ohnen4TrhHqwqOarGOEFKqRqZ P/hOHqFUB9EeNIxh+EgG6jZZEZpQ8LGZief37JcyVPc5+30DZz9sEPhRCCjKHBCpkhIv MzLa0iHR121JXzM9lfWP3O0n6goeKY+Y+RHYeMZuByXP4rqxG0M/3udhWe/UzZOXRJag p0uA== X-Forwarded-Encrypted: i=1; AJvYcCVqIL140xCCerVZBb4cjXwrfuBSv5Gp37j4ccD3DWoKex8UJoBN2NFQX672eWvF5pqjJ+CaSGxTb8iP1zHPzRdpMgSUW1QveiqjJ2nL X-Gm-Message-State: AOJu0Ywxcne8AcfmST8v0V4PGz9a3mvPGSuSUd6R35tB1layUIiAYPu9 WZwcJ0fF0fnEMUI8djsMkyOyL9827bKp1yU4ib+cbJlrlvmj6+Pt5pKQVl7cTLwCM3wrRxO/WyS 50wvPFGZmvt3pSf5Db4YpLGHJobIgjY7IE/9hS/+iqpSrN8eurRw2aRbP2UVhNQ== X-Received: by 2002:a5d:6d85:0:b0:355:4cb:5048 with SMTP id ffacd0b85a97d-35e8ef94a02mr2377445f8f.43.1717590856295; Wed, 05 Jun 2024 05:34:16 -0700 (PDT) X-Received: by 2002:a5d:6d85:0:b0:355:4cb:5048 with SMTP id ffacd0b85a97d-35e8ef94a02mr2377413f8f.43.1717590855884; Wed, 05 Jun 2024 05:34:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:3100:19a8:d898:8e69:6aff? (p200300cbc706310019a8d8988e696aff.dip0.t-ipconnect.de. [2003:cb:c706:3100:19a8:d898:8e69:6aff]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35e5985c269sm9077036f8f.82.2024.06.05.05.34.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 05:34:15 -0700 (PDT) Message-ID: Date: Wed, 5 Jun 2024 14:34:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] mm/rmap: remove duplicated exit code in pagewalk loop To: Lance Yang , akpm@linux-foundation.org Cc: willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240521040244.48760-1-ioworker0@gmail.com> <20240521040244.48760-2-ioworker0@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240521040244.48760-2-ioworker0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.05.24 06:02, Lance Yang wrote: > Introduce the labels walk_done and walk_done_err as exit points to > eliminate duplicated exit code in the pagewalk loop. > > Reviewed-by: Zi Yan > Reviewed-by: Baolin Wang > Signed-off-by: Lance Yang > --- Sorry for the late review Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb