Date: Tue, 5 Feb 2008 17:09:13 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jiri Kosina <jkosina@suse.cz>, kernel list <linux-kernel@vger.kernel.org>,
       Abel Bernabeu <abel.bernabeu@gmail.com>,
       Hugh Dickins <hugh@veritas.com>, Arjan van de Ven <arjan@infradead.org>
Subject: Re: brk randomization breaks columns
Message-ID: <20080205160913.GB28812@elte.hu>
References: <20080204122837.GA1647@elf.ucw.cz> <Pine.LNX.4.64.0802050242440.30873@twin.jikos.cz> <20080205160214.GD24331@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080205160214.GD24331@elf.ucw.cz>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1042
Lines: 29


* Pavel Machek <pavel@ucw.cz> wrote:

> > From: Jiri Kosina <jkosina@suse.cz>
> > 
> > brk: check the lower bound properly
> > 
> > There is a check in sys_brk(), that tries to make sure that we do not 
> > underflow the area that is dedicated to brk heap.
> > 
> > The check is however wrong, as it assumes that brk area starts immediately 
> > after the end of the code (+bss), which is wrong for example in 
> > environments with randomized brk start. The proper way is to check whether 
> > the address is not below the start_brk address.
> > 
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> ACK.

actually, does the patch above from Jiri solve the problem with your 11 
year old binaries too? (Sorry if it has been mentioned elsewhere, i 
could not decode it from this thread.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/