Received-SPF: pass (google.com: domain of linux-kernel+bounces-202703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 5 Jun 2024 09:33:11 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrii Nakryiko <andrii@kernel.org>, linux-fsdevel@vger.kernel.org,
        brauner@kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        gregkh@linuxfoundation.org, linux-mm@kvack.org, surenb@google.com,
        rppt@kernel.org
Subject: Re: [PATCH v3 1/9] mm: add find_vma()-like API but RCU protected and
 taking VMA lock
Message-ID: <uevtozlryyqw5vj2duuzowupknfynmreruiw6m7bcxryjppqpm@7g766emooxfh>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Matthew Wilcox <willy@infradead.org>, Andrii Nakryiko <andrii@kernel.org>, 
	linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, 
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, 
	gregkh@linuxfoundation.org, linux-mm@kvack.org, surenb@google.com, rppt@kernel.org
References: <20240605002459.4091285-1-andrii@kernel.org>
 <20240605002459.4091285-2-andrii@kernel.org>
 <Zl-38XrUw9entlFR@casper.infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zl-38XrUw9entlFR@casper.infradead.org>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?jZ4pqBDbmrNSuEZrupprMVJrggg0aukxnrgnAkQV1q0sUrAH8WYov0ruZXF/?=
 =?us-ascii?Q?9SYUK0ecJ+3NlpcRlei7190f+ZKSq0UKMbckYu/oRLYs3z/P0x4RDnPyxh5A?=
 =?us-ascii?Q?/xWGU7UTswn+9m1lhZEwrmEHb4w8DCQ8TxgeauMwBMrn7Otl1ObCgBtRh8gt?=
 =?us-ascii?Q?ujwoimCB5YL+r3lcnUrQOM0Q8lyLNCT7l9eOAs3PqXTUNz8IayjIwJCPCrMp?=
 =?us-ascii?Q?Guy/KFnWgX8TyLkEZEUXl6Nt9Ic9UCXfmFVTs4Id9OARwG0zco+NUzSZlndI?=
 =?us-ascii?Q?+mZ2rPNc6mlpqs/i07QMDlyySOxYfB5D7XybVzk1mCoI1oTb655B0rrZ4O7C?=
 =?us-ascii?Q?eqJnfcoUV4wjw9UWAasZ1hKNVGg8vKfc9gmmmE0jFWasi9TwyOzkgILGiXfu?=
 =?us-ascii?Q?113t57iGC4cMX4/T+eBFftkN2XqSucvQB8qXu0bOAkAxNV7CHwyjUPhY9/gJ?=
 =?us-ascii?Q?pJY9APTsIWexvTBXKsrEbgW6KrbNrDbHYvI9ggkkij2kKHKD8elsOqNHhgjT?=
 =?us-ascii?Q?kFyTc1j50cvrQqy7JeqANbESC0CsJlnK4KDPpCzunsx55B7yZISsixFI6cS4?=
 =?us-ascii?Q?aNm6NNwjDGOS3Tcbh50RXiKJv+PFNE8+4VVMVoy45wRiJTm/VnhnZuvowtOB?=
 =?us-ascii?Q?clryitocY1lzM30o0tGzy9M/ZQqbbB5oz/b2QeJU7HM9XbWY3l+kxlA1491i?=
 =?us-ascii?Q?F6OjCDQP+xG7e5rtlO3QPWNqrQbydfOoeVuPIwR4qozaQ0eXQf38r+5cSRIF?=
 =?us-ascii?Q?nz1OPXlbxmKh5a0Ln+/wgjdCQViFnNba5X9r9QMEflNAibsJjlmqVxeXaEaK?=
 =?us-ascii?Q?ecjwoYM/k8zpdSynvRNAk5gawZnQZGZAy853tPmidnObVb6kdMEzRVc8MtYg?=
 =?us-ascii?Q?O6dziRMGHJXyqDgfZBHe4QL8q9mhrDK2hBGrprdkmWgP+7bz0cIUhDmzeW3c?=
 =?us-ascii?Q?HixfCNlui3C5WPe5FK67NZ0TwX8WF1HVdk7E3mICLGPZDQr9C9ImZBJ8zDGW?=
 =?us-ascii?Q?4UCyabcWKL26FaQ163iajblRzIjNBqs3WZIaTWBkZqv4F0uPfqLsBzbcvoWe?=
 =?us-ascii?Q?XxjKN/VJi8O1dXZF9u8SAtLnmyspeYZu3XRQ+c75Jc2SvIkZsh/imMCtKCxF?=
 =?us-ascii?Q?ZVjmEChO13dNVQ4jQeboXGiq9g9SHNt1Z4nPGFAtT/wUaBwR7Nl3LECxyjnS?=
 =?us-ascii?Q?M8C1An+OBReYRgcoqkU8wXxMpvlUnBmuIkg7z5g1UnLWqTZ7swkgIfGu9XDj?=
 =?us-ascii?Q?MgY4IgOzr8e0i7vPDY172UgIh56sMEyjH7afsR034L/He7/jpYsE78cRIaJ2?=
 =?us-ascii?Q?J96ctg/zdALCeLu3055OtbVq2WIMOl0Co7GmOeCY70g361nlEZBRQqpHwHOC?=
 =?us-ascii?Q?8qv8ssSIXu5KCoROD8+9qnUNvvjxVcmt0ih5n+uzzrnbvpGILS2Toud3qjHy?=
 =?us-ascii?Q?vGdXaNWV4icSlBWbSXPwOnkJXBFfuODPI9lje9i55yejQlqBYkHu6q0gJ1Ry?=
 =?us-ascii?Q?mNSBUD25jFh1U9MuV/blqb7QM28Xg7l4nJCHRRtirDVXkiWUU9ZYNKbybXTD?=
 =?us-ascii?Q?GGOeji3X17u5e0OCKbLnG58vg5WLzHhMtnXYnVnx?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	RdseA8tqikVsoPwCQFpEu/FVOSXBOiRS/KLrW3iDmQ/xCU1rZFu8OmBTiuOjCl6fhYy99kSys23Fa+HpwHtRLCJrEAYuvCbYTLJqgeDxkmkfH+PH/Dq7VU0yRhBliweF7U2246PEI1wVi5E56pUH5DzJ1Wsl0Q4Kv0EA9azgu0f4v2ugn3e0ZomF4jM3k8TObXB0YB4Ae35xNPEJ4RMoQ8uHGydU1nec8Ml+AJPfvf5AXdlSSnJedEC88+7R7+6KgctC7Z233tPKdHGwt6yytffOIm2sBBg2wY3go4dS6R4gQAfyezRJqy/yBTOs8xm+xLmhajrKLMvH8Saznhfe3Y8vg114fAWI9dlyYZg4hcnucT8W4CA1swtzDf2drHRs3/fq5bxLpeU1Rc424AcBwCRmIpEtx4Cr08sIUQKcFUPFV7Q4tJxiOnOIUQM4uBkGwPrWM7q6Cdix1C2pkOKvBrsDgtGe1+/QtFMK4ttZd+Jded6tmBcjUb8VwyfDE7HmYak353dx1yHKZnBQuDR4XcGPjZrO6S0IfaHoTMCfdyQJJJXYKIyr5shsStPQYKnHMq8ySqf163AyCaSWAEKr8bc/Hayl+rxX0En5/uaJHxE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f189a4f-580f-4abf-98ba-08dc85640cf8
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 13:33:14.2005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8CS2r8LEcz2n6mzx7jJn4nwmhNO4VoHE8t+vvs/0DmiyTvyLv9RHlD+1z1IrfrQ2sUG0TdxUEO5Y16tU6XS2aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7237
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-05_02,2024-06-05_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406050103
X-Proofpoint-ORIG-GUID: _xDbVosOgI0n7LHRiGBhfu3iVysb22s_
X-Proofpoint-GUID: _xDbVosOgI0n7LHRiGBhfu3iVysb22s_

* Matthew Wilcox <willy@infradead.org> [240604 20:57]:
> On Tue, Jun 04, 2024 at 05:24:46PM -0700, Andrii Nakryiko wrote:
> > +/*
> > + * find_and_lock_vma_rcu() - Find and lock the VMA for a given address, or the
> > + * next VMA. Search is done under RCU protection, without taking or assuming
> > + * mmap_lock. Returned VMA is guaranteed to be stable and not isolated.
> 
> You know this is supposed to be the _short_ description, right?
> Three lines is way too long.  The full description goes between the
> arguments and the Return: line.
> 
> > + * @mm: The mm_struct to check
> > + * @addr: The address
> > + *
> > + * Returns: The VMA associated with addr, or the next VMA.
> > + * May return %NULL in the case of no VMA at addr or above.
> > + * If the VMA is being modified and can't be locked, -EBUSY is returned.
> > + */
> > +struct vm_area_struct *find_and_lock_vma_rcu(struct mm_struct *mm,
> > +					     unsigned long address)
> > +{
> > +	MA_STATE(mas, &mm->mm_mt, address, address);
> > +	struct vm_area_struct *vma;
> > +	int err;
> > +
> > +	rcu_read_lock();
> > +retry:
> > +	vma = mas_find(&mas, ULONG_MAX);
> > +	if (!vma) {
> > +		err = 0; /* no VMA, return NULL */
> > +		goto inval;
> > +	}
> > +
> > +	if (!vma_start_read(vma)) {
> > +		err = -EBUSY;
> > +		goto inval;
> > +	}
> > +
> > +	/*
> > +	 * Check since vm_start/vm_end might change before we lock the VMA.
> > +	 * Note, unlike lock_vma_under_rcu() we are searching for VMA covering
> > +	 * address or the next one, so we only make sure VMA wasn't updated to
> > +	 * end before the address.
> > +	 */
> > +	if (unlikely(vma->vm_end <= address)) {
> > +		err = -EBUSY;
> > +		goto inval_end_read;
> > +	}
> > +
> > +	/* Check if the VMA got isolated after we found it */
> > +	if (vma->detached) {
> > +		vma_end_read(vma);
> > +		count_vm_vma_lock_event(VMA_LOCK_MISS);
> > +		/* The area was replaced with another one */
> 
> Surely you need to mas_reset() before you goto retry?

Probably more than that.  We've found and may have adjusted the
index/last; we should reconfigure the maple state.  You should probably
use mas_set(), which will reset the maple state and set the index and
long to address.


> 
> > +		goto retry;
> > +	}
>