Received-SPF: pass (google.com: domain of linux-kernel+bounces-202760-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1d9e1530-be63-4374-b952-e12b15cee9d3@quicinc.com>
Date: Wed, 5 Jun 2024 07:10:14 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] RAS/AMD/ATL: add missing MODULE_DESCRIPTION() macro
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
CC: Yazen Ghannam <Yazen.Ghannam@amd.com>, Tony Luck <tony.luck@intel.com>,
        <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
References: <20240604-md-ras-amd-atl-v1-1-d4eb3cf3abe4@quicinc.com>
 <20240605094051.GDZmAyo1-j_uBri_YO@fat_crate.local>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240605094051.GDZmAyo1-j_uBri_YO@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 6/5/2024 2:40 AM, Borislav Petkov wrote:
> Btw, I'd suggest instead of sending those piecemeal-wise, one per
> driver, just group them all by subsystem and whatnot so that each
> maintainer can pick it up and this new thing modpost decided to complain
> about, can be taken care of without noodling through each driver
> one-by-one.
> 
> Better yet: do a coccinelle patch and convert the whole tree.

I actually did use a simple script to do a conversion locally, but the hard
part is determining what text to use for the description. So my local
conversion just added:
MODULE_DESCRIPTION("TBD");

Then, on a per-directory basis, I look at documentation in the .c files and
the Kconfig to replace the TBD with an appropriate description. And I then
create patches for that directory based upon MAINTAINERS entries.

This was the only file in drivers/ras that had an issue.

In drivers/hid there were a large number of issues.
Some of the files had specific MAINTAINERS entries so I sent them separately:
https://lore.kernel.org/all/20240604-md-hid-letsketch-v1-1-ff38ae7b4cb0@quicinc.com/
https://lore.kernel.org/all/20240604-md-hid-lg-g15-v1-1-265b094db089@quicinc.com/
https://lore.kernel.org/all/20240604-md-hid-logitech-dj-v1-1-560f6b3cb54b@quicinc.com/
https://lore.kernel.org/all/20240603-md-hid-logitech-hidpp-v1-1-060f06e4529f@quicinc.com/

I then sent a large patch for all of the remaining drivers/hid patches:
https://lore.kernel.org/all/20240604-md-hid-misc-v1-1-4f9560796f3c@quicinc.com/