Received-SPF: pass (google.com: domain of linux-kernel+bounces-202730-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7a7c2f41-1608-4348-9183-d99aaa51398e@amd.com>
Date: Wed, 5 Jun 2024 09:41:51 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, Guenter Roeck <linux@roeck-us.net>,
 x86@kernel.org, Mario Limonciello <mario.limonciello@amd.com>,
 linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 3/8] hwmon: (k10temp) Check return value of
 amd_smn_read()
To: Borislav Petkov <bp@alien8.de>
References: <20240523-fix-smn-bad-read-v3-0-aa44c622de39@amd.com>
 <20240523-fix-smn-bad-read-v3-3-aa44c622de39@amd.com>
 <20240605122012.GXZmBX_KFQArXB9Lar@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240605122012.GXZmBX_KFQArXB9Lar@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y291TTJ6bDVzeXpKcEFyT0xXM1lxMVRXZUkwSkl5Qk5EZFZqYzJ1N25jbEw3?=
 =?utf-8?B?OVd6dFF1bllKeWRHQmFLS0YxazVqckIwUEZ5UUJwNlJuMFlqeURGVjd5OGF1?=
 =?utf-8?B?WGVSOWZnd09jTlRVSTZWMnNUS0Rsb2gvcFNseXB3TWU4SlJjM3RMOXM4L09z?=
 =?utf-8?B?dEFZT3pVVEE3bHR6VU83S3lRMEMyR3NtWERiRVNqR3ZEYkpKNEd4Unc4NVFu?=
 =?utf-8?B?Zkp1dXU2bExYMFdIS3gydlQ1TG9KaGRDRWJFbCt5Qy9NcncrVUVjRVMvMnZ5?=
 =?utf-8?B?V0hCZW9PYWxFS3I3aEJPUzA5QkkvbVorNGt5eTQvRWZzSE14aGdjY0RJbjBU?=
 =?utf-8?B?SkRaUVEzK0hxZTQ4Q2s5T1ZUUWlMdjFIOUNYN0JiRUUyMzZwZUJjT21iWWxL?=
 =?utf-8?B?RkZHcWVmRU56My9saTV2TlNVbUp4SkE1Vis3L0cxMlJpYnpJMjdkb3locjlB?=
 =?utf-8?B?Uyt4N3RKUE5ZZzJaeDhaUDh4VWIvZGkrbnBzYUJ2OHRKVmpmMkdESGpjZysy?=
 =?utf-8?B?eXFFRXlIK1FFMGc3cTVmTnBnSkZaUVoyYllTOGxHWGlOMC9rQXB3cjNuQjV4?=
 =?utf-8?B?dWJXZnFQODFySmxBVjR4RG5FbCtMdmIrYTVSMndXdkp3eE02TEF4Tkd5dmhZ?=
 =?utf-8?B?eE9ZSTZUQ0FkdUZlRkx6dndvUEtxU3NFVDZ4K1dFU2twVWdqNzJmQTF6aHRh?=
 =?utf-8?B?U1hCQ2pqYmlxd0l0c05mRWFFRzQyVUVFZ3R2MDYzSWlmaHRvNk5BVnF4VUM0?=
 =?utf-8?B?K0tFeUhBRDhBcnFxRk9Xb3pwRk8xbmRHZFVhZG42enpyZUNka2FFOG9JQStW?=
 =?utf-8?B?VnAxeHh3aGNVSVlMNEdpWkhyZXFVdEJYcHVidFRXSm5EWUdLRVo1WEFybmJG?=
 =?utf-8?B?bVRwR3pPNWN1RjFXeFRFcUVaZG9rcGQvMnprdHpoak9wSThVU3VJcjJYSnYz?=
 =?utf-8?B?N29UZUZiaHVGYXBaT2JCQ1JzaXdHZ0dxM3F1L0J5Wm84eWNxcmRiTEFmeXNZ?=
 =?utf-8?B?cWw4R2I4Z3JVL0p6NElwVGhQem1SK2c3L1pzZWc1Nmc3bDJIelI0b09odG90?=
 =?utf-8?B?OFRwQlI0QXp6aTZZblhOT242VENVQnplL3hRNVpQUXlIVGlnV2VaY3NlYVVE?=
 =?utf-8?B?Yy9KcDdzbWY1Q0N1UVJuLzNhRTMrNUNaYkNveDRxWXZoRWJqZmFUNDAxVDZV?=
 =?utf-8?B?TzZmOG55TlR4UUxhL0ZUSzI3OTd1M0ZrVFJsKys0eFcrZ1VMN055cnMxWjNP?=
 =?utf-8?B?cTQ0THE4NGw3VVdqNkZwa3NuaWEyMnlWV0J4OG1rTUVyMHlWakx3QlkzZkx4?=
 =?utf-8?B?Wkx1SGRaVlIvRHhrTVJzRG12czBiK3hUWUhWRGxicUFHTDcxVWlEcUxpdjgr?=
 =?utf-8?B?djlpMDN4c2lyQzF3QWdGTzdDcmZmUEZNNDhTOTVUdm43aWJmSm9TcisxSzRM?=
 =?utf-8?B?cmtVckd2TDg1ajhqdXVBNFlHSXdHbnBQNk5LZnVXK1Nzc2ZjSjdpZU10ejhH?=
 =?utf-8?B?NmQxT2dJeDBHWUcvUlVCYmpWWGQvR2dqVlgrVTdqS09EK0VaVHNwdEdVNm1o?=
 =?utf-8?B?czBQem1URG5Ec1NGOWRDeUVJd1ZSNlVwZU4xVWl1ZlROMnN3YlE5eEs3WmpH?=
 =?utf-8?B?Ym1DUjRPU1huU1FzZjgwTGFkeDNKaGd1WWx1L1lZMTYyb1QwWW16Y3I4SEll?=
 =?utf-8?B?ZVhFTjZCZHZ3MHNOdkZ1UHlnNXpSbXJDSkE3cGl1TExpMUtsc01rdUxUTEph?=
 =?utf-8?B?RWphQlVxa3B5Z0xDSnl3ZEVqR0doamdlOHUrYy9adlJHZlZDeGlDUm40ak1k?=
 =?utf-8?B?LzJMeW0yZmN3Nk9OVE9LL0EyalBMV0tBcGFPb0doaDlQdEkxUDdTUmF5RCtu?=
 =?utf-8?B?RWxmNmVKbEZDclNpajljU0xHWUVFbFNCQkFRMGg5b1l4d3Z6NElKNXh1NzBr?=
 =?utf-8?B?RkxwQ3dkSEJsdXcrR3lLT1crY2IvelNMOGZmblVYQnE3Rlh3NG82bTZ1NEE3?=
 =?utf-8?B?aXVTS1NBUGhGRjFJQXROem9SaFBuVmV3ZEdOa3JIejhVUWFFckpoSkpXNlZZ?=
 =?utf-8?B?UUFzQ3lnU0UrUHF4aHp2U1JtaHZyRWphWFpTMXJzWDdmVWRTY0lmMlhMWGpL?=
 =?utf-8?Q?HFIMcviZCTZ6C1b02KUFzv5AI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9878620-6945-412a-3ff2-08dc856542ab
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 13:41:53.8140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i2RHmfTxotNftKOquRIcU6CJSV1/pL3QSllgXgXeyKizIPXvQtRYmcM/I4MH4RtuW2Imoqmkt9Y98kznHIndyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6439

On 6/5/24 8:20 AM, Borislav Petkov wrote:
> On Thu, May 23, 2024 at 01:26:54PM -0500, Yazen Ghannam wrote:
>> Cc: stable@vger.kernel.org
> 
> So yeah, I'll drop the CC:stable tagging in all patches unless we're
> talking about a concrete issue. You need to think about the downstream,
> distro folks who need to go through gazillion of patches and wonder
> whether they really need to backport them.
> 
> And I don't think misusing the stable process like that is the right
> way.
>

I agree that patches 1-3 are not stable-worthy on their own. But I think
patch 4 is, and it requires 1-3 to avoid build errors.

Is there a preferred way to highlight this while patches are in review?

Thanks,
Yazen