Received-SPF: pass (google.com: domain of linux-kernel+bounces-202776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5faec5de-fc36-4b38-abcb-c61954a824cd@web.de>
Date: Wed, 5 Jun 2024 16:30:30 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: linux-leds@vger.kernel.org, Abdel Alkuor <alkuor@gmail.com>,
 Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] leds: ncp5623: Use common error handling code in
 ncp5623_probe()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:AdsUg9cqJ0o=;KHrT9osVuRknSYLeFse7SxoDWM5
 3Qwwwf9wx+xLZ+Vw1C1hJ4zYyAk4RXIgAZ75UMLQXl7GWOm0r2P38yoo7I747tnKDSl2MKwDe
 rq5Ex8mnOht5lqpFiLE1B/+bS5AAo/A1XaNEsDmD21oLXPbWs9VsLQmJc1nb+xeFSnUE9ChUH
 QjAviQ1Kiy83++eFGGNwa+fjRThsrtHf3/AtYu+QVwx9/u/KIyu/wZyQ931H/6V2tgyZhGKPK
 svLXshr2oeC3Dia70rCzo18vJug0dbgY7RBhGkgbqre+FqLRdqn1Q3RgNtH1Pw4HIA82q2ZpY
 I198t5XcS4bQdIDzdB/ay+EZbIr6+GpSCCdEr38wI7WZmh6tvWo7Wwlk45iv2KEgUI7hYX09f
 +aeDG6bE5se3mq7UoxdZgdgaMTGAYoc1+SDKUxCgIC4ibRoNv60WWeSX6qFnHIo6Vql168lv/
 tGX6BtSdB1z5UZHryVTJ+VqC+h1urIGu1oq+bm8DsRLk5X2uqa3NNaRybY7hfPKbgvCFJxJKd
 Zji75ESHeTlf/t14OGZG4YxInxClexGAhAVUwSFa/AZjFbwa0xkMVQnVFhIEJNnjAvpyUoiZc
 AI3973Ixqh8vqHzacYo2rxPDj+bqJAO50PBZsO0n/jj7N5DqW7R++8cBTu9jtDUJ6inaRrid0
 9CuvqTlb+5sFRXEzzgPegoCLSYWZKFLvb12Ge/sUWE8XptYaBVUcD0JSrn73uKc5xQ78Dwvkl
 j8fGwdd+eZTxOuO3pV1elxdpZywrvvwQzug3cDiTk52OQojrostspg0HPuuCHCe34vG+Qp0cu
 VDQUQ/RLlSIRDqki9+1QN371F8p1YXsguuY+PgTDf77DA=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 5 Jun 2024 16:19:26 +0200

Add a label so that a bit of exception handling can be better reused
at the end of this function implementation.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/leds/rgb/leds-ncp5623.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/leds/rgb/leds-ncp5623.c b/drivers/leds/rgb/leds-ncp56=
23.c
index 2be4ff918516..f18156683375 100644
=2D-- a/drivers/leds/rgb/leds-ncp5623.c
+++ b/drivers/leds/rgb/leds-ncp5623.c
@@ -183,16 +183,12 @@ static int ncp5623_probe(struct i2c_client *client)

 	fwnode_for_each_available_child_node(mc_node, led_node) {
 		ret =3D fwnode_property_read_u32(led_node, "color", &color_index);
-		if (ret) {
-			fwnode_handle_put(led_node);
-			goto release_mc_node;
-		}
+		if (ret)
+			goto release_led_node;

 		ret =3D fwnode_property_read_u32(led_node, "reg", &reg);
-		if (ret) {
-			fwnode_handle_put(led_node);
-			goto release_mc_node;
-		}
+		if (ret)
+			goto release_led_node;

 		subled_info[ncp->mc_dev.num_colors].channel =3D reg;
 		subled_info[ncp->mc_dev.num_colors++].color_index =3D color_index;
@@ -223,6 +219,10 @@ static int ncp5623_probe(struct i2c_client *client)
 	fwnode_handle_put(mc_node);

 	return ret;
+
+release_led_node:
+	fwnode_handle_put(led_node);
+	goto release_mc_node;
 }

 static void ncp5623_remove(struct i2c_client *client)
=2D-
2.45.1