Received-SPF: pass (google.com: domain of linux-kernel+bounces-202765-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 5 Jun 2024 10:18:32 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami
 Hiramatsu <mhiramat@kernel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@efficios.com>, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/5] ftrace: Comment __ftrace_hash_rec_update() and make
 filter_hash bool
Message-ID: <20240605101832.09fb4211@gandalf.local.home>
In-Reply-To: <ZmA6ygUWNPkq0PKV@J2N7QTR9R3>
References: <20240604212817.384103202@goodmis.org>
	<20240604212854.725383717@goodmis.org>
	<ZmA6ygUWNPkq0PKV@J2N7QTR9R3>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 5 Jun 2024 11:15:38 +0100
Mark Rutland <mark.rutland@arm.com> wrote:
> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> > index 9dcdefe9d1aa..93c7c5fd4249 100644
> > --- a/kernel/trace/ftrace.c
> > +++ b/kernel/trace/ftrace.c
> > @@ -1701,8 +1701,20 @@ static bool skip_record(struct dyn_ftrace *rec)
> >  		!(rec->flags & FTRACE_FL_ENABLED);
> >  }
> >  
> > +/*
> > + * This is the main engine to the ftrace updates.
> > + *
> > + * It will iterate through all the available ftrace functions
> > + * (the ones that ftrace can have callbacks to) and set the flags
> > + * to the associated dyn_ftrace records.  
> 
> I beleive s/to/in/ here, to make this one of:
> 
> 	set the flags in the associated dyn_ftrace records.
> 
> ... rather than:
> 
> 	set the flags to the associated dyn_ftrace records.

Thanks. It's good to get a "native English speaker" response ;-)

> 
> > + *
> > + * @filter_hash: True if for the filter hash is udpated, false for the
> > + *               notrace hash  
> 
> Typo: s/udpated/updated/
> 
> ... though I couldn't parse this regardless; maybe:
> 
> 	@filter_hash: true to update the filter hash, false to update
> 		      the notrace hash

Sure.

-- Steve

> 
> Mark.
> 
> > + * @inc: True to add this hash, false to remove it (increment the
> > + *       recorder counters or decrement them).
> > + */
> >  static bool __ftrace_hash_rec_update(struct ftrace_ops *ops,
> > -				     int filter_hash,
> > +				     bool filter_hash,
> >  				     bool inc)
> >  {
> >  	struct ftrace_hash *hash;
> > -- 
> > 2.43.0
> > 
> >