Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp349087lqr; Wed, 5 Jun 2024 07:54:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV5ZskTfKE9WNXrndacKAnXr4bHDC1ZZ6fHCMwJE+0FbSyq9jAwSNwCzTY2UsmjUofh+/RoaQi0m8eTAZdF5EQ+Bh7GMr3C7Q5nCQK95g== X-Google-Smtp-Source: AGHT+IH+Glg87RO3oiVeQCbZY0qvDxjqDDAJT9Np2eB2K97/wm/icZ7oT3mNscdup/QA9sdKnVdl X-Received: by 2002:a05:6a20:12d2:b0:1b1:ebf2:d767 with SMTP id adf61e73a8af0-1b2b710b968mr3327385637.43.1717599265338; Wed, 05 Jun 2024 07:54:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717599265; cv=pass; d=google.com; s=arc-20160816; b=tvAm8GyLFHCc8Y68R3KUHFgKBwUFFM0rzLiHIpecw7oRz7TZl6FbzDyuPwGCPvROUx YkHXXBDjrA5sL++umEcM/rLGj/sSIU7tUQ3Gg3HpsLDi7vUELxOV0wgfj/3ETx0uO043 Byy4pTiyTX3Te8g5UZsNpp3w9uLCGg+6tQdBuFOcKzeOuhf7+lGXqv49jBLaiycpnuRB N7nFNK1u4Xx03ovpw4ZV+9lxO0rEVZSMyJr25Ba8slTfazz21qRkK+fcY7KiIIHJlk+P T4wCReXBkXf0rhqEVOyVKpP1HnReY80Ab1vTd2sJSB/O4eQcG7VVtWVho5VveN3BVvDB C9Vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=SnAjRPdPslLKR6RQzu2pBmXnTD4p4gc93G0q5GXgtK8=; fh=chDqJQHG9UAcIApVymfCO+4iQUsdzLgVnr3hN3vGQ38=; b=rNB9Q6hnvgRIh36BOdDBxO35ymlYBAuJtd1Fx/HPajyOC2jqGXO9vFEwaIuv3NHg/c hmNfToa2iQxaFTpDmoI9ynK9YoNQBt9wiQH6i3timPkeAGi407EsU9QfRboLMoceheVB 0KeA2E2nWqc+KeCnmslZK25FmktcqsS4rRJVQ3xOaZUShHqEE9u7h2exZC0Va4eEKuDd +E+KTglBH/5s1scRGAp8sfClEPYfHx2iDZXbVzAZqxHl2AAXKNwMvBjg2tQ9Xsfv8/hq ksmvHTAy9/87vHmZLEnvPogg5ex0A/f9Ezrkgm0qTTyPgT/0ucRkM6ivbMf5e6HeL720 py1A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GYgF/4W3"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-202752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202752-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-70242e673d4si2682741b3a.398.2024.06.05.07.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 07:54:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GYgF/4W3"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-202752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202752-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C5A0AB2580D for ; Wed, 5 Jun 2024 14:05:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EB9315E8C; Wed, 5 Jun 2024 14:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GYgF/4W3" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1F710A1E for ; Wed, 5 Jun 2024 14:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717596331; cv=none; b=Op1bQMTvcCX14T7WRuFe9l78JrV5PBQ1S4oTjuWjZl5BLtFAauakyncBxLehJKJaTAK+THD3mPZXydGcScE/PjZhwO306Nd2H+OFXwnfEqYwDD3clyAASxGT0IOCTEYA1d+xSOBDkm0NQ78RRYYmLryZRBwedklHY0O/3NaGc8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717596331; c=relaxed/simple; bh=J2kQ4wQoNvDj4NE3mHtx5/BMuZd20qs1tyhxegM305Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E4fVrfG3hWtcazvyem/Sc0ZxBJYZ0FR5yGh8K59KKgZlPS6rOBaLKdn2qyonxRXO3tzrOLmaMwtC2RsHuzwXrVOtQUYiBwbu4e26WzvODYdjzuv6eYq0h6c/3GJ6tHZJ7knr6ISWyV/DRujkHx7SqRDKBoJBLPTSGRxnk7RIyn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GYgF/4W3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717596328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnAjRPdPslLKR6RQzu2pBmXnTD4p4gc93G0q5GXgtK8=; b=GYgF/4W3t6HhZMA7j0hbcgv6t0Q23+3SlQu9Z4TPWVl1WblnU1GdcuW7OuHPz2EzdlfbV5 gqna9P55slFr3XvJwIxdu0qr/revjtmRuTH1eqyKSvsH3WTbUDbrKTVV5hBW7a2WFed0u0 OwmIkggVpSbIsZiZrz95k7t9Ni1VJPw= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-hRzSkVHZN-apQgT_v0R6AQ-1; Wed, 05 Jun 2024 10:05:27 -0400 X-MC-Unique: hRzSkVHZN-apQgT_v0R6AQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52baa2e4ab1so1376961e87.0 for ; Wed, 05 Jun 2024 07:05:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717596325; x=1718201125; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SnAjRPdPslLKR6RQzu2pBmXnTD4p4gc93G0q5GXgtK8=; b=ZgJt86LVOt0UPF9IKZhs9Lk9CsBo3/DC4pqJIcMnTdc+26EwnSgEA75tDATuHHHTbu VH23zwdvhvuSSTnua52OYhQedGPkyee3uKUpdiZ5ny5C7dfCSFBnulJmJhaqBDvoWFv6 NG9Qw5yLLgnYH3Ue1I5vHLfP/YPsGNgq9K7ZUbb7GR2Kbnh04mF5FUdhMcfxDp6ONniv xB73pmlRVvGCr0Z7Ilg+i9OrbGUmBdJ2k5zEj6pxzAS1KBfOxKlHFjBQJ7+ExIAe8l+e +N5cExM+cfWrWiF2xzF4KCs7ZKb+9Psa2t0+Pyv5d6UU0DPjSyQ5IgO98kPJ2qmu3Lpr gXRA== X-Forwarded-Encrypted: i=1; AJvYcCU6kz5NQaXhW5cVVRCioXLACnBiOR/2Na4kRr6CY6FPeuRZvzg4mc01G6yuDv498wrgdKbvpSejKnYylvYL+2Qk6n6bRxBW98GUihOd X-Gm-Message-State: AOJu0Yys9UHxvBt1JBe6izv0ZOiD4xcynkGaskeeQqo8uYGiuPfq5535 NbwPKVc3HDsuiqv4dGd6WatzUouF0XSXpKJyKLUEC+0RfgKdTE/xad3k6YMdSD9CgnJ4Lv3XZca qazrKJkzSfjcUaOo0IC1l5UpsY3lbu/0GvGRUBQf6kgSPRqWxPYHE4q7Rqr4hqQ== X-Received: by 2002:a05:6512:3e5:b0:52b:4ae8:46d9 with SMTP id 2adb3069b0e04-52bab4ca6d4mr1891860e87.5.1717596325743; Wed, 05 Jun 2024 07:05:25 -0700 (PDT) X-Received: by 2002:a05:6512:3e5:b0:52b:4ae8:46d9 with SMTP id 2adb3069b0e04-52bab4ca6d4mr1891750e87.5.1717596321944; Wed, 05 Jun 2024 07:05:21 -0700 (PDT) Received: from [192.168.0.161] (host-79-23-6-148.retail.telecomitalia.it. [79.23.6.148]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a681c4f2b6fsm777163266b.144.2024.06.05.07.05.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 07:05:21 -0700 (PDT) Message-ID: <9f21c8e5-1103-44fa-82bd-cf608f8a96f6@redhat.com> Date: Wed, 5 Jun 2024 16:05:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() To: Sebastian Andrzej Siewior Cc: Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> Content-Language: en-US, pt-BR, it-IT From: Daniel Bristot de Oliveira In-Reply-To: <20240605093246.4h0kCR67@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/5/24 11:32, Sebastian Andrzej Siewior wrote: > On 2024-06-04 17:57:46 [+0200], Daniel Bristot de Oliveira wrote: >> On 6/4/24 16:42, Qais Yousef wrote: >>> - (wakeup_rt && !dl_task(p) && !rt_task(p)) || >>> + (wakeup_rt && !realtime_task(p)) || >> >> I do not like bikeshedding, and no hard feelings... >> >> But rt is a shortened version of realtime, and so it is making *it less* >> clear that we also have DL here. > > Can SCHED_DL be considered a real-time scheduling class as in opposite > to SCHED_BATCH for instance? Due to its requirements it fits for a real > time scheduling class, right? > And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. It is a real-time scheduler, but the problem is that FIFO and RR are in rt.c and they are called the "realtime" ones, so they are the first to come in mind. -- Daniel >> -- Daniel > > Sebastian >