Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp359827lqr; Wed, 5 Jun 2024 08:08:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVBMhdR4was+d+DrYi0pGKT/diXkpAa2COsy1R5JK85rfVoXvNiOZsPGMz1q15EpX6JGxrXu75FYAY7v8eVYvlNsC54RRjPE+xKGkpTxQ== X-Google-Smtp-Source: AGHT+IEfoBwwzNo751ZCVvW3GivF5zAXHGY4hUR9q6H4LGKaCkWKl6tM6dpaXqH2D7pC8WlGgfXl X-Received: by 2002:a17:907:7655:b0:a68:faae:d287 with SMTP id a640c23a62f3a-a69a0268619mr173955966b.75.1717600132357; Wed, 05 Jun 2024 08:08:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717600132; cv=pass; d=google.com; s=arc-20160816; b=xpH+9k3HgzfaXXPWBz6oF1XAkDnVDN5ux+0uIqhSv6W+6F7NyJLnxr3i3DddVoJDt1 j69xxAEqx26Bb/m+Wihf3YAtFouCa9+K8l8TsMwHqh4FJn6a+9EKkHpS8HcsthIg+wuj 6tXLhn83L5Q3HRBIol9tZiapZsCHRfoN9tQMh7seL1jvw8xxjblJs6AwK/v5JwzG9ESK Ii2cwOjgqLEKJjLUknqLR7hloayYw5947Xy9gKJvxCyEXeA1Ac5xzYVX9nyxX/lyfyjq HeudEy8s1CjKdGuONEmUtXwMwPYrBueRWQmuxtqMhlt+caeZSqvbyG6YJ4wlogZ38vCu KlGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6erns6P7m66pg24yXk3vygFkTJngHmTZFzrZV+/TSUs=; fh=C2mbhFrWGD2/girAl4AqD4H/ge/oaFAUw2iMzJANT1g=; b=Njg/LldS4IQ5zAkz0FVNcIG/GS6CrY8vOCNw81awlmIAfrxCVnx2mOHUHQXtFRMlHR 9KortdSf41dGMAGtxbDKWD6mcWV71kaZepwMqaGRYR96jhIAACmKscHxFyPSA297tFLA o3yPwMyfqgoilhxs+OKHmYw4g/jFWNOJj9SzVQ7NHOrC+f8bAqDj3EHdOWcjJ+3HBvjf UnOQMlIjALFdg9KAyN0AShiXAkiu3FBzgV7hdl3qrk+QTUtqtBz9gU+8QXPd37ZVP2xw v8mSX3hU5ZJbIiSprT1aTvE6xjmfGjHinebjZG0txJasiCe8Onoburw3rRPXnAlVbd3e Ynrg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cV5Ulta7; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-202802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a690ff72c59si312262666b.10.2024.06.05.08.08.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 08:08:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cV5Ulta7; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-202802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C9E181F2212D for ; Wed, 5 Jun 2024 15:08:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AE473C482; Wed, 5 Jun 2024 15:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cV5Ulta7" Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABE93C488 for ; Wed, 5 Jun 2024 15:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717600122; cv=none; b=gCPZIrsBvTgVqjUOB7Y+0aerYML249xNh2rz/LFSh5q0XRKYx/SQFy1bi28B4Bcp2Ji/sgc2KRS0WyH4QFZouPkppzWrgIuMTByoEdPWo4rYxoX3ZRiWxF5SUW7cuH6b4C9VcjQkcRcn+tdyOxWO1MovPTAdDRSaP8Owg/M1aGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717600122; c=relaxed/simple; bh=R/9wivTDs3u96sEWdTwIGHy+6uzaOMjnC/KBbTF0rdg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dgLqSWbGA3zS1RqgY96gm11YsgQbFN8nQZeVHT3g3mfa2+rGlip47qQwg9vDt2vOBhna84kuEdnQxoCPf98NM0/hN102x6SCTPqgdNDMeZR4Q6/PMSHGzr6kApH26zKafh/TAB/c2h7UMLflRNriZRmln3ZNTECHaAnpG40EKCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cV5Ulta7; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4214f803606so17436845e9.0 for ; Wed, 05 Jun 2024 08:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717600118; x=1718204918; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6erns6P7m66pg24yXk3vygFkTJngHmTZFzrZV+/TSUs=; b=cV5Ulta7XxLDd7789aAwg5MJF3D8WKs/h3xnOPu0czoeykX6zCgdnn/00BvDEUfNhZ FnAGvAK1FOy+DVC7MfUI9lOv4VI6WKjq/wWELkHYKhKGx/0UXpS5gF99N/BpXReeuzAh Hq2IPZcCm6qH3vXrMZF+Q+4zzGclNEovPtHKCYWO4Ua1DGgEsjB8MQVnYUYqBq3AIYbz tMjFycyH10C2MX/qrhd4UWcjteF+2n6rnP++Gmz9xMl4bwkn3TACfZZn6PkEMsemm39W SoE3bwpsISbhFZvSe2xMwi0Sur4xCYbSHRQfkg1yOGooJcLERt3+kqBVIVbF4+dzVXgp cucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717600118; x=1718204918; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6erns6P7m66pg24yXk3vygFkTJngHmTZFzrZV+/TSUs=; b=oQ91x/1Y/na7ZyNPa3E3dSyKXdDTOWGfwKQe5+nsaFK1WK2ArKLjbzMyEUbqBbqez2 QGITljLBfeiDDrOg74i4PTkwghtkmsdjg69oewaiPbxXeN9yNmlebnW/cXApOaGfHyk+ KQuXBc1j4INVi8HXixhN9MGtfFFYNLGoqa9AX0Trci+PhLJ6yjn/jaxudCBVbH9i+9Zj qVeb0QnVplZBTU00px31F7UV9gW/JTojLfJ79oMB51ZSrSY5pSgy1a49yHDVfvzNJ3Dm 77ETnnqCb2/hbh99jV2ZmjHDe1rypBd0IvWTZPLY4XAeL1pT2yqzsyowVOq4Arqf9v/Q hYyQ== X-Forwarded-Encrypted: i=1; AJvYcCXChmdB4p4THOqYpzSuDEtYCrTtSD5KerzLO4kbBWNXzlnjBb9OMoKibCMxDTuROMjmFz4ATGgCvwaRWvlBvJq/CQCOGIEgGLZTU+ZF X-Gm-Message-State: AOJu0YzCUUdac85Bgu9XnYx31oDIehhOglygF/KruKmem/wWRV91q7u6 qnAgmf683/MZlIwernDiiCrAyuT+du6QThO3rmtAsFjYUnDOpfew X-Received: by 2002:a05:600c:1554:b0:41a:2044:1b3e with SMTP id 5b1f17b1804b1-4215633812fmr22794165e9.32.1717600118154; Wed, 05 Jun 2024 08:08:38 -0700 (PDT) Received: from debian.local (host-92-13-19-4.as13285.net. [92.13.19.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158148f91sm26280455e9.30.2024.06.05.08.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 08:08:37 -0700 (PDT) Date: Wed, 5 Jun 2024 16:08:34 +0100 From: Chris Bainbridge To: kernel test robot Cc: Mario Limonciello , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, hughsient@gmail.com Subject: Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization Message-ID: References: <20240528210319.1242-1-mario.limonciello@amd.com> <202406040928.Eu1gRIWv-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202406040928.Eu1gRIWv-lkp@intel.com> On Tue, Jun 04, 2024 at 10:02:29AM +0800, kernel test robot wrote: > Hi Mario, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on drm-misc/drm-misc-next] > [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.10-rc2 next-20240603] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/drm-client-Detect-when-ACPI-lid-is-closed-during-initialization/20240529-050440 > base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > patch link: https://lore.kernel.org/r/20240528210319.1242-1-mario.limonciello%40amd.com > patch subject: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization > config: i386-randconfig-053-20240604 (https://download.01.org/0day-ci/archive/20240604/202406040928.Eu1gRIWv-lkp@intel.com/config) > compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240604/202406040928.Eu1gRIWv-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406040928.Eu1gRIWv-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > ld: drivers/gpu/drm/drm_client_modeset.o: in function `drm_client_match_edp_lid': > >> drivers/gpu/drm/drm_client_modeset.c:281:(.text+0x221b): undefined reference to `acpi_lid_open' > > > vim +281 drivers/gpu/drm/drm_client_modeset.c > > 260 > 261 static void drm_client_match_edp_lid(struct drm_device *dev, > 262 struct drm_connector **connectors, > 263 unsigned int connector_count, > 264 bool *enabled) > 265 { > 266 int i; > 267 > 268 for (i = 0; i < connector_count; i++) { > 269 struct drm_connector *connector = connectors[i]; > 270 > 271 switch (connector->connector_type) { > 272 case DRM_MODE_CONNECTOR_LVDS: > 273 case DRM_MODE_CONNECTOR_eDP: > 274 if (!enabled[i]) > 275 continue; > 276 break; > 277 default: > 278 continue; > 279 } > 280 > > 281 if (!acpi_lid_open()) { > 282 drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is closed, disabling\n", > 283 connector->base.id, connector->name); > 284 enabled[i] = false; > 285 } > 286 } > 287 } > 288 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki The failed config has CONFIG_ACPI_BUTTON=m. The build failure can be fixed with: diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index b76438c31761..0271e66f44f8 100644 --- a/drivers/gpu/drm/drm_client_modeset.c +++ b/drivers/gpu/drm/drm_client_modeset.c @@ -271,11 +271,13 @@ static void drm_client_match_edp_lid(struct drm_device *dev, if (connector->connector_type != DRM_MODE_CONNECTOR_eDP || !enabled[i]) continue; +#if defined(CONFIG_ACPI_BUTTON) if (!acpi_lid_open()) { drm_dbg_kms(dev, "[CONNECTOR:%d:%s] lid is closed, disabling\n", connector->base.id, connector->name); enabled[i] = false; } +#endif } }