Received-SPF: pass (google.com: domain of linux-kernel+bounces-202806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240604155257.109500-1-mjguzik@gmail.com> <20240604155257.109500-4-mjguzik@gmail.com>
 <20240605-sonnabend-busbahnhof-3f93ffcac846@brauner>
In-Reply-To: <20240605-sonnabend-busbahnhof-3f93ffcac846@brauner>
From: Mateusz Guzik <mjguzik@gmail.com>
Date: Wed, 5 Jun 2024 17:10:23 +0200
Message-ID: <CAGudoHG-YVNui5NW7hx8dXJiYaM_L5_uMQB2bmwRVkOg03NKFw@mail.gmail.com>
Subject: Re: [PATCH 3/3] vfs: shave a branch in getname_flags
To: Christian Brauner <brauner@kernel.org>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 5, 2024 at 5:03=E2=80=AFPM Christian Brauner <brauner@kernel.or=
g> wrote:
>
> On Tue, Jun 04, 2024 at 05:52:57PM +0200, Mateusz Guzik wrote:
> > Check for an error while copying and no path in one branch.
>
> Fine to move that check up but we need to redo it after we recopied.
> It's extremely unlikely but the contents could've changed iirc. I can
> fix that up though.

Oh I see, you mean the buffer might have initially been too big so it
landed in the zmalloc fallback, but by that time userspace might have
played games and slapped a NUL char in there.

Fair, but also trivial to fix up, so I would appreciate if you sorted
it out, especially since you offered :)

--=20
Mateusz Guzik <mjguzik gmail.com>